Changeset 3767752 for softminal-cache/trunk/app/Edge/Edge.php

Timestamp:

10/27/2026 04:42:52 AM (23 hours ago)

Author:

softminal

Message:

Release 1.1.1: multisite security fixes for the CDN address and the shared Cloudflare token

File:

• softminal-cache/trunk/app/Edge/Edge.php (modified) (5 diffs)

softminal-cache/trunk/app/Edge/Edge.php

@@ -84 +84 @@
     public static function connect(string $token): array
     {
+        if (!self::mayManage()) {
+            return ['ok' => false, 'error' => self::networkOnly()];
+        }
         $fromConstant = self::fromConstant();
         $token        = $fromConstant ? (string) self::token() : trim($token);
@@ -103 +106 @@
 
         return ['ok' => true];
+    }
+
+    /**
+     * Whether the current user may connect, disconnect, switch purging or clear the whole zone. A token
+     * set in wp-config.php is shared by every site of a network, so there only a network admin may
+     * (WP-CLI and cron count as the server; an anonymous web request does not).
+     */
+    public static function mayManage(): bool
+    {
+        return !self::fromConstant() || !is_multisite() || self::serverContext() || current_user_can('manage_network_options');
+    }
+
+    /** WP-CLI or a cron run: the server acting, not a visitor. An anonymous web request is not one. */
+    public static function serverContext(): bool
+    {
+        return (defined('WP_CLI') && WP_CLI) || wp_doing_cron();
+    }
+
+    public static function networkOnly(): string
+    {
+        return __('On a network, only a network admin can use the Cloudflare token set in wp-config.php.', 'softminal-cache');
     }
 
@@ -136 +160 @@
         }
         if (array_key_exists('cloudflare_purge', $input)) {
-            $data['cloudflare']['purge'] = (bool) filter_var($input['cloudflare_purge'], FILTER_VALIDATE_BOOLEAN);
+            $purge = (bool) filter_var($input['cloudflare_purge'], FILTER_VALIDATE_BOOLEAN);
+            if ($purge !== $data['cloudflare']['purge'] && !self::mayManage()) {
+                return ['ok' => false, 'error' => self::networkOnly()];
+            }
+            $data['cloudflare']['purge'] = $purge;
         }
         self::put($data);
@@ -158 +186 @@
                 'unreadable'   => $data['cloudflare']['zone_id'] !== '' && self::token() === null,
                 'constant'     => self::fromConstant(),
+                'canManage'    => self::mayManage(),
                 'zone'         => $data['cloudflare']['zone_name'],
                 'purge'        => $data['cloudflare']['purge'],
@@ -202 +231 @@
             $token = (string) self::token();
             $zone  = $data['cloudflare']['zone_id'];
-            $reply = $all ? Cloudflare::purgeAll($token, $zone) : Cloudflare::purgeUrls($token, $zone, $urls);
-            $data['cloudflare']['last'] = self::result($reply, $all, count($urls));
+            // A shared (network) token clears the whole zone only for a network admin; for anyone else
+            // "everything" means this site's homepage plus what changed, never the other sites' pages.
+            $zoneWide = $all && self::mayManage();
+            $files    = $all && !$zoneWide ? array_values(array_unique(array_merge([home_url('/')], $urls))) : $urls;
+            $reply    = $zoneWide ? Cloudflare::purgeAll($token, $zone) : Cloudflare::purgeUrls($token, $zone, $files);
+            $data['cloudflare']['last'] = self::result($reply, $zoneWide, count($files));
         }
         if (self::varnishOn()) {