Changeset 3764005 for langforge/trunk/langforge.php

Timestamp:

10/25/2026 06:29:16 AM (27 hours ago)

Author:

avakodeforge

Message:

Release 1.3.0 (trunk + tag; see readme changelog)

File:

• langforge/trunk/langforge.php (modified) (5 diffs)

langforge/trunk/langforge.php

@@ -4 +4 @@
  * Plugin URI: https://langforgewp.com
  * Description: Multilingual plugin for WordPress — language routing (4 URL formats), manual translation, language switcher, string translation, hreflang SEO, Glossary, WooCommerce, unlimited languages, REST/WP-CLI, WPML compatibility, and one-click migration. AI translation available via the Lang Forge Pro add-on.
- * Version: 1.2.12
+ * Version: 1.3.0
  * Author: Avakode
  * Author URI: https://avakode.com
@@ -19 +19 @@
 }
 
-define('LANGFORGE_VERSION', '1.2.12');
+define('LANGFORGE_VERSION', '1.3.0');
 // Schema version is independent from plugin version. Bump only when one of
 // the langforge_* tables changes shape; LANGFORGE_Schema::maybe_upgrade compares
@@ -391 +391 @@
 
         // - Taxonomy terms (`category`, `post_tag`, `tax_*`, any registered taxonomy):
-        // prefer the legacy WPML table `wp_icl_translations`. LangForge's own
-        // `get_translation_id` doesn't filter by element_type, so a stray row
-        // with the same element_id under a different element_type (e.g. an
-        // acf-field-group row carrying a numeric ID that happens to match a
-        // term_id) returns the wrong translation. Filtering by element_type
-        // via wp_icl_translations gives a clean lookup that matches WPML's
-        // behavior even on partly-migrated sites.
+        // LangForge's own term pairs first (LANGFORGE_Taxonomy_Translation,
+        // element_type `tax_<taxonomy>`: the lookup is strictly by taxonomy), then
+        // the legacy WPML table `wp_icl_translations`. The post lookup of
+        // `get_translations` is never asked for a term: it doesn't filter by
+        // element_type, so a stray row with the same element_id under a different
+        // element_type (e.g. an acf-field-group row carrying a numeric ID that
+        // happens to match a term_id) returns the wrong translation. The legacy
+        // table is filtered by element_type too, which matches WPML's behavior
+        // even on partly-migrated sites.
 
         // - Posts / pages / custom post types: consult LangForge's native table
@@ -426 +428 @@
 
         if ($is_term_type) {
+            // Lang's own pairs of terms first (strictly by taxonomy), the legacy table only as the fallback.
+            $own = LANGFORGE_Post_Translation::instance()->get_term_translation_id($element_id, $element_type, $language_code);
+            if ($own !== null) return $own;
             $wpml_type = (strpos($element_type, 'tax_') === 0) ? $element_type : 'tax_' . $element_type;
             $found = $wpml_lookup($element_id, $wpml_type);
@@ -475 +480 @@
 
 /**
+ * WPML's language constants (BUG-LANG-INTEG-01). WPML defines ICL_LANGUAGE_CODE, ICL_LANGUAGE_NAME and
+ * ICL_LANGUAGE_NAME_EN together with the filters above, and a neighbour that sees the filters reads the
+ * constants next: WP Recipe Maker stops every post.php with "Undefined constant ICL_LANGUAGE_CODE" without
+ * them. Polylang's WPML layer defines the same three, so neighbours already live with them and no SitePress.
+ *
+ * Defined on init 2, after detect_language on init 1 has settled the language of the request. Never when
+ * the real WPML is in play (it defines them itself) nor when another plugin got there first.
+ */
+function langforge_wpml_language_constants() { // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals -- intentional ACF/WPML/core compatibility
+    if (langforge_wpml_real_plugin_in_play() || defined('ICL_LANGUAGE_CODE')) {
+        return;
+    }
+    $core = LANGFORGE_Core::instance();
+    $code = $core->get_current_language();
+    $info = $core->get_language_info($code) ?: [];
+    define('ICL_LANGUAGE_CODE', $code); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals -- WPML's own constant, read by neighbours
+    if (!defined('ICL_LANGUAGE_NAME')) {
+        define('ICL_LANGUAGE_NAME', $info['native_name'] ?? $code); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals -- WPML's own constant, read by neighbours
+    }
+    if (!defined('ICL_LANGUAGE_NAME_EN')) {
+        define('ICL_LANGUAGE_NAME_EN', $info['name'] ?? $code); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals -- WPML's own constant, read by neighbours
+    }
+}
+add_action('init', 'langforge_wpml_language_constants', 2);
+
+/**
  * Detect whether the real WPML (sitepress-multilingual-cms) is or is
  * about to be active in the current request. Used by the WPML