Changeset 3764005 for langforge/trunk/includes/class-rest-api.php

Timestamp:

10/25/2026 06:29:16 AM (39 hours ago)

Author:

avakodeforge

Message:

Release 1.3.0 (trunk + tag; see readme changelog)

File:

• langforge/trunk/includes/class-rest-api.php (modified) (3 diffs)

langforge/trunk/includes/class-rest-api.php

@@ -111 +111 @@
         ];
 
+        // BUG-LANG-GLOSS-02: the glossary terms a saved translation does not follow. Read-only and for the edit
+        // context (the response of a save, the editor): a warning never refuses or changes a save.
+        $glossary_field = [
+            'get_callback' => [$this, 'get_post_glossary_warnings_field'],
+            'schema' => [
+                'description' => 'Warnings of the glossary check of a translation: the terms it does not follow',
+                'type' => 'array',
+                'items' => ['type' => 'string'],
+                'context' => ['edit'],
+                'readonly' => true,
+            ],
+        ];
+
         foreach ($post_types as $post_type) {
             // Canonical prefixed REST fields.
             register_rest_field($post_type, 'langforge_language', $language_field);
             register_rest_field($post_type, 'langforge_translations', $translations_field);
+            register_rest_field($post_type, 'langforge_glossary_warnings', $glossary_field);
             // Deprecated lf_ aliases — kept so the block-editor sidebar and any
             // existing headless client that reads/writes the old field names
@@ -340 +354 @@
     }
 
+    /** @return string The glossary warnings of a translation, for who may edit it (LANGFORGE_Post_Translation::glossary_warnings). */
+    public function get_post_glossary_warnings_field($post) {
+        $post_id = $this->rest_object_id($post);
+        if ($post_id <= 0 || !current_user_can('edit_post', $post_id)) {
+            return [];
+        }
+        return LANGFORGE_Post_Translation::instance()->glossary_warnings($post_id);
+    }
+
     public function update_post_language_field($value, $post) {
         if (!current_user_can('edit_post', $post->ID)) {
@@ -364 +387 @@
         // asked about: current_user_can('read_post') for such a post is a _doing_it_wrong in
         // map_meta_cap and judged by another capability. No type, no right to read.
+        // A published translation is public, and a visitor who is not signed in has no capability
+        // at all, `read` included: current_user_can('read_post') is false for him even for a
+        // published post. So a published member is listed for everyone, the way core's own
+        // WP_REST_Posts_Controller::check_read_permission lets a visitor read a published post;
+        // a draft, a pending, a scheduled or a private member only for who may read it
+        // (BUG-LANG-REST-01).
+
+        // And only a member of the type of the post asked about: a group links posts of one type
+        // (the metabox and the link command refuse the rest), so a member of another type is a
+        // migrated or hand-edited row, and its id is not handed out to anyone, with whatever status.
         $pt      = LANGFORGE_Post_Translation::instance();
+        $type    = get_post_type($post_id);
         $visible = [];
         foreach ($translations as $lang => $tid) {
-            if ($pt->translation_type_is_registered((int) $tid) && current_user_can('read_post', (int) $tid)) {
+            if (get_post_type((int) $tid) !== $type) {
+                continue;
+            }
+            if (!$pt->translation_type_is_registered((int) $tid)) {
+                continue;
+            }
+            if (current_user_can('read_post', (int) $tid) || get_post_status((int) $tid) === 'publish') {
                 $visible[$lang] = $tid;
             }