WordPress.org

Plugin Directory

podpress

Opened 5 years ago

Closed 5 years ago

#962 closed defect (fixed)

bypass of the RSS Feed does not work (and a patch for this)

Reported by: ntm Owned by: seek3r
Priority: normal Severity: normal
Plugin: podpress Keywords:
Cc:

Description

i have discovered that the bypass

add_action('do_feed_rss'

in the podpress.php : 188 does not work (with WP 2.7.x) as it should.

I'm thinking that it is necessary to remove the original action first with

remove_action('do_feed_rss', 'do_feed_rss', 10, 1);

as it works for the ATOM feed bypass.

Furthermore i'm thinking that the function podPress_do_feed_rss2 should contain a statement for the case that the WP function do_feed_rss2 exists e.g.

	function podPress_do_feed_rss2($withcomments) {
		podPress_addFeedHooks();
		if (!function_exists('do_feed_rss2')) {
			load_template(ABSPATH.'wp-rss2.php');
		} else {
			do_feed_rss2($withcomments);
		}
	}

Only with this change the RSS 1.0 bypass will work.

And if you do this then the functions podPress_do_feed_premium and podPress_do_feed_podcast should be revised, too.

The changes i'm suggesting are in the attached file.

Attachments (2)

podpress.patch (718 bytes) - added by ntm 5 years ago.
patch for the podpress.php (differences against rev. 98699)
podpress.php (29.0 KB) - added by ntm 5 years ago.
with the changed podPress_do_feed_torrent function

Download all attachments as: .zip

Change History (4)

ntm5 years ago

patch for the podpress.php (differences against rev. 98699)

comment:1 ntm5 years ago

the function podPress_do_feed_torrent should probably be changed, too.

ntm5 years ago

with the changed podPress_do_feed_torrent function

comment:2 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [99682]

Note: See TracTickets for help on using tickets.