WordPress.org

Plugin Directory

jetpack

Opened 4 years ago

Closed 4 years ago

#2088 closed defect (duplicate)

Sharing / Mobile Theme: 2 Textdomains missing context/ context translation function

Reported by: daveshine Owned by: tmoorewp
Priority: normal Severity: normal
Plugin: jetpack Keywords: sharing minileven i18n has-patch upstream
Cc: daveshine, jeremy+wp@…

Description

For Jetpack 2.7 those following 2 strings use the wrong function currently, as the context is there but they use the translation function without context. Those 2 bugs are already there for quite a few versions, I list the files and line numbers for Jetpack v2.7:

in /modules/sharedaddy/sharing-sources.php, line 499:
this:

__( 'Reddit', 'share to', 'jetpack' )

should become this:

_x( 'Reddit', 'share to', 'jetpack' )

just change __() to _x()

---> otherwise textdomain error, translation will not be displayed...

and in /modules/minileven/theme/pub/minileven/image.php, line 87:
this:
<?php _e( 'Image navigation', 'next-saturday' , 'jetpack' ); ?>

should become this:
<?php _ex( 'Image navigation', 'next-saturday' , 'jetpack' ); ?>

just change _e() to _ex()

---> otherwise textdomain error, translation will not be displayed...

Attachments (1)

2088.diff (1.9 KB) - added by jeherve 4 years ago.
Sharing / Minileven: fix translation functions, props @daveshine

Download all attachments as: .zip

Change History (4)

comment:1 @daveshine4 years ago

  • Cc daveshine added

comment:2 @jeherve4 years ago

  • Cc jeremy+wp@… added
  • Keywords sharing minileven i18n has-patch upstream added
  • Summary changed from 2 Textdomains missing context/ context translation function to Sharing / Mobile Theme: 2 Textdomains missing context/ context translation function

@jeherve4 years ago

Sharing / Minileven: fix translation functions, props @daveshine

comment:3 @jeherve4 years ago

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.