WordPress.org

Plugin Directory

jetpack

Opened 4 years ago

Closed 4 years ago

#2052 closed enhancement (duplicate)

Twitter Cards: handle plugin conflicts separately from OG tags

Reported by: jeherve Owned by: tmoorewp
Priority: normal Severity: normal
Plugin: jetpack Keywords: twitter og open-graph plugin-compat
Cc: jeherve, richardmtl, csonnek, ryancowles

Description

Here is how we handle twitter cards plugin conflicts today:

If another Twitter Card plugin is activated, we not only disable Jetpack Twitter Cards, we also disable Jetpack's Open Graph tags.

Now that the twitter cards include the jetpack_disable_twitter_cards filter (see r808325), we could only disable Jetpack twitter cards.

Attachments (2)

better_twitter_conflicts.diff (9.3 KB) - added by jeherve 4 years ago.
Twitter Cards: disable them when another Twitter Card plugin is active
2052.diff (8.5 KB) - added by jeherve 4 years ago.
Twitter Cards: handle plugin conflicts separately from OG tags

Download all attachments as: .zip

Change History (7)

@jeherve4 years ago

Twitter Cards: disable them when another Twitter Card plugin is active

comment:1 @jeherve4 years ago

Adding the jetpack_twitter_tags filter doesn't seem to help us change the value of twitter:site, unfortunately.

@jeherve4 years ago

Twitter Cards: handle plugin conflicts separately from OG tags

comment:2 @jeherve4 years ago

  • Keywords upstream removed

comment:3 @jeherve4 years ago

System is a bit improved in r809004, but since the twitter cards are hooked at the end of the Jetpack Open graph tags, if you remove the OG tags the Twitter tags will disappear as well.

r809004 will help when someone uses Jetpack and a Twitter plugin. We'll need to revisit this code to handle cases when someone uses Jetpack and an Open Graph plugin; in such cases both the OG tags and the Twitter cards will get disabled.

comment:4 @jeherve4 years ago

  • Keywords has-patch removed

comment:5 @jeherve4 years ago

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.