WordPress.org

Plugin Directory

jetpack

Opened 4 years ago

Closed 4 years ago

#1924 closed defect (duplicate)

Comments: add RTL support

Reported by: yellyc Owned by: tmoorewp
Priority: normal Severity: normal
Plugin: jetpack Keywords: comments rtl
Cc: jeremy+wp@…, yellyc, richard@…

Description

Currently, all the elements in the jetpack comments iFrame are left aligned, even on RTL (right-to-left) sites (such as in hebrew or arabic).
In order to fix this, the site must add a parameter to the iFrame content's url indicating whether the site is an RTL site, and if it is, the server on wp.com's end must add a stylesheet that loads after the main stylesheet that corrects the layout for RTL.
I have created a diff that adds the "rtl" parameter which is 1 for RTL sites and 0 for LTR sites. I have also written the stylsheet that needs to be added to the comment form. Since I have no access to the wp.com server, I cannot write the code that adds the stylesheet when needed.
yelly

Attachments (2)

comments-rtl-param.diff (659 bytes) - added by yellyc 4 years ago.
Add "rtl" param to comments form request url
comments-rtl.css (1.8 KB) - added by yellyc 4 years ago.
Stylesheet to correct layout of comment form for RTL site

Download all attachments as: .zip

Change History (8)

@yellyc4 years ago

Add "rtl" param to comments form request url

@yellyc4 years ago

Stylesheet to correct layout of comment form for RTL site

comment:1 @yellyc4 years ago

  • Component changed from not-listed to jetpack
  • Owner set to tmoorewp

comment:2 @jeherve4 years ago

  • Cc jeremy+wp@… added
  • Keywords comments rtl added
  • Summary changed from RTL support for jetpack comments to Comments: add RTL support
  • Type changed from enhancement to defect

comment:3 @yellyc4 years ago

  • Cc yellyc added

comment:5 @richardmtl4 years ago

  • Cc richard@… added

comment:6 @richardmtl4 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

I've ported this ticket over to Github:

https://github.com/Automattic/jetpack/issues/215

I didn't transfer over your changed files though, because the develpers may want to do it a different way. However, I encourage you to submit a pull request and reference that issue in your pull request.

Note: See TracTickets for help on using tickets.