WordPress.org

Plugin Directory

jetpack

Opened 4 years ago

Closed 4 years ago

#1833 closed defect (duplicate)

Shortcodes: slideshow-shortcode.js uses ? for URL parameters when & is correct

Reported by: richardmtl Owned by: tmoorewp
Priority: normal Severity: normal
Plugin: jetpack Keywords: shortcodes slideshow
Cc: jeremy+wp@…

Description

On line 42 in slideshow-shortcode.js the "w" parameter is added to the image URL
using a question mark.

Sometimes images already have parameters.

This will lead to invalid URLs like example.com/image.jpg?n=1?w=200

An easy fix would be to use a question mark only if there are no parameters
present in the image URL. In all other cases use an ampersand instead.

Change History (2)

comment:1 @jeherve4 years ago

  • Cc jeremy+wp@… added
  • Keywords shortcodes added
  • Summary changed from slideshow-shortcode.js uses ? for URL parameters when & is correct to Shortcodes: slideshow-shortcode.js uses ? for URL parameters when & is correct

comment:2 @jeherve4 years ago

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.