WordPress.org

Plugin Directory

jetpack

Opened 5 years ago

Closed 4 years ago

#1713 closed defect (duplicate)

Google Maps shortcode: iFrame code is not automatically transformed into the shortcode

Reported by: jeherve Owned by: georgestephanis
Priority: low Severity: minor
Plugin: jetpack Keywords: shortcodes google-maps
Cc: jeherve, richard@…

Description

Steps to reproduce:

  1. Go to google.com/maps, and create a map
  2. Click on the link icon, and copy the iFrame code
  3. On your Jetpack site (with the Shortcodes module active), create a new post and paste the iFrame code.
  4. Publish the post
    • Expected result: the shortcode is automatically created based on the iFrame (see behaviour on WordPress.com)
    • Result: the iFrame code is not changed

Change History (4)

comment:1 @georgestephanis5 years ago

  • Owner changed from tmoorewp to georgestephanis

comment:2 @georgestephanis5 years ago

We need the shortcode to support legacy content that may use it (for example, when importing from WordPress.com where iframes aren't allowed in content, or any other WordPress Multi Site install in a similar situation) -- but we shouldn't forcibly change users iframes to shortcodes if they can use iframes, as we don't want to forcibly lock the users in to Jetpack! If we did that, and they deactivated Jetpack, then suddenly all their Google Maps would go away.

That being said, I wouldn't object to adding a conditional where if the user isn't allowed to post iframes, we swap them to the shortcode before it would otherwise get stripped out. Only doing this if there is no other way to preserve their content.

comment:3 @richardmtl4 years ago

  • Cc richard@… added

comment:4 @jeherve4 years ago

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.