WordPress.org

Plugin Directory

jetpack

Opened 2 years ago

Closed 19 months ago

#1706 closed defect (fixed)

Infinite Scroll is not active on search results

Reported by: kwight Owned by: ethitter
Priority: normal Severity: normal
Plugin: jetpack Keywords: infinite-scroll has-patch
Cc: jeremy+wp@…, johnwilsonuk, miguel.fonseca@…

Description

Infinite Scroll does not work on search results, as search is not included in the default $supported check.

Attachments (3)

1706.diff (912 bytes) - added by kwight 2 years ago.
1706.2.diff (2.4 KB) - added by georgestephanis 2 years ago.
1706.3.diff (7.9 KB) - added by jeherve 22 months ago.

Download all attachments as: .zip

Change History (12)

@kwight2 years ago

comment:1 @kwight2 years ago

Oops, that patch won't work. IS will load /page/2/ rather than /page/2/?s=search

I assume the search string needs to be appended in ajax_url(). I leave it to the professionals.

comment:2 @georgestephanis2 years ago

  • Owner changed from tmoorewp to georgestephanis
  • Status changed from new to assigned

@georgestephanis2 years ago

comment:3 @georgestephanis2 years ago

I think that patch should do it. I'm testing it to confirm, kwight -- if you can test it on your end too, and let me know if anything seems to break, that'd be awesome! :)

comment:4 @georgestephanis2 years ago

  • Owner changed from georgestephanis to ethitter
  • Status changed from assigned to new

Passing it over to ethitter as there were some wp_query issues he'd found, that I hadn't anticipated.

@jeherve22 months ago

comment:6 @jeherve22 months ago

  • Cc jeremy+wp@… added
  • Keywords has-patch added

comment:7 @johnwilsonuk22 months ago

  • Cc johnwilsonuk added

comment:8 @mcsf21 months ago

  • Cc miguel.fonseca@… added

comment:9 @jeherve19 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r777844, props mcsf

Note: See TracTickets for help on using tickets.