WordPress.org

Plugin Directory

login-security-solution

Opened 5 years ago

Closed 5 years ago

#1552 closed defect (fixed)

Unit test expected results file names contain invalid characters

Reported by: deanmarktaylor Owned by: convissor
Priority: normal Severity: normal
Plugin: login-security-solution Keywords: error, ftp, filename, files, file, transfer, windows, linux, naming
Cc:

Description

This is due to these files having invalid filenames on Windows systems, file names should not contain ":" (colons).

These files cause issues during installation on a Windows based system and colons are replaced with underscores.
In addition Windows <> Linux interoperability is affected, FTP transfers of said files from Linux to Windows fails with the error The directory or file cannot be created.

The manual installation of the plugin might also be affected depending on the archiving software used to extract the "zip" file and it's handling of the characters.

The specific files are as follows:

  • tests/expected/LoginFailTest::test_process_login_fail__post_threshold
  • tests/expected/LoginFailTest::test_wp_login__post_breach_threshold

Also as per WordPress Coding Standards:

Files should be named descriptively using lowercase letters. Hyphens should separate words.

Change History (1)

comment:1 @convissor5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Renamed files in release 0.17.0.

Note: See TracTickets for help on using tickets.