WordPress.org

Plugin Directory

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1275 closed defect (fixed)

Grunion Contact Form causes error if Akismet is not active

Reported by: davecpage Owned by: josephscott
Priority: normal Severity: normal
Plugin: not-listed Keywords: grunion
Cc:

Description

Grunion Contact Form has a couple of points where the assumption is that Akismet is active, yet there is also code in an attempt to detect if Akismet is not active and to not pass messages through the service. This ticket is to provide a patch which restores this auto checking of Akismet.

Attachments (2)

akismet-fix.diff (1.8 KB) - added by davecpage 3 years ago.
grunion-akismet-trunk-fix.diff (2.1 KB) - added by davecpage 3 years ago.
Updated patch to work against trunk

Download all attachments as: .zip

Change History (6)

davecpage3 years ago

comment:1 josephscott3 years ago

Can you take a look at -trunk and see if this patch is still needed.

davecpage3 years ago

Updated patch to work against trunk

comment:2 davecpage3 years ago

Trunk still has an issue where if you mark a feedback as spam or ham within the admin it tries to call the function contact_form_akismet_submit. Have updated the patch to work against trunk. It uses filters/actions so possible for other plugins to hook into too.

Version 0, edited 3 years ago by davecpage (next)

comment:3 follow-up: josephscott3 years ago

  • Owner set to josephscott
  • Resolution set to fixed
  • Status changed from new to closed

In [346594]:

Fix other cases where Grunion might try to use Akismet functions, even
if the Akismet plugin isn't active.

Fixes #1275

comment:4 in reply to: ↑ 3 davecpage3 years ago

Replying to josephscott:

In [346594]:

Fix other cases where Grunion might try to use Akismet functions, even
if the Akismet plugin isn't active.

Fixes #1275

Just checking, but wouldn't the change on line 439 of admin.php cause Akismet to resubmit a comment as spam even though you're marking the comment as not spam in the admin?

Note: See TracTickets for help on using tickets.