WordPress.org

Plugin Directory

akismet

Opened 3 years ago

Closed 3 years ago

#1248 closed defect (fixed)

Numerous i18n issues

Reported by: dimadin Owned by: matt
Priority: normal Severity: normal
Plugin: akismet Keywords: has-patch
Cc: tracs@…, josephscott, dimadin

Description

Version of Akismet included in WordPress trunk has numerous i18n issues. Most of them are included in my patch below while others are mentioned.

Issues are:

  • String out of gettext
  • Plural strings out of _n
  • Spitted sentences (very i18n unfriendly)

Most notable example of last is sentence shown at dashboard. In current form, it can't be friendly to any language, even English. I suggest splitting to two separate sentences, in my case separated with <br />. See wp-polyglots and #1212 for more.

Other issues not covered with patch:

  • lines 290 and 349 in admin.php
  • line 15 in widget.php

In all three cases we need _n.

Note that there are several strings with two variables where both are %s instead of %1$s and %2$s. Not important for me but it might be for some languages.

Also note that I didn't test this patch.

I suggest you one thing not related to i18n. In widget.php you should use plugins_url function instead of this variables, you don't need current hack since 3.0 is required anyway.

Please fix this as soon as possible so that translators can prepare for 3.1 release.

Attachments (2)

akismet_i18n.patch (5.7 KB) - added by dimadin 3 years ago.
akismet_i18n_2.patch (10.0 KB) - added by dimadin 3 years ago.

Download all attachments as: .zip

Change History (5)

dimadin3 years ago

comment:1 josephscott3 years ago

  • Cc josephscott added
  • Priority changed from high to normal
  • Severity changed from major to normal

Can you test this patch and then follow up

comment:2 dimadin3 years ago

  • Cc dimadin added
  • Keywords has-patch added

Sorry for delay. Email notification doesn't work here.

I updated a patch with 3 fixes mentioned above and tested it and I see no problems. Note that I couldn't test every action since some are for specific cases.

Do we need to use intval at line 353 of admin.php or we can change it to number_format_i18n?

Also note that I added context to string Spam.

dimadin3 years ago

comment:3 josephscott3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [323468]) Translation code updates

fixes #1248
props dimadin

Note: See TracTickets for help on using tickets.