WordPress.org

Plugin Directory

podpress

Opened 4 years ago

Closed 4 years ago

#1083 closed enhancement (fixed)

props / fix for the .m4a player preview of podPress

Reported by: ntm Owned by: seek3r
Priority: normal Severity: normal
Plugin: podpress Keywords: podpress, m4a
Cc: seek3r, azaozz, ntm

Description

podPress shows the video player preview if the podcast file is a .m4a file. That seems to be wrong because there is no way to set a individual preview image for each m4a podcast episode.

The attached changeset includes a new JS function which creates a player preview for the m4a files. This player preview will be like the video player preview but without a preview image and with a lower height. Because there is no input fields for the width and height of the preview player the height is hard coded for now.
But I guess that it would desirable to have such an input form.

Even more desirable for me would be a flash player (or native m4a support of the browser through the HTML5 audio tag) which can play m4a files and show there cover art and meta information. (Maybe the FlowPlayer?)

Furthermore the CSS file contains a minor adjustment: If the mouse is over a .podPress_videoplayer_wrapper then the cursor will indicate that this box is clickable.

Attachments (5)

m4a_player_preview.patch (8.6 KB) - added by ntm 4 years ago.
reworked_player_preview.patch (54.9 KB) - added by ntm 4 years ago.
reworked_player_preview.2.patch (59.9 KB) - added by ntm 4 years ago.
reworked_player_preview.3.patch (68.1 KB) - added by ntm 4 years ago.
new JS podPressPreviewImageOnChange event
reworked_player_preview.4.patch (68.3 KB) - added by ntm 4 years ago.

Download all attachments as: .zip

Change History (8)

ntm4 years ago

comment:1 ntm4 years ago

I have seen that my propositions are only good if the m4a file contains no chapter/cover arts and chapter marks.

I will change the patch in a way that it will be possible to select the size of player preview in the post/page-editor.

@Andrew: Please, don't add this patch to the trunk-version until further notice.

comment:2 ntm4 years ago

reworked_player_preview.patch includes as the name suggests a reworked player preview. This includes changes of the podPress box on the editor pages (podpress_admin_class.php / podpress_admin.js / podpress.js) and the podPress elements at the public blog pages (podPress_theme.php - The attached patch includes the changes from Ticket #1080, too. / podpress_class.php / podpress.js).

I have renamed the media type video_wma to audio_wma because WMA files are audio files. In future version the download button for this file type should be changed, too.

But the main innovation is that it is now possible to choose a player preview without a preview image which is useful for mp4_audio, m4a_audio and wma_audio files. Because especially .m4a files can possibly contain cover and chapter images it is still possible to select a player preview with an preview image.

Minor new things are:

  • changes in the dimensions boxes (editor pages) will change the player preview instantly
  • new predefined values in the dimensions select box(editor pages)
  • new preview player HTML structure

ntm4 years ago

new JS podPressPreviewImageOnChange event

comment:3 ntm4 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.