Plugin Directory


Opened 8 years ago

Closed 8 years ago

#1064 closed defect (fixed)

multiple fixes on the feed/iTunes settings page and feed functions

Reported by: ntm Owned by: seek3r
Priority: normal Severity: major
Plugin: podpress Keywords: podpress, feed
Cc: seek3r, azaozz, ntm


At the "feed/iTunes settings"-page are several select boxes which leave the possibility to select the value grouping sub heading. These select boxes are "iTunes:Categories" and "Language".

The attached .diff file contains the necessary changes in

  • podpress_admin_feed_class.php
  • podpress_admin_functions.php
  • podpress_feed_functions.php

The .diff file contains also updated description for the feed image option (changes in podpress_admin_feed_class.php). In connection to theses changes are the changes in the podpress_admin_wp27plus.css file.
The .diff file contains comparable changes in the podpress_admin_class.php file, too.

The other big change/fix is connected to the option "Aggressively Protect the Feed" at the iTunes/feed settings page. This functionality has changed a little bit: The option 'Yes' doesn't strip out tags but it converts all none-UTF-8 characters to their numeric character references which allows to disclaim the usage of CDATA brackets.
The option 'No' filters only the ampersand, less-than, greater-than, apostrophe and quotation signs and converts them to their numeric character references.

Furthermore the routines which are adding the keywords to the feed channel or the items are reworked, too and compared to 8.8.4 the usage of the function podPress_feedSafeContent is increased, now.

There are new functions which are converting the human-readable duration values of the media files to milliseconds value for the XSPF playlist.

Attachments (3)

new_feed_protection_and_fixes_for_feed_settings_pages.patch (42.9 KB) - added by ntm 8 years ago.
new_feed_protection_and_fixes_for_feed_settings_pages.2.patch (43.2 KB) - added by ntm 8 years ago.
contains now a php version check in the podpress_feed_functions.php
new_feed_protection_and_fixes_for_feed_settings_pages_885b3.patch (65.9 KB) - added by ntm 8 years ago.

Download all attachments as: .zip

Change History (7)

@ntm8 years ago

contains now a php version check in the podpress_feed_functions.php

comment:1 @ntm8 years ago

new_feed_protection_and_fixes_for_feed_settings_pages_885b3.patch includes the a patch for the problem which appears when other media files are added without podPress see the thread http://wordpress.org/support/topic/352327
That patch makes that the non-podPress enclosures are added at the end of the rss2_item and atom_entry action (hook). That's why there are also changes in the podpress.php file.

comment:2 @ntm8 years ago

I meant this thread ttp://wordpress.org/support/topic/372625

comment:4 @ntm8 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.