WordPress.org

Plugin Directory

podpress

Opened 4 years ago

Last modified 4 years ago

#1062 new defect

Fix for the Video Player Preview and the Listen Wrapper

Reported by: ntm Owned by: seek3r
Priority: normal Severity: normal
Plugin: podpress Keywords: player settings, podpress
Cc: seek3r, azaozz, ntm

Description

The preview of the video player layout is made with a table layout which is out of date and more importantly doesn't work for all themes and browsers in the same way.
The wrapper for the audio player is made in the same way.

The attached fix is for the Front- and the backend.

Changes compared to trunk:

podpress.js

  • function podPressGenerateVideoPreview()
    • has a new parameter because the at the editor pages in the backend the old table layout works better in FF 3.5, IE 6, Safari 4.0.4 and Opera 10 than the the new which works at frontend.
    • added the Box-Model Layout
  • function podPressGeneratePlayer()
    • changed listen wrapper layout

podpress_admin_player_class.php (Player settings page)

  • changes for the new listen wrapper

podpress_admin.js

  • new function podPressShowHideWrapper(target_cell_id) which loads the audiplayer into the target cell (this function is used in podpress_admin_player_class.php)

podpress_class.php

  • contains the changes of Ticket #1060
  • insert_content() contains no the right criteria for disabeling only the preview of the video player

podpress_admin_functions.php and podpress_admin_class.php

  • the player preview dimension select-box is repaired: it is no longer possible to select the label "common dimensions" as a dimension and the selected values are selected on loading
  • the podPress_videoDimensionOptions() function has a new parameter for the selected value and contains the necessary changes

podpress_theme.php

  • contains a new div container for the download and player links

podpress.css

  • contains a new definition for the class .podPress_downloadlinks

Attachments (1)

listenwrapper_and_preview_player_fix.diff (27.0 KB) - added by ntm 4 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 ntm4 years ago

if you apply this patch then it is necessary to apply #1065, too. Because #1065 contains some definition of constants which are important to this patch.

Note: See TracTickets for help on using tickets.