WordPress.org

Plugin Directory

podpress

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#1037 closed enhancement (fixed)

enhancements for podPress v8.8.2 (props)

Reported by: ntm Owned by: seek3r
Priority: normal Severity: normal
Plugin: podpress Keywords: enhancements, atom feed, rss feed, xspf feed, license, license tags, widgets, localization
Cc: seek3r, azaozz, ntm

Description

During my research and testing for ticket #1035 and ticket #1036 I have found a lot of other things to which should probably be changed or adjusted so that podPress works better with modern WP version (2.7.x +) together.

At first the main issue i wanted to change was the hard coded license/copyright-tags in the ATOM feed template of podPress. In order to that i suggest to add a input field "URL to the full Copyright / license text" to the feeds/iTunes settings page and to change the input field "RSS Copyright" to a more unspecific name and usage: "Feed Copyright / license name".

I have written a .diff for that and a lot of bug fixes and adjustments and list of the changes I want to suggest:

podpress.php

  • see Ticket #692
  • podpress uses only for WP version older than 2.3 the own ATOM Feed template (Because since this version the WP ATOM Feed template produces valid ATOM 1.0 feeds)

wp-atom1.php

  • see Ticket #1035 (removed call to rss_enclosure() because the enclosures are inserted by a function in podpress_feed_functions.php via the action hooks do_action('atom_entry'))
  • removed hard coded License and Copyright tags (they will be inserted by a function in podpress_feed_functions.php via the action hooks do_action('atom_head') and do_action('atom_entry'))

podpress_admin_class.php

  • see Ticket #1036 (Fix for: autosave sets back "the Post specific settings for iTunes")
  • category feeds settings:
  • for WP version older than 2.7 display scroll bars (this is definitely not a real solution but it makes this section useable again in WP 2.7 and newer)
  • changed input field "RSS Copyright" to "Feed Copyright / license name"
  • new input field "URL to the full Copyright / license text"

podpress_admin.js

  • changes related to the new input element of category feeds settings

podpress_admin_feed_class.php

  • changed input field "RSS Copyright" to "Feed Copyright / license name"
  • new input field "URL to the full Copyright / license text"

podpress_functions.php

  • definition of widget settings window width and height
  • text phrases of the widgets are ready for localization
  • xspf player widget: corrected the url of the xspf.playlist so that the player is able to find the list, now (again?)

podpress_feed_functions.php

  • podPress_rss2_head():
    • added some hopefully better default values
    • changes related to changes to the changes of category feeds settings in podpress_admin_class.php
  • podPress_rss2_item()
    • insertion of the 'dc:rights'-tag if defined (you can define the custom field name podcast_episode_license_name and the custom field name podcast_episode_license_url for every post)
  • podPress_atom_head()
    • see Ticket #1035 (use logo tag instead of the icon tag to insert a feed image)
    • insertion of the 'rights'- and the the 'link rel="license"'-tag if defined for the feed
  • podPress_atom_entry()
    • insertion of the 'rights'- and the the 'link rel="license"'-tag if defined for the entry (you can define the custom field name podcast_episode_license_name (for the 'rights'-tag) and the custom field name podcast_episode_license_url (for the 'link rel="license"'-tag) for every post)
  • podPress_xspf_playlist()
    • changed default values in the head of the feed
    • insertion of the 'license'-tag if the Url to the license tag is defined
  • podPress_getEpisodeLicenseTags()
    • this is a completly new function and creates the licenses tags for the feed entries/item
  • podPress_getEnclosureTags()
    • inserts enclosure tags into the feed entries/item and looks if there is a custom field name with the name 'enclosure' and the same enclosure URL as the podPress enclosure or not to avoid double enclosure-tags()
    • changed xspf enclosure/track-tags
  • podPress_meta_data_enclosure_exists()
    • is a new function which makes the some work for podPress_getEnclosureTags

The attached .diff intercorporates the changes from ticket #1035 and #1036 as mentioned above.

Attachments (4)

podpress_multiple_enhancements.diff (46.5 KB) - added by ntm 4 years ago.
(see the list of the changes in the ticket description)
podpress_multiple_enhancements_v2.diff (45.7 KB) - added by ntm 4 years ago.
fixed a problem in my newly added code in the podpress_feed_functions.php file
podpress_multiple_enhancements_v3.diff (46.3 KB) - added by ntm 4 years ago.
compared to v2: podPress_feedSafeContent (in podpress_feed_functions.php) fixed and changes in line 273 of podpress_admin_feed_class.php (get_bloginfo('blog_charset') instead of get_settings('blog_charset') and get_option('blogcharset'))
podpress_multiple_enhancements_v4.diff (108.6 KB) - added by ntm 4 years ago.
compared to v3: contains by sides other changes a fix of a bug in podpress_admin_feed_class.php

Download all attachments as: .zip

Change History (10)

ntm4 years ago

(see the list of the changes in the ticket description)

ntm4 years ago

fixed a problem in my newly added code in the podpress_feed_functions.php file

comment:1 ntm4 years ago

I have changed the RSS Copyright input field as written above. But now i have made some further test and have discovered that the String will not sanitized correctly by the function podPress_feedSafeContent (in podpress_feed_functions.php).
I'm thinking, that this function is some how superfluous or should be at least enhanced, too.
I'm going to make a proposition in the next days.

ntm4 years ago

compared to v2: podPress_feedSafeContent (in podpress_feed_functions.php) fixed and changes in line 273 of podpress_admin_feed_class.php (get_bloginfo('blog_charset') instead of get_settings('blog_charset') and get_option('blogcharset'))

comment:2 ntm4 years ago

compared to 8.8.1 podpress_multiple_enhancements_v4.diff contains these changes:

  • The custom box on the "edit post/page" pages and on the "add a new post/page" pages are added (for WP >= 2.5) via the WP function "add_meta_box" (which is available since WP 2.5).
  • For the new appearance i have added a new style sheet file: podpress_admin_wp27plus.css. This file contains style definition for WP >= 2.7 and will be used for these versions.
  • I have updated some very old fashioned style definitions of the "Directory Preview" in podpress_admin_functions.php like bgcolor="...". But there a lot more of them in this section and the preview is partially deprecated. Further I have commented out the Yahoo! Podcast preview because that service is shutdown as I have in the Wikipedia.

This preview section needs obviously a lot of ongoing attention if it should be in further versions of podPress. I could recomend to replace all these code lines with a thickbox preview windows which shows an real preview instead of a rebuild preview.

changes in the files:

  • podpress.php
  • 3 new functions: add_podpress_form_box_for_modern_wp(), podpress_box_content_post() and podpress_box_content_page()
  • around line 698: if-condition which uses the add_meta_box() for WP >= 2.5 to add the custom box beneath the post/page editor
  • podPress_admin_head() enhanced with a if-condition which checks the WP version and adds in the case of WP >= 2.7 the style sheet podpress_admin_wp27plus.css
  • podpress_admin_class.php
  • a new function post_form_wp25plus() which is mostly a copy of post_form() but contains in many places small adjustments and is as the name says for WP >= 2.5
  • podpress_admin_feed_class.php
  • there was a bug in ..._v3.diff. Now, I have switch the usage of get_settings('blog_charset') to one call of get_bloginfo('charset') because get_settings is deprecated and get_bloginfo is available at least since WP 1.5 and gives for the parameter charset by default UTF-8 back.
  • podpress_admin_feed_class.php
  • as mentioned above: some style definitions updated (but there is still a lot of old things in it)
  • podpress_admin_wp27plus.css
  • new style sheet file for WP >= 2.7

ntm4 years ago

compared to v3: contains by sides other changes a fix of a bug in podpress_admin_feed_class.php

comment:3 ntm4 years ago

podpress_multiple_enhancements_v4.diff contains also the security checks with wp_nonce_field() and check_admin_referer() on the settings pages "Feed/iTunes Settings", "General Settings" and "Player Settings"

comment:4 garyc402 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [545411]:

Fix: Category page display setting does not override default Presentation settings.

Fixes issue 1037.

comment:5 garyc402 years ago

In [545423]:

Fix: Category page display setting does not override default Presentation settings.

Fixes issue 1037.

comment:6 garyc402 years ago

In [545432]:

Fix: Category page display setting does not override default Presentation settings.

Fixes issue 1037.

Note: See TracTickets for help on using tickets.