Changeset 3799472

Timestamp:

11/13/2026 12:28:48 AM (less than one hour ago)

Author:

nigelbmlt

Message:

Deploy version 1.2.4

Location:

bmlt-workflow/trunk

Files:

• CHANGELOG.md (modified) (1 diff)
• bmlt-workflow.php (modified) (8 diffs)
• readme.txt (modified) (1 diff)
• src/BMLT/Integration.php (modified) (4 diffs)
• src/REST/Handlers/BMLTServerHandler.php (modified) (1 diff)

bmlt-workflow/trunk/CHANGELOG.md

@@ +1 @@
+## 1.2.4 (November 12, 2026)
+- #239 Fixes the whole site slowing to ~35-40s per page (and fatal errors on form pages) when the configured BMLT Root Server is slow or unreachable: server info lookups now use a short 5s timeout, failures are briefly cached so an unreachable server no longer triggers a blocking network call on every page load, REST request and 404, and the version lookup is no longer made during plugin bootstrap on every request.
+- The meeting update form now shows an inline error notice instead of a fatal `wp_die()` when the BMLT server can't be reached, so the rest of the page still renders.
+
 ## 1.2.3 (October 31, 2026)
 - Fixes approving a change to a meeting that has coordinates but no timezone; the timezone is now resolved from the meeting's existing coordinates via the geo service.

bmlt-workflow/trunk/bmlt-workflow.php

@@ -21 +21 @@
  * Plugin URI: https://github.com/bmlt-enabled/bmlt-workflow
  * Description: Workflows for BMLT meeting management!
- * Version: 1.2.3
+ * Version: 1.2.4
  * Requires at least: 5.2
  * Author: @nigel-bmlt
@@ -30 +30 @@
 
 
-define('BMLTWF_PLUGIN_VERSION', '1.2.3');
+define('BMLTWF_PLUGIN_VERSION', '1.2.4');
 
 if ((!defined('ABSPATH') && (!defined('BMLTWF_RUNNING_UNDER_PHPUNIT')))) exit; // die if being called directly
@@ -170 +170 @@
         }
 
+        /**
+         * Render a non-fatal error notice for a shortcode.
+         *
+         * Returned (not wp_die'd) so the surrounding page - theme, header,
+         * footer and any other content - still renders when the BMLT server is
+         * unreachable or misconfigured.
+         *
+         * @param string $message Human-readable error detail.
+         * @return string
+         */
+        private function bmltwf_form_error($message)
+        {
+            return '<div class="bmltwf-error-notice" style="padding:1em;border:1px solid #c00;background:#fff3f3;color:#900;">'
+                . '<strong>' . esc_html__('BMLT Workflow Plugin Error', 'bmlt-workflow') . ':</strong> '
+                . esc_html($message)
+                . '</div>';
+        }
+
         public function bmltwf_meeting_update_form($atts = [], $content = null, $tag = '')
         {
@@ -175 +193 @@
             $bmltwf_bmlt_test_status = get_option('bmltwf_bmlt_test_status', "failure");
             if ($bmltwf_bmlt_test_status != "success") {
-                wp_die("<h4>BMLTWF Plugin Error: BMLT Root Server not configured and tested.</h4>");
+                return $this->bmltwf_form_error(__('BMLT Root Server not configured and tested.', 'bmlt-workflow'));
             }
             // $this->debug_log(("inside shortcode setup"));
@@ -207 +225 @@
             $meeting_counties_and_sub_provinces = $this->bmlt_integration->getMeetingCounties();
             if (is_wp_error($meeting_counties_and_sub_provinces)) {
-                wp_die("<h4>" . __('BMLTWF Plugin Error: Unable to retrieve meeting counties from BMLT server.', 'bmlt-workflow') . "</h4>");
+                return $this->bmltwf_form_error(__('Unable to retrieve meeting counties from BMLT server.', 'bmlt-workflow'));
             }
             $script .= "var bmltwf_counties_and_sub_provinces = " . json_encode($meeting_counties_and_sub_provinces) . ";";
@@ -218 +236 @@
             $meeting_states_and_provinces = $this->bmlt_integration->getMeetingStates();
             if (is_wp_error($meeting_states_and_provinces)) {
-                wp_die("<h4>" . __('BMLTWF Plugin Error: Unable to retrieve meeting states/provinces from BMLT server.', 'bmlt-workflow') . "</h4>");
+                return $this->bmltwf_form_error(__('Unable to retrieve meeting states/provinces from BMLT server.', 'bmlt-workflow'));
             }
             $script .= "var bmltwf_do_states_and_provinces = " . json_encode($meeting_states_and_provinces) . ";";
@@ -229 +247 @@
             $formatarr = $this->bmlt_integration->getMeetingFormats();
             if (is_wp_error($formatarr)) {
-                wp_die("<h4>" . __('BMLTWF Plugin Error: Unable to retrieve meeting formats from BMLT server.', 'bmlt-workflow') . "</h4>");
+                return $this->bmltwf_form_error(__('Unable to retrieve meeting formats from BMLT server.', 'bmlt-workflow'));
             }
 
@@ -245 +263 @@
             $result = rest_get_server()->response_to_data($response, true);
             if (count($result) == 0) {
-                wp_die("<h4>BMLT Workflow Plugin Error: Service bodies not configured.</h4>");
+                return $this->bmltwf_form_error(__('Service bodies not configured.', 'bmlt-workflow'));
             }
             $script .= 'var bmltwf_service_bodies = ' . json_encode($result) . '; ';

bmlt-workflow/trunk/readme.txt

@@ -5 +5 @@
 Requires PHP: 8.0
 License: GPLv2
-Stable tag: 1.2.3
+Stable tag: 1.2.4
 Contributors: nigelbmlt, pjaudiomv
 

bmlt-workflow/trunk/src/BMLT/Integration.php

@@ -114 +114 @@
         }
 
-        if (empty($root_server_version)) {
-            $server_address = \get_option('bmltwf_bmlt_server_address');
-            if ($server_address && $server_address !== 'true' && filter_var($server_address, FILTER_VALIDATE_URL)) {
-                $this->bmlt_root_server_version = $this->bmltwf_get_remote_server_version($server_address);
-            }
-        } else {
+        if (!empty($root_server_version)) {
             $this->bmlt_root_server_version = $root_server_version;
         }
+        // Otherwise resolve the version lazily via getRootServerVersion(). This
+        // class is constructed during plugin bootstrap on every request, so
+        // fetching the version here used to make a blocking HTTP call to the
+        // BMLT server on every page load - taking the whole site down when that
+        // server was slow or unreachable.
     }
 
@@ -143 +143 @@
     }
 
+    /**
+     * Lazily resolve and cache the BMLT root server version.
+     *
+     * @return string|false|null
+     */
+    public function getRootServerVersion()
+    {
+        if ($this->bmlt_root_server_version === null) {
+            $server_address = \get_option('bmltwf_bmlt_server_address');
+            if ($server_address && $server_address !== 'true' && filter_var($server_address, FILTER_VALIDATE_URL)) {
+                $this->bmlt_root_server_version = $this->bmltwf_get_remote_server_version($server_address);
+            }
+        }
+        return $this->bmlt_root_server_version;
+    }
+
     public function update_root_server_version()
     {
         $server_address = \get_option('bmltwf_bmlt_server_address');
-        // Clear the cache to force a fresh fetch
+        // Clear the cache (and any negative-cache marker) to force a fresh fetch
         \delete_transient('bmltwf_server_info_' . md5($server_address));
+        \delete_transient('bmltwf_server_info_fail_' . md5($server_address));
         $new_version = $this->bmltwf_get_remote_server_version($server_address);
         $this->bmlt_root_server_version = $new_version;
@@ -178 +195 @@
     private function bmltwf_get_server_info_cached($server)
     {
+        if (empty($server)) {
+            return false;
+        }
+
         $cache_key = 'bmltwf_server_info_' . md5($server);
-        
+        $fail_key  = 'bmltwf_server_info_fail_' . md5($server);
+
         // Skip cache if nocache parameter is present
         $use_cache = !isset($_GET['nocache']);
-        
+
         if ($use_cache) {
             $cached = \get_transient($cache_key);
@@ -188 +210 @@
                 return $cached;
             }
-        }
-        
+            // Negative cache: if we recently failed to reach the server, don't
+            // block this request on another (likely slow) network call. This
+            // prevents an unreachable/slow BMLT server from stalling every page
+            // load, REST request and 404.
+            if (\get_transient($fail_key) !== false) {
+                return false;
+            }
+        }
+
         $url = $server . "client_interface/json/?switcher=GetServerInfo";
         $headers = array("Accept: */*");
-        $resp = $this->bmltwf_wp_remote_get($url, array('headers' => $headers));
-        
+        // Use a short, explicit timeout so a slow server fails fast rather than
+        // hanging on WP's default timeout and stacking across multiple calls.
+        $resp = $this->bmltwf_wp_remote_get($url, array('headers' => $headers, 'timeout' => 5));
+
         if (is_wp_error($resp) || \wp_remote_retrieve_response_code($resp) != 200) {
+            if ($use_cache) {
+                \set_transient($fail_key, 1, 60);
+            }
             return false;
         }
-        
+
         $data = json_decode(\wp_remote_retrieve_body($resp), true);
         if ($data === null || !isset($data[0])) {
+            if ($use_cache) {
+                \set_transient($fail_key, 1, 60);
+            }
             return false;
         }
-        
+
         // Cache for 1 hour (3600 seconds) if caching is enabled
         if ($use_cache) {
+            \delete_transient($fail_key);
             \set_transient($cache_key, $data[0], 3600);
         }
-        
+
         return $data[0];
     }

bmlt-workflow/trunk/src/REST/Handlers/BMLTServerHandler.php

@@ -111 +111 @@
         if ($current_server !== $server) {
             \delete_transient('bmltwf_server_info_' . md5($server));
+            \delete_transient('bmltwf_server_info_fail_' . md5($server));
         }