Changeset 3789337

Timestamp:

11/07/2026 10:23:07 AM (less than one hour ago)

Author:

kgmservizi

Message:

Release 0.8.0: require PHP 8.0 / WP 5.6, fix fatal errors

Location:

disable-thumbnails-and-threshold

Files:

• tags/0.8.0 (copied) (copied from disable-thumbnails-and-threshold/trunk )
• tags/0.8.0/disable-thumbnails-and-thresold.php (copied) (copied from disable-thumbnails-and-threshold/trunk/disable-thumbnails-and-thresold.php ) (20 diffs)
• tags/0.8.0/includes/admin.css (copied) (copied from disable-thumbnails-and-threshold/trunk/includes/admin.css ) (1 diff)
• tags/0.8.0/includes/index.php (copied) (copied from disable-thumbnails-and-threshold/trunk/includes/index.php )
• tags/0.8.0/includes/option-quality.php (copied) (copied from disable-thumbnails-and-threshold/trunk/includes/option-quality.php ) (11 diffs)
• tags/0.8.0/includes/option-threshold-exif.php (copied) (copied from disable-thumbnails-and-threshold/trunk/includes/option-threshold-exif.php ) (15 diffs)
• tags/0.8.0/includes/option-thumbnails.php (copied) (copied from disable-thumbnails-and-threshold/trunk/includes/option-thumbnails.php ) (14 diffs)
• tags/0.8.0/index.php (copied) (copied from disable-thumbnails-and-threshold/trunk/index.php )
• tags/0.8.0/readme.txt (copied) (copied from disable-thumbnails-and-threshold/trunk/readme.txt ) (3 diffs)
• trunk/disable-thumbnails-and-thresold.php (modified) (20 diffs)
• trunk/includes/admin.css (modified) (1 diff)
• trunk/includes/option-quality.php (modified) (11 diffs)
• trunk/includes/option-threshold-exif.php (modified) (15 diffs)
• trunk/includes/option-thumbnails.php (modified) (14 diffs)
• trunk/readme.txt (modified) (3 diffs)

disable-thumbnails-and-threshold/tags/0.8.0/disable-thumbnails-and-thresold.php

@@ -1 +1 @@
 <?php
-/* 
-Plugin Name: Disable Thumbnails, Threshold and Image Options
-Version: 0.7.0
-Description: Disable Thumbnails, Threshold and Image Options
-Author: KGM Servizi
-Author URI: https://kgmservizi.com
-License: GPLv2 or later
-License URI: https://www.gnu.org/licenses/gpl-2.0.html
-Text Domain: disable-thumbnails-and-threshold
-Requires at least: 5.4
-Requires PHP: 7.4
-*/
+/**
+ * Plugin Name: Disable Thumbnails, Threshold and Image Options
+ * Version: 0.8.0
+ * Description: Disable Thumbnails, Threshold and Image Options
+ * Author: KGM Servizi
+ * Author URI: https://kgmservizi.com
+ * License: GPLv2 or later
+ * License URI: https://www.gnu.org/licenses/gpl-2.0.html
+ * Text Domain: disable-thumbnails-and-threshold
+ * Requires at least: 5.6
+ * Requires PHP: 8.0
+ *
+ * @package Disable_Thumbnails_Threshold
+ */
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
-}
-
-// Define plugin constants for better maintainability
+        exit; // Exit if accessed directly.
+}
+
+// Define plugin constants for better maintainability.
 define( 'DTAT_QUALITY_OPTION', 'dtat_imgquality_option_name' );
 define( 'DTAT_THRESHOLD_OPTION', 'dtat_disablethreshold_option_name' );
 define( 'DTAT_THUMBNAILS_OPTION', 'dtat_disablethumbnails_option_name' );
 define( 'DTAT_MIGRATION_OPTION', 'dtat_migration_done' );
-define( 'DTAT_VERSION', '0.7.0' );
-
-/**
- * PHPCS Suppressions
- * 
- * This file contains phpcs:ignore comments for the following cases:
- * - Line 151, 131 (option-quality.php): WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
- *   Reason: Using WordPress core hook (jpeg_quality) which doesn't require plugin prefix
- * - Line 174, 172 (option-threshold-exif.php), 206 (option-threshold-exif.php): WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
- *   Reason: Using WordPress core hook (big_image_size_threshold) which doesn't require plugin prefix
- * - Line 241 (option-threshold-exif.php): WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
- *   Reason: Using WordPress core hook (wp_image_maybe_exif_rotate) which doesn't require plugin prefix
- */
-
-// Check WordPress version compatibility - requires WordPress 5.4+ for PHP 7.4+ support
-// Use admin_init hook to ensure WordPress is fully loaded
+define( 'DTAT_VERSION', '0.8.0' );
+define( 'DTAT_MIN_WP_VERSION', '5.6' );
+define( 'DTAT_MIN_PHP_VERSION', '8.0' );
+
+// Check WordPress version compatibility - WordPress 5.6 is the first release that supports PHP 8.0.
+// Use admin_init hook to ensure WordPress is fully loaded.
 add_action( 'admin_init', 'dtat_check_wordpress_version' );
 
@@ -50 +42 @@
 
 /**
- *  
+ *
  * Retrieve options for quality and threshold
  * Cache options globally to avoid multiple database calls
- * 
  */
 $GLOBALS['dtat_imgquality_options']        = get_option( DTAT_QUALITY_OPTION );
@@ -77 +68 @@
         $processed = true;
 
+        // admin_init also fires for logged-out admin-ajax.php/admin-post.php requests.
+        if ( ! current_user_can( 'manage_options' ) ) {
+                return;
+        }
+
         // Skip migration if already completed for this plugin version.
         if ( get_option( DTAT_MIGRATION_OPTION ) === DTAT_VERSION ) {
@@ -82 +78 @@
         }
 
-        $option_map = [
-                DTAT_QUALITY_OPTION     => 'kgmimgquality_option_name',
-                DTAT_THRESHOLD_OPTION   => 'kgmdisablethreshold_option_name',
-                DTAT_THUMBNAILS_OPTION  => 'kgmdisablethumbnails_option_name',
-        ];
+        $option_map = array(
+                DTAT_QUALITY_OPTION    => 'kgmimgquality_option_name',
+                DTAT_THRESHOLD_OPTION  => 'kgmdisablethreshold_option_name',
+                DTAT_THUMBNAILS_OPTION => 'kgmdisablethumbnails_option_name',
+        );
 
         foreach ( $option_map as $new_option => $legacy_option ) {
@@ -105 +101 @@
         }
 
+        /*
+         * The globals were cached at load time, before the migration. Without a refresh,
+         * dtat_initialize_options() (same hook, later) sees them empty and overwrites the
+         * migrated values with defaults, after the legacy rows are already deleted.
+         */
+        $GLOBALS['dtat_imgquality_options']        = get_option( DTAT_QUALITY_OPTION );
+        $GLOBALS['dtat_disablethreshold_options']  = get_option( DTAT_THRESHOLD_OPTION );
+        $GLOBALS['dtat_disablethumbnails_options'] = get_option( DTAT_THUMBNAILS_OPTION );
+
         update_option( DTAT_MIGRATION_OPTION, DTAT_VERSION );
 }
 
 
-// Initialize with current WordPress values if options don't exist
-// This will be handled in the admin_init hook to ensure WordPress is fully loaded
+// Initialize with current WordPress values if options don't exist.
+// This will be handled in the admin_init hook to ensure WordPress is fully loaded.
 add_action( 'admin_init', 'dtat_initialize_options' );
 
-// Hook to apply filters after themes are loaded to ensure priority
+// Hook to apply filters after themes are loaded to ensure priority.
 add_action( 'after_setup_theme', 'dtat_apply_filters', 20 );
 
@@ -126 +131 @@
  */
 function dtat_check_wordpress_version(): void {
-        // Only run in admin
+        // Only run in admin.
         if ( ! is_admin() ) {
                 return;
         }
-        
-        // Check if WordPress version is compatible
-        if ( version_compare( get_bloginfo( 'version' ), '5.4', '<' ) ) {
+
+        // Check if WordPress version is compatible.
+        if ( version_compare( get_bloginfo( 'version' ), DTAT_MIN_WP_VERSION, '<' ) ) {
                 add_action( 'admin_notices', 'dtat_wordpress_version_notice' );
         }
@@ -146 +151 @@
 function dtat_wordpress_version_notice(): void {
         printf(
-                '<div class="notice notice-error"><p><strong>%s</strong> %s</p></div>',
-                esc_html__( 'Disable Thumbnails, Threshold and Image Options', 'disable-thumbnails-and-threshold' ),
-                esc_html__( 'requires WordPress 5.4 or higher (PHP 7.4+). Please update WordPress.', 'disable-thumbnails-and-threshold' )
+                '<div class="notice notice-error"><p>%s</p></div>',
+                esc_html(
+                        sprintf(
+                                /* translators: 1: Plugin name, 2: Minimum WordPress version, 3: Minimum PHP version. */
+                                __( '%1$s requires WordPress %2$s or higher and PHP %3$s or higher. Please update.', 'disable-thumbnails-and-threshold' ),
+                                'Disable Thumbnails, Threshold and Image Options',
+                                DTAT_MIN_WP_VERSION,
+                                DTAT_MIN_PHP_VERSION
+                        )
+                )
         );
 }
@@ -162 +174 @@
  */
 function dtat_initialize_options(): void {
-        // Only run in admin and if user has proper capabilities
+        // Only run in admin and if user has proper capabilities.
         if ( ! is_admin() || ! current_user_can( 'manage_options' ) ) {
                 return;
         }
-        
-        // Initialize JPEG quality option if it doesn't exist or is invalid
-        if ( ! $GLOBALS['dtat_imgquality_options'] || 
-                 ! is_array( $GLOBALS['dtat_imgquality_options'] ) || 
-                 ! isset( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
-                 ! is_numeric( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
-                 intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) < 1 ||
-                 intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) > 100 ) {
-                
-                // Get current WordPress JPEG quality (respects existing filters/plugins)
-                // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
-                $current_quality = apply_filters( 'jpeg_quality', 82 );
-                
-                // Validate the quality value from filters
+
+        // Initialize JPEG quality option if it doesn't exist or is invalid.
+        if ( ! $GLOBALS['dtat_imgquality_options'] ||
+                ! is_array( $GLOBALS['dtat_imgquality_options'] ) ||
+                ! isset( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
+                ! is_numeric( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
+                intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) < 1 ||
+                intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) > 100 ) {
+                /*
+                 * Get current WordPress JPEG quality (respects existing filters/plugins).
+                 * Pass every argument core passes: on PHP 8 a third-party callback with a
+                 * required $context would otherwise throw ArgumentCountError here.
+                 */
+                try {
+                        // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
+                        $current_quality = apply_filters( 'jpeg_quality', 82, 'image_resize' );
+                } catch ( Throwable $e ) {
+                        $current_quality = 82;
+                }
+
+                // Validate the quality value from filters.
                 if ( ! is_numeric( $current_quality ) || $current_quality < 1 || $current_quality > 100 ) {
-                        $current_quality = 82; // Fallback to WordPress default
-                }
-                
-                // Preserve existing options and only update jpeg_quality
+                        $current_quality = 82; // Fallback to WordPress default.
+                }
+
+                // Preserve existing options and only update jpeg_quality.
                 if ( ! is_array( $GLOBALS['dtat_imgquality_options'] ) ) {
-                        $GLOBALS['dtat_imgquality_options'] = [];
+                        $GLOBALS['dtat_imgquality_options'] = array();
                 }
                 $GLOBALS['dtat_imgquality_options']['jpeg_quality'] = intval( $current_quality );
                 update_option( DTAT_QUALITY_OPTION, $GLOBALS['dtat_imgquality_options'] );
         }
-        
-        // Initialize threshold option if it doesn't exist or is invalid
-        if ( ! $GLOBALS['dtat_disablethreshold_options'] || 
-                 ! is_array( $GLOBALS['dtat_disablethreshold_options'] ) || 
-                 ! isset( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
-                 ! is_numeric( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
-                 intval( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) <= 0 ) {
-                
-                // Get current WordPress big image threshold (respects existing filters/plugins)
-                // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
-                $current_threshold = apply_filters( 'big_image_size_threshold', 2560 );
-                
-                // Validate the threshold value from filters
+
+        // Initialize threshold option if it doesn't exist or is invalid.
+        if ( ! $GLOBALS['dtat_disablethreshold_options'] ||
+                ! is_array( $GLOBALS['dtat_disablethreshold_options'] ) ||
+                ! isset( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
+                ! is_numeric( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
+                intval( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) <= 0 ) {
+                /*
+                 * Get current WordPress big image threshold (respects existing filters/plugins).
+                 * Core passes $imagesize, $file and $attachment_id; there is no real image here,
+                 * so neutral values are passed and any callback failure falls back to the default.
+                 */
+                try {
+                        // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
+                        $current_threshold = apply_filters( 'big_image_size_threshold', 2560, array( 0, 0 ), '', 0 );
+                } catch ( Throwable $e ) {
+                        $current_threshold = 2560;
+                }
+
+                // Validate the threshold value from filters.
                 if ( ! is_numeric( $current_threshold ) || $current_threshold <= 0 ) {
-                        $current_threshold = 2560; // Fallback to WordPress default
-                }
-                
-                // Preserve existing options and only update new_threshold
+                        $current_threshold = 2560; // Fallback to WordPress default.
+                }
+
+                // Preserve existing options and only update new_threshold.
                 if ( ! is_array( $GLOBALS['dtat_disablethreshold_options'] ) ) {
-                        $GLOBALS['dtat_disablethreshold_options'] = [];
+                        $GLOBALS['dtat_disablethreshold_options'] = array();
                 }
                 $GLOBALS['dtat_disablethreshold_options']['new_threshold'] = intval( $current_threshold );
@@ -225 +251 @@
  */
 function dtat_jpeg_quality_filter(): int {
-        $dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
-        
+        $dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, array() );
+
         if ( ! is_array( $dtat_imgquality_options ) || ! isset( $dtat_imgquality_options['jpeg_quality'] ) ) {
-                return 82; // WordPress default
-        }
-        
+                return 82; // WordPress default.
+        }
+
         $quality = intval( $dtat_imgquality_options['jpeg_quality'] );
-        
-        // Validate quality range (0-100)
-        if ( $quality < 0 || $quality > 100 ) {
-                return 82; // WordPress default
-        }
-        
+
+        // Same 1-100 range accepted by the settings page.
+        if ( $quality < 1 || $quality > 100 ) {
+                return 82; // WordPress default.
+        }
+
         return $quality;
 }
@@ -249 +275 @@
  */
 function dtat_big_image_threshold_filter(): int {
-        $dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, [] );
-        
+        $dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, array() );
+
         if ( ! is_array( $dtat_disablethreshold_options ) || ! isset( $dtat_disablethreshold_options['new_threshold'] ) ) {
-                return 2560; // WordPress default
-        }
-        
+                return 2560; // WordPress default.
+        }
+
         $threshold = intval( $dtat_disablethreshold_options['new_threshold'] );
-        
-        // Validate threshold is positive
+
+        // Validate threshold is positive.
         if ( $threshold <= 0 ) {
-                return 2560; // WordPress default
-        }
-        
+                return 2560; // WordPress default.
+        }
+
         return $threshold;
 }
@@ -270 +296 @@
  * @since   0.1
  * @package Disable_Thumbnails_Threshold
- * @param   array $sizes Registered intermediate image sizes.
- * @return  array Filtered image sizes with disabled ones removed.
- */
-function dtat_thumbnail_sizes_filter( array $sizes ): array {
-        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, [] );
-        
+ * @param   mixed $sizes Registered intermediate image sizes (an array, unless another filter broke it).
+ * @return  mixed Filtered image sizes with disabled ones removed.
+ */
+function dtat_thumbnail_sizes_filter( $sizes ) {
+        // Untyped on purpose: a TypeError here would break every media upload.
+        if ( ! is_array( $sizes ) ) {
+                return $sizes;
+        }
+
+        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, array() );
+
         if ( ! is_array( $dtat_disablethumbnails_options ) || empty( $dtat_disablethumbnails_options ) ) {
                 return $sizes;
         }
-        
-        // Validate that all values in the array are strings (security check)
+
+        // Validate that all values in the array are strings (security check).
         $valid_options = array_filter( $dtat_disablethumbnails_options, 'is_string' );
-        
+
         return array_diff( $sizes, $valid_options );
 }
@@ -294 +325 @@
  */
 function dtat_apply_filters(): void {
-        // Prevent multiple applications
+        // Prevent multiple applications.
         static $applied = false;
         if ( $applied ) {
@@ -300 +331 @@
         }
         $applied = true;
-        
-        // Remove any existing filters to prevent accumulation
+
+        // Remove any existing filters to prevent accumulation.
         remove_filter( 'jpeg_quality', 'dtat_jpeg_quality_filter' );
         remove_filter( 'big_image_size_threshold', 'dtat_big_image_threshold_filter' );
         remove_filter( 'intermediate_image_sizes', 'dtat_thumbnail_sizes_filter' );
-        
-        // Safely get options with fallback
-        $dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
-        $dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, [] );
-        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, [] );
-        
-        // Apply JPEG quality filter
+
+        // Safely get options with fallback.
+        $dtat_imgquality_options        = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, array() );
+        $dtat_disablethreshold_options  = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, array() );
+        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, array() );
+
+        // Apply JPEG quality filter.
         $jpeg_quality = null;
         if ( is_array( $dtat_imgquality_options ) ) {
                 $jpeg_quality = $dtat_imgquality_options['jpeg_quality'] ?? null;
         }
-        
+
         $quality = $jpeg_quality ? intval( $jpeg_quality ) : 0;
         if ( $jpeg_quality && is_numeric( $jpeg_quality ) && $quality > 0 && $quality <= 100 ) {
@@ -322 +353 @@
         }
 
-        // Apply threshold filters
+        // Apply threshold filters.
         if ( is_array( $dtat_disablethreshold_options ) ) {
-                // Set new threshold
+                // Set new threshold.
                 if ( ! empty( $dtat_disablethreshold_options['new_threshold'] )
                         && is_numeric( $dtat_disablethreshold_options['new_threshold'] ) ) {
@@ -333 +364 @@
                 }
 
-                // Disable threshold
+                // Disable threshold.
                 if ( 'disable_threshold' === ( $dtat_disablethreshold_options['disable_threshold'] ?? null ) ) {
                         add_filter( 'big_image_size_threshold', '__return_false', 100 );
                 }
 
-                // Disable EXIF rotation
+                // Disable EXIF rotation.
                 if ( 'disable_image_rotation_exif' === ( $dtat_disablethreshold_options['disable_image_rotation_exif'] ?? null ) ) {
                         add_filter( 'wp_image_maybe_exif_rotate', '__return_zero', 100, 2 );
@@ -344 +375 @@
         }
 
-        // Apply thumbnail size filters
+        // Apply thumbnail size filters.
         if ( ! empty( $dtat_disablethumbnails_options ) ) {
                 add_filter( 'intermediate_image_sizes', 'dtat_thumbnail_sizes_filter', 100 );
@@ -350 +381 @@
 }
 
-// All filters are now applied in dtat_apply_filters() function after themes are loaded
+// All filters are now applied in dtat_apply_filters() function after themes are loaded.
 
 /**
@@ -361 +392 @@
  */
 function dtat_action_links( array $actions ): array {
-        // Check if user has proper capabilities before showing action links
+        // Check if user has proper capabilities before showing action links.
         if ( ! current_user_can( 'manage_options' ) ) {
                 return $actions;
         }
-        
-        $mylinks = [
+
+        $mylinks = array(
                 '<a href="' . esc_url( get_admin_url( null, 'tools.php?page=kgmdisablethumbnails' ) ) . '">' . esc_html__( 'Image sizes', 'disable-thumbnails-and-threshold' ) . '</a>',
                 '<a href="' . esc_url( get_admin_url( null, 'tools.php?page=kgmimgquality' ) ) . '">' . esc_html__( 'Image Quality', 'disable-thumbnails-and-threshold' ) . '</a>',
                 '<a href="' . esc_url( get_admin_url( null, 'tools.php?page=kgmdisablethreshold' ) ) . '">' . esc_html__( 'Threshold & EXIF', 'disable-thumbnails-and-threshold' ) . '</a>',
-        ];
+        );
         return array_merge( $mylinks, $actions );
 }
@@ -383 +414 @@
  */
 function dtat_admin_styles( string $hook ): void {
-        /**
-         * Check if in plugin options page and user has proper capabilities
-         */
         if ( ! current_user_can( 'manage_options' ) ) {
                 return;
         }
-        
-        $screen = get_current_screen();
-        if ( ! $screen ) {
-                return;
-        }
-        
-        if ( 'tools_page_kgmdisablethumbnails' === $screen->base || 'tools_page_kgmdisablethreshold' === $screen->base ) {
-                wp_enqueue_style( 'dtat-admin-css', plugins_url( 'includes/admin.css', __FILE__ ), [], DTAT_VERSION );
-        }
-}
+
+        $plugin_pages = array( 'tools_page_kgmdisablethumbnails', 'tools_page_kgmdisablethreshold', 'tools_page_kgmimgquality' );
+        if ( in_array( $hook, $plugin_pages, true ) ) {
+                wp_enqueue_style( 'dtat-admin-css', plugins_url( 'includes/admin.css', __FILE__ ), array(), DTAT_VERSION );
+        }
+}
+
+register_uninstall_hook( __FILE__, 'dtat_plugin_uninstall' );
 
 /**
  * Clean up plugin options on uninstall.
  *
- * @since   0.1
- * @package Disable_Thumbnails_Threshold
- * @return  void
- */
-register_uninstall_hook( __FILE__, 'dtat_plugin_uninstall' );
+ * Also removes the pre-0.6.5 `kgm*` options, which survive when the migration never ran.
+ *
+ * @since   0.1
+ * @package Disable_Thumbnails_Threshold
+ * @return  void
+ */
 function dtat_plugin_uninstall(): void {
         delete_option( DTAT_THUMBNAILS_OPTION );
@@ -413 +440 @@
         delete_option( DTAT_QUALITY_OPTION );
         delete_option( DTAT_MIGRATION_OPTION );
-}
+        delete_option( 'kgmimgquality_option_name' );
+        delete_option( 'kgmdisablethreshold_option_name' );
+        delete_option( 'kgmdisablethumbnails_option_name' );
+}

disable-thumbnails-and-threshold/tags/0.8.0/includes/admin.css

@@ -1 +1 @@
 .switch { position: relative; display: inline-block; width: 33px; height: 17px; margin-right: 0.4em; }
 .switch input { position: absolute; opacity: 0; width: 1px; height: 1px; clip: rect(0 0 0 0); overflow: hidden; }
-.slider { position: absolute; cursor: pointer; top: 0; left: 0; right: 0; bottom: 0; background-color: #ccc; -webkit-transition: 0.5s; transition: 0.5s; border-radius: 18px; display:inline; }
+/* Inset border #757575: 4.05:1 on the form-table background #f0f0f1 (SC 1.4.11 needs 3:1). */
+.slider { position: absolute; cursor: pointer; top: 0; left: 0; right: 0; bottom: 0; background-color: #ccc; box-shadow: inset 0 0 0 1px #757575; -webkit-transition: 0.5s; transition: 0.5s; border-radius: 18px; display:inline; }
 .slider::before { position: absolute; content: ""; height: 10px; width: 10px; left: 4px; bottom: 4px; background-color: #fff; -webkit-transition: 0.5s; transition: 0.5s; border-radius: 50%; }
 input:checked + .screen-reader-text + .slider,
 input:checked + .slider { background-color: #b12222; }
+/* Transparent outline: box-shadow is dropped in forced-colors mode, the outline is not. */
 input:focus + .screen-reader-text + .slider,
-input:focus + .slider { box-shadow: 0 0 0 3px #005fcc; }
+input:focus + .slider { outline: 2px solid transparent; outline-offset: 2px; box-shadow: inset 0 0 0 1px #757575, 0 0 0 3px #005fcc; }
 input:checked + .screen-reader-text + .slider::before,
 input:checked + .slider::before { -webkit-transform: translateX(16px); -ms-transform: translateX(16px); transform: translateX(16px); }
-.dtat-notice-warning { color: #d63638; }
-.dtat-notice-caution { color: #dba617; }
+@media (forced-colors: active) {
+        .slider { border: 1px solid ButtonText; }
+        .slider::before { background-color: ButtonText; }
+        input:checked + .screen-reader-text + .slider,
+        input:checked + .slider { background-color: Highlight; }
+}
+/* Ratios on #f0f0f1: warning 5.53:1, caution 4.86:1, info 5.04:1 (SC 1.4.3 needs 4.5:1). */
+.dtat-notice-warning { color: #b32d2e; }
+.dtat-notice-caution { color: #8a6100; }
 .dtat-notice-info { color: #666; }

disable-thumbnails-and-threshold/tags/0.8.0/includes/option-quality.php

@@ -12 +12 @@
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
+        exit; // Exit if accessed directly.
 }
 
+/**
+ * Image Quality settings page.
+ *
+ * @since 0.2
+ */
 class DTAT_Img_Quality {
-        private array|false $dtat_imgquality_options;
+        /**
+         * Stored option value. Untyped on purpose: whatever the database holds must not raise a TypeError.
+         *
+         * @var array|false
+         */
+        private $dtat_imgquality_options = false;
 
         /**
@@ -24 +34 @@
          */
         public function __construct() {
-                add_action( 'admin_menu', [ $this, 'add_plugin_page' ] );
-                add_action( 'admin_init', [ $this, 'page_init' ] );
+                add_action( 'admin_menu', array( $this, 'add_plugin_page' ) );
+                add_action( 'admin_init', array( $this, 'page_init' ) );
         }
 
@@ -40 +50 @@
                         'manage_options',
                         'kgmimgquality',
-                        [ $this, 'create_admin_page' ]
+                        array( $this, 'create_admin_page' )
                 );
         }
@@ -51 +61 @@
          */
         public function create_admin_page() {
-                // Check user capabilities for security
+                // Check user capabilities for security.
                 if ( ! current_user_can( 'manage_options' ) ) {
                         wp_die( esc_html__( 'You do not have sufficient permissions to access this page.', 'disable-thumbnails-and-threshold' ) );
                 }
-                
-                // Use cached options to avoid database calls
+
+                // Use cached options to avoid database calls.
                 $this->dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION ); ?>
 
                 <div class="wrap">
-                        <h2><?php echo esc_html__( 'Image Quality', 'disable-thumbnails-and-threshold' ); ?></h2>
+                        <h1><?php echo esc_html__( 'Image Quality', 'disable-thumbnails-and-threshold' ); ?></h1>
                         <p><strong><?php echo esc_html__( 'Remember you need to regenerate thumbnails for delete old thumbnails image already generated.', 'disable-thumbnails-and-threshold' ); ?></strong></p>
-                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/reg-thumb' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
-                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/WP-CLI-thumb-rgnrt' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://wordpress.org/plugins/regenerate-thumbnails/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://developer.wordpress.org/cli/commands/media/regenerate/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
                         <?php settings_errors(); ?>
 
@@ -74 +84 @@
                         </form>
                 </div>
-        <?php }
+                <?php
+        }
 
         /**
@@ -86 +97 @@
                         'kgmimgquality_option_group',
                         DTAT_QUALITY_OPTION,
-                        [ $this, 'sanitize' ]
+                        array( $this, 'sanitize' )
                 );
 
                 add_settings_section(
                         'kgmimgquality_setting_section',
-                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'section_info' ],
-                        'kgmimgquality-admin' 
+                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'section_info' ),
+                        'kgmimgquality-admin'
                 );
 
@@ -99 +110 @@
                         'jpeg_quality',
                         esc_html__( 'JPEG Quality', 'disable-thumbnails-and-threshold' ) . ' <br> <small>' . esc_html__( 'Default WordPress: 82%', 'disable-thumbnails-and-threshold' ) . '</small>',
-                        [ $this, 'jpeg_quality_callback' ],
+                        array( $this, 'jpeg_quality_callback' ),
                         'kgmimgquality-admin',
-                        'kgmimgquality_setting_section'
+                        'kgmimgquality_setting_section',
+                        array( 'label_for' => 'jpeg_quality' )
                 );
         }
@@ -108 +120 @@
          * Sanitize and validate form input before saving.
          *
-         * @since  0.2
-         * @param  array $input Raw form input values.
+         * Runs on every update_option() of this option, not only on form submit, so it
+         * must not depend on the current user: options.php already enforces the nonce
+         * and the manage_options capability before saving.
+         *
+         * @since  0.2
+         * @param  mixed $input Raw value; null when the field is missing from the request.
          * @return array Sanitized values.
          */
-        public function sanitize( array $input ): array {
-                // Check user capabilities for security
-                if ( ! current_user_can( 'manage_options' ) ) {
-                        return $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
-                }
-                
-                // Nonce is already verified by WordPress options.php handler via settings_fields().
-                $sanitary_values = [];
+        public function sanitize( $input ): array {
+                if ( ! is_array( $input ) ) {
+                        $input = array();
+                }
+
+                $sanitary_values = array();
 
                 if ( isset( $input['jpeg_quality'] ) ) {
-                        $quality = sanitize_text_field( $input['jpeg_quality'] );
+                        $quality     = sanitize_text_field( $input['jpeg_quality'] );
                         $quality_int = intval( $quality );
                         if ( is_numeric( $quality ) && $quality_int >= 1 && $quality_int <= 100 ) {
@@ -128 +142 @@
                         } else {
                                 add_settings_error( 'kgmimgquality_option_notice', 'invalid_quality', esc_html__( 'JPEG quality must be a number between 1 and 100.', 'disable-thumbnails-and-threshold' ) );
-                                $existing = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
+                                $existing = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, array() );
                                 if ( is_array( $existing ) && isset( $existing['jpeg_quality'] ) ) {
-                                        return [ 'jpeg_quality' => absint( $existing['jpeg_quality'] ) ];
+                                        return array( 'jpeg_quality' => absint( $existing['jpeg_quality'] ) );
                                 }
-                                return [];
+                                return array();
                         }
                 }
@@ -162 +176 @@
                         esc_html__( '%', 'disable-thumbnails-and-threshold' )
                 );
-                
+
                 // Compare plugin value against WordPress default.
                 // We avoid calling apply_filters() here because the jpeg_quality filter expects
@@ -173 +187 @@
 
                 if ( $plugin_quality && $plugin_quality !== $wp_default_quality ) {
-                        printf( '<br><small class="description dtat-notice-warning">%s %s</small>',
+                        printf(
+                                '<br><small class="description dtat-notice-warning">%s %s</small>',
                                 esc_html( '⚠️' ),
-                                // translators: %1$d: Plugin quality percentage, %2$d: WordPress default quality percentage
+                                /* translators: %1$d: Plugin quality percentage, %2$d: WordPress default quality percentage */
                                 esc_html( sprintf( __( 'Plugin quality (%1$d%%) differs from WordPress default (%2$d%%)', 'disable-thumbnails-and-threshold' ), $plugin_quality, $wp_default_quality ) )
                         );
                 } else {
-                        printf( '<br><small class="description dtat-notice-info">%s</small>',
-                                // translators: %d: WordPress default JPEG quality percentage
+                        printf(
+                                '<br><small class="description dtat-notice-info">%s</small>',
+                                /* translators: %d: WordPress default JPEG quality percentage */
                                 esc_html( sprintf( __( 'WordPress default JPEG quality: %d%%', 'disable-thumbnails-and-threshold' ), $wp_default_quality ) )
                         );
                 }
         }
-
 }
 if ( is_admin() ) {
-        $DTAT_Img_Quality = new DTAT_Img_Quality();
+        $dtat_img_quality = new DTAT_Img_Quality();
 }

disable-thumbnails-and-threshold/tags/0.8.0/includes/option-threshold-exif.php

@@ -12 +12 @@
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
+        exit; // Exit if accessed directly.
 }
 
+/**
+ * Threshold & EXIF settings page.
+ *
+ * @since 0.1
+ */
 class DTAT_Disable_Threshold {
-        private array|false $dtat_disablethreshold_options;
+        /**
+         * Stored option value. Untyped on purpose: whatever the database holds must not raise a TypeError.
+         *
+         * @var array|false
+         */
+        private $dtat_disablethreshold_options = false;
 
         /**
@@ -24 +34 @@
          */
         public function __construct() {
-                add_action( 'admin_menu', [ $this, 'add_plugin_page' ] );
-                add_action( 'admin_init', [ $this, 'page_init' ] );
+                add_action( 'admin_menu', array( $this, 'add_plugin_page' ) );
+                add_action( 'admin_init', array( $this, 'page_init' ) );
         }
 
@@ -40 +50 @@
                         'manage_options',
                         'kgmdisablethreshold',
-                        [ $this, 'create_admin_page' ]
+                        array( $this, 'create_admin_page' )
                 );
         }
@@ -51 +61 @@
          */
         public function create_admin_page() {
-                // Check user capabilities for security
+                // Check user capabilities for security.
                 if ( ! current_user_can( 'manage_options' ) ) {
                         wp_die( esc_html__( 'You do not have sufficient permissions to access this page.', 'disable-thumbnails-and-threshold' ) );
                 }
-                
-                // Use cached options to avoid database calls
+
+                // Use cached options to avoid database calls.
                 $this->dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION ); ?>
 
                 <div class="wrap">
-                        <h2><?php echo esc_html__( 'Disable Threshold&EXIF', 'disable-thumbnails-and-threshold' ); ?></h2>
+                        <h1><?php echo esc_html__( 'Disable Threshold&EXIF', 'disable-thumbnails-and-threshold' ); ?></h1>
                         <p><strong><?php echo esc_html__( 'Remember you need to regenerate thumbnails for delete old thumbnails image already generated.', 'disable-thumbnails-and-threshold' ); ?></strong></p>
-                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/reg-thumb' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
-                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/WP-CLI-thumb-rgnrt' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://wordpress.org/plugins/regenerate-thumbnails/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://developer.wordpress.org/cli/commands/media/regenerate/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
                         <?php settings_errors(); ?>
 
@@ -74 +84 @@
                         </form>
                 </div>
-        <?php }
+                <?php
+        }
 
         /**
@@ -86 +97 @@
                         'kgmdisablethreshold_option_group',
                         DTAT_THRESHOLD_OPTION,
-                        [ $this, 'sanitize' ]
+                        array( $this, 'sanitize' )
                 );
 
                 add_settings_section(
                         'kgmdisablethreshold_setting_section',
-                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'section_info' ],
-                        'kgmdisablethreshold-admin' 
+                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'section_info' ),
+                        'kgmdisablethreshold-admin'
                 );
 
@@ -99 +110 @@
                         'new_threshold',
                         esc_html__( 'New Size Threshold', 'disable-thumbnails-and-threshold' ) . ' <br> <small>' . esc_html__( 'Default WordPress: 2560px', 'disable-thumbnails-and-threshold' ) . '</small>',
-                        [ $this, 'new_threshold_callback' ],
+                        array( $this, 'new_threshold_callback' ),
                         'kgmdisablethreshold-admin',
-                        'kgmdisablethreshold_setting_section'
+                        'kgmdisablethreshold_setting_section',
+                        array( 'label_for' => 'new_threshold' )
                 );
                 add_settings_field(
                         'disable_threshold',
                         esc_html__( 'Disable Threshold', 'disable-thumbnails-and-threshold' ),
-                        [ $this, 'disable_threshold_callback' ],
+                        array( $this, 'disable_threshold_callback' ),
                         'kgmdisablethreshold-admin',
                         'kgmdisablethreshold_setting_section'
@@ -113 +125 @@
                         'disable_image_rotation_exif',
                         esc_html__( 'Disable Image Rotation by EXIF', 'disable-thumbnails-and-threshold' ),
-                        [ $this, 'disable_image_rotation_exif_callback' ],
+                        array( $this, 'disable_image_rotation_exif_callback' ),
                         'kgmdisablethreshold-admin',
                         'kgmdisablethreshold_setting_section'
@@ -122 +134 @@
          * Sanitize and validate form input before saving.
          *
-         * @since  0.1
-         * @param  array $input Raw form input values.
+         * Runs on every update_option() of this option, not only on form submit, so it
+         * must not depend on the current user: options.php already enforces the nonce
+         * and the manage_options capability before saving.
+         *
+         * @since  0.1
+         * @param  mixed $input Raw value; null when no field is present in the request.
          * @return array Sanitized values.
          */
-        public function sanitize( array $input ): array {
-                // Check user capabilities for security
-                if ( ! current_user_can( 'manage_options' ) ) {
-                        return $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, [] );
-                }
-                
-                // Nonce is already verified by WordPress options.php handler via settings_fields().
-                $sanitary_values = [];
+        public function sanitize( $input ): array {
+                if ( ! is_array( $input ) ) {
+                        $input = array();
+                }
+
+                $sanitary_values = array();
 
                 if ( isset( $input['new_threshold'] ) ) {
@@ -183 +197 @@
                         esc_html__( 'px', 'disable-thumbnails-and-threshold' )
                 );
-                
-                // Check if plugin disables threshold
+
+                // Check if plugin disables threshold.
                 $plugin_disables_threshold = false;
                 if ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) ) {
-                        $plugin_disables_threshold = ( $this->dtat_disablethreshold_options['disable_threshold'] === 'disable_threshold' );
-                }
-                
-                // Show yellow warning message if plugin disables threshold
+                        $plugin_disables_threshold = ( 'disable_threshold' === $this->dtat_disablethreshold_options['disable_threshold'] );
+                }
+
+                // Show yellow warning message if plugin disables threshold.
                 if ( $plugin_disables_threshold ) {
-                        printf( '<br><small class="description dtat-notice-caution">%s %s</small>', 
+                        printf(
+                                '<br><small class="description dtat-notice-caution">%s %s</small>',
                                 esc_html( '⚠️' ),
                                 esc_html__( 'Disabled by plugin', 'disable-thumbnails-and-threshold' )
@@ -207 +222 @@
 
                         if ( $plugin_threshold && $plugin_threshold !== $wp_default_threshold ) {
-                                printf( '<br><small class="description dtat-notice-warning">%s %s</small>',
+                                printf(
+                                        '<br><small class="description dtat-notice-warning">%s %s</small>',
                                         esc_html( '⚠️' ),
-                                        // translators: %1$d: Plugin threshold value in pixels, %2$d: WordPress default threshold value in pixels
+                                        /* translators: %1$d: Plugin threshold value in pixels, %2$d: WordPress default threshold value in pixels */
                                         esc_html( sprintf( __( 'Plugin threshold (%1$dpx) differs from WordPress default (%2$dpx)', 'disable-thumbnails-and-threshold' ), $plugin_threshold, $wp_default_threshold ) )
                                 );
                         } else {
-                                // translators: %d: WordPress default big image threshold value in pixels
+                                /* translators: %d: WordPress default big image threshold value in pixels */
                                 printf( '<br><small class="description dtat-notice-info">%s</small>', esc_html( sprintf( __( 'WordPress default big image threshold: %dpx', 'disable-thumbnails-and-threshold' ), $wp_default_threshold ) ) );
                         }
@@ -229 +245 @@
                         '<label class="switch"><input type="checkbox" name="%s[disable_threshold]" id="disable_threshold" value="disable_threshold" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THRESHOLD_OPTION ),
-                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) && $this->dtat_disablethreshold_options['disable_threshold'] === 'disable_threshold' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) && 'disable_threshold' === $this->dtat_disablethreshold_options['disable_threshold'] ) ? 'checked' : '',
                         esc_html__( 'Disable Threshold', 'disable-thumbnails-and-threshold' )
                 );
-                
+
                 // Show informational status based on plugin's stored setting.
                 // We avoid calling apply_filters('big_image_size_threshold') here because it expects
@@ -238 +254 @@
                 $plugin_intends_to_disable = false;
                 if ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) ) {
-                        $plugin_intends_to_disable = ( $this->dtat_disablethreshold_options['disable_threshold'] === 'disable_threshold' );
+                        $plugin_intends_to_disable = ( 'disable_threshold' === $this->dtat_disablethreshold_options['disable_threshold'] );
                 }
 
                 if ( $plugin_intends_to_disable ) {
-                        printf( '<br><small class="description dtat-notice-info">%s</small>',
+                        printf(
+                                '<br><small class="description dtat-notice-info">%s</small>',
                                 esc_html__( 'Threshold is disabled by this plugin.', 'disable-thumbnails-and-threshold' )
                         );
@@ -258 +275 @@
                         '<label class="switch"><input type="checkbox" name="%s[disable_image_rotation_exif]" id="disable_image_rotation_exif" value="disable_image_rotation_exif" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THRESHOLD_OPTION ),
-                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) && $this->dtat_disablethreshold_options['disable_image_rotation_exif'] === 'disable_image_rotation_exif' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) && 'disable_image_rotation_exif' === $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) ? 'checked' : '',
                         esc_html__( 'Disable Image Rotation by EXIF', 'disable-thumbnails-and-threshold' )
                 );
-                
+
                 // Show informational status based on plugin's stored setting.
                 // We avoid calling apply_filters('wp_image_maybe_exif_rotate') here because it expects
@@ -267 +284 @@
                 $plugin_exif_disabled = false;
                 if ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) ) {
-                        $plugin_exif_disabled = ( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] === 'disable_image_rotation_exif' );
+                        $plugin_exif_disabled = ( 'disable_image_rotation_exif' === $this->dtat_disablethreshold_options['disable_image_rotation_exif'] );
                 }
 
                 if ( $plugin_exif_disabled ) {
-                        printf( '<br><small class="description dtat-notice-info">%s</small>',
+                        printf(
+                                '<br><small class="description dtat-notice-info">%s</small>',
                                 esc_html__( 'EXIF rotation is disabled by this plugin.', 'disable-thumbnails-and-threshold' )
                         );
                 }
         }
-
 }
 if ( is_admin() ) {
-        $DTAT_Disable_Threshold = new DTAT_Disable_Threshold();
+        $dtat_disable_threshold = new DTAT_Disable_Threshold();
 }

disable-thumbnails-and-threshold/tags/0.8.0/includes/option-thumbnails.php

@@ -12 +12 @@
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
+        exit; // Exit if accessed directly.
 }
 
+/**
+ * Image Sizes settings page.
+ *
+ * @since 0.1
+ */
 class DTAT_Disable_Thumbnails {
-        private array|false $dtat_disablethumbnails_options;
+        /**
+         * Stored option value. Untyped on purpose: whatever the database holds must not raise a TypeError.
+         *
+         * @var array|false
+         */
+        private $dtat_disablethumbnails_options = false;
 
         /**
@@ -24 +34 @@
          */
         public function __construct() {
-                add_action( 'admin_menu', [ $this, 'add_plugin_page' ] );
-                add_action( 'admin_init', [ $this, 'page_init' ] );
+                add_action( 'admin_menu', array( $this, 'add_plugin_page' ) );
+                add_action( 'admin_init', array( $this, 'page_init' ) );
         }
 
@@ -36 +46 @@
         public function add_plugin_page() {
                 add_management_page(
-                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ), 
-                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ), 
-                        'manage_options', 
-                        'kgmdisablethumbnails', 
-                        [ $this, 'create_admin_page' ]
+                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ),
+                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ),
+                        'manage_options',
+                        'kgmdisablethumbnails',
+                        array( $this, 'create_admin_page' )
                 );
         }
@@ -51 +61 @@
          */
         public function create_admin_page() {
-                // Check user capabilities for security
+                // Check user capabilities for security.
                 if ( ! current_user_can( 'manage_options' ) ) {
                         wp_die( esc_html__( 'You do not have sufficient permissions to access this page.', 'disable-thumbnails-and-threshold' ) );
                 }
-                
-                // Use cached options to avoid database calls
+
+                // Use cached options to avoid database calls.
                 $this->dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION ); ?>
 
                 <div class="wrap">
-                        <h2><?php echo esc_html__( 'Image Thumbnails', 'disable-thumbnails-and-threshold' ); ?></h2>
+                        <h1><?php echo esc_html__( 'Image Thumbnails', 'disable-thumbnails-and-threshold' ); ?></h1>
                         <p><strong><?php echo esc_html__( 'Remember you need to regenerate thumbnails for delete old thumbnails image already generated.', 'disable-thumbnails-and-threshold' ); ?></strong></p>
-                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/reg-thumb' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
-                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/WP-CLI-thumb-rgnrt' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://wordpress.org/plugins/regenerate-thumbnails/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://developer.wordpress.org/cli/commands/media/regenerate/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
                         <p><?php echo esc_html__( 'Flagged image sizes will be disabled.', 'disable-thumbnails-and-threshold' ); ?></p>
                         <?php settings_errors(); ?>
@@ -75 +85 @@
                         </form>
                 </div>
-        <?php }
+                <?php
+        }
 
         /**
@@ -86 +97 @@
                 register_setting(
                         'kgmdisablethumbnails_option_group',
-                        DTAT_THUMBNAILS_OPTION, 
-                        [ $this, 'sanitize' ] 
+                        DTAT_THUMBNAILS_OPTION,
+                        array( $this, 'sanitize' )
                 );
 
                 add_settings_section(
-                        'kgmdisablethumbnails_setting_section', 
-                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'section_info' ],
-                        'kgmdisablethumbnails-admin' 
+                        'kgmdisablethumbnails_setting_section',
+                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'section_info' ),
+                        'kgmdisablethumbnails-admin'
                 );
 
                 add_settings_field(
                         'thumbnail',
-                        esc_html__( 'Thumbnail', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'thumbnail_callback' ],
-                        'kgmdisablethumbnails-admin', 
-                        'kgmdisablethumbnails_setting_section' 
+                        esc_html__( 'Thumbnail', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'thumbnail_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
                 );
                 add_settings_field(
                         'medium',
-                        esc_html__( 'Medium', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'medium_callback' ],
-                        'kgmdisablethumbnails-admin', 
-                        'kgmdisablethumbnails_setting_section' 
+                        esc_html__( 'Medium', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'medium_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
                 );
                 add_settings_field(
                         'medium_large',
                         esc_html__( 'Medium Large', 'disable-thumbnails-and-threshold' ),
-                        [ $this, 'medium_large_callback' ],
-                        'kgmdisablethumbnails-admin',
-                        'kgmdisablethumbnails_setting_section' 
-                );
-                add_settings_field(
-                        'large', 
-                        esc_html__( 'Large', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'large_callback' ],
-                        'kgmdisablethumbnails-admin', 
-                        'kgmdisablethumbnails_setting_section' 
+                        array( $this, 'medium_large_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
+                );
+                add_settings_field(
+                        'large',
+                        esc_html__( 'Large', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'large_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
                 );
 
                 $image_sizes = wp_get_additional_image_sizes();
                 foreach ( $image_sizes as $key => $image_size ) {
-                        if ( 1 === $image_size['crop'] ) {
+                        if ( ! empty( $image_size['crop'] ) ) {
                                 $crop = esc_html__( 'cropped', 'disable-thumbnails-and-threshold' );
                         } else {
@@ -135 +146 @@
                         add_settings_field(
                                 $key,
-                                esc_html( $key ) . '<br><small>(' . esc_attr( $image_size['width'] ) . 'x' . esc_attr( $image_size['height'] ) . ')</small><br><small>' . esc_html( $crop ) . '</small>',
-                                [ $this, 'ext_callback' ],
+                                esc_html( $key ) . '<br><small>(' . absint( $image_size['width'] ) . 'x' . absint( $image_size['height'] ) . ')</small><br><small>' . esc_html( $crop ) . '</small>',
+                                array( $this, 'ext_callback' ),
                                 'kgmdisablethumbnails-admin',
                                 'kgmdisablethumbnails_setting_section',
-                                [ 'name' => $key ]
+                                array( 'name' => $key )
                         );
                 }
@@ -147 +158 @@
          * Sanitize and validate form input before saving.
          *
-         * @since  0.1
-         * @param  array $input Raw form input values.
+         * Runs on every update_option() of this option, not only on form submit, so it
+         * must not depend on the current user: options.php already enforces the nonce
+         * and the manage_options capability before saving.
+         *
+         * Each checkbox posts its own size name as value, so only "size => size" pairs
+         * for sizes registered on this site are kept.
+         *
+         * @since  0.1
+         * @param  mixed $input Raw value; null when every checkbox is unchecked.
          * @return array Sanitized values.
          */
-        public function sanitize( array $input ): array {
-                // Check user capabilities for security
-                if ( ! current_user_can( 'manage_options' ) ) {
-                        return $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, [] );
-                }
-                
-                // Nonce is already verified by WordPress options.php handler via settings_fields().
-                $sanitary_values = [];
-
-                if ( isset( $input['thumbnail'] ) ) {
-                        $sanitary_values['thumbnail'] = sanitize_text_field( $input['thumbnail'] );
-                }
-                if ( isset( $input['medium'] ) ) {
-                        $sanitary_values['medium'] = sanitize_text_field( $input['medium'] );
-                }
-                if ( isset( $input['medium_large'] ) ) {
-                        $sanitary_values['medium_large'] = sanitize_text_field( $input['medium_large'] );
-                }
-                if ( isset( $input['large'] ) ) {
-                        $sanitary_values['large'] = sanitize_text_field( $input['large'] );
-                }
-
-                $image_sizes = wp_get_additional_image_sizes();
-                foreach ( $image_sizes as $key => $image_size ) {
-                        if ( isset( $input[ $key ] ) ) {
-                                $sanitary_values[ $key ] = sanitize_text_field( $input[ $key ] );
+        public function sanitize( $input ): array {
+                if ( ! is_array( $input ) ) {
+                        return array();
+                }
+
+                $sanitary_values = array();
+                $known_sizes     = array_merge(
+                        array( 'thumbnail', 'medium', 'medium_large', 'large' ),
+                        array_keys( wp_get_additional_image_sizes() )
+                );
+
+                foreach ( $known_sizes as $size ) {
+                        if ( isset( $input[ $size ] ) && sanitize_text_field( $input[ $size ] ) === (string) $size ) {
+                                $sanitary_values[ $size ] = (string) $size;
                         }
                 }
@@ -190 +196 @@
          */
         public function section_info() {
-
         }
 
@@ -203 +208 @@
                         '<label class="switch"><input type="checkbox" name="%s[thumbnail]" id="thumbnail" value="thumbnail" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['thumbnail'] ) && $this->dtat_disablethumbnails_options['thumbnail'] === 'thumbnail' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['thumbnail'] ) && 'thumbnail' === $this->dtat_disablethumbnails_options['thumbnail'] ) ? 'checked' : '',
                         esc_html__( 'Disable Thumbnail size', 'disable-thumbnails-and-threshold' )
                 );
@@ -218 +223 @@
                         '<label class="switch"><input type="checkbox" name="%s[medium]" id="medium" value="medium" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium'] ) && $this->dtat_disablethumbnails_options['medium'] === 'medium' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium'] ) && 'medium' === $this->dtat_disablethumbnails_options['medium'] ) ? 'checked' : '',
                         esc_html__( 'Disable Medium size', 'disable-thumbnails-and-threshold' )
                 );
@@ -233 +238 @@
                         '<label class="switch"><input type="checkbox" name="%s[medium_large]" id="medium_large" value="medium_large" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium_large'] ) && $this->dtat_disablethumbnails_options['medium_large'] === 'medium_large' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium_large'] ) && 'medium_large' === $this->dtat_disablethumbnails_options['medium_large'] ) ? 'checked' : '',
                         esc_html__( 'Disable Medium Large size', 'disable-thumbnails-and-threshold' )
                 );
@@ -248 +253 @@
                         '<label class="switch"><input type="checkbox" name="%s[large]" id="large" value="large" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['large'] ) && $this->dtat_disablethumbnails_options['large'] === 'large' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['large'] ) && 'large' === $this->dtat_disablethumbnails_options['large'] ) ? 'checked' : '',
                         esc_html__( 'Disable Large size', 'disable-thumbnails-and-threshold' )
                 );
@@ -268 +273 @@
                         esc_attr( $name ),
                         esc_attr( $name ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options[$name] ) && $this->dtat_disablethumbnails_options[$name] === $name ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options[ $name ] ) && $name === $this->dtat_disablethumbnails_options[ $name ] ) ? 'checked' : '',
                         /* translators: %s: Image size name */
                         esc_html( sprintf( __( 'Disable %s size', 'disable-thumbnails-and-threshold' ), $name ) )
                 );
         }
-
 }
 if ( is_admin() ) {
-        $DTAT_Disable_Thumbnails = new DTAT_Disable_Thumbnails();
+        $dtat_disable_thumbnails = new DTAT_Disable_Thumbnails();
 }

disable-thumbnails-and-threshold/tags/0.8.0/readme.txt

@@ -3 +3 @@
 Donate link: https://kgmservizi.com
 Tags: thumbnails, disable thumbnails, disable threshold, disable images, image options
-Requires at least: 5.4
-Tested up to: 6.8
-Requires PHP: 7.4
-Stable tag: 0.7.0
+Requires at least: 5.6
+Tested up to: 7.1
+Requires PHP: 8.0
+Stable tag: 0.8.0
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -76 +76 @@
 == Changelog ==
 
+= 0.8.0 =
+* Requirements: minimum PHP raised to 8.0 and minimum WordPress to 5.6 (the first release with PHP 8.0 support).
+* Fix: saving the Image Sizes page with every size unchecked caused a fatal error.
+* Fix: settings saved through WP-CLI were silently discarded.
+* Fix: the "cropped" label now appears for custom image sizes registered with cropping.
+* Fix: no fatal error when another plugin hooks `jpeg_quality` or `big_image_size_threshold` with required extra arguments.
+* Coding standards cleanup.
+
 = 0.7.0 =
 * Improved accessibility: toggle switches are now fully keyboard-navigable with visible focus indicators and screen-reader labels.
@@ -98 +106 @@
 == Upgrade Notice ==
 
+= 0.8.0 =
+Requires PHP 8.0+ and WordPress 5.6+. Fixes a fatal error when unchecking every image size.
+
 = 0.7.0 =
 Accessibility, compatibility and performance improvements. No breaking changes — all settings and URLs are preserved. Recommended update for all users.

disable-thumbnails-and-threshold/trunk/disable-thumbnails-and-thresold.php

@@ -1 +1 @@
 <?php
-/* 
-Plugin Name: Disable Thumbnails, Threshold and Image Options
-Version: 0.7.0
-Description: Disable Thumbnails, Threshold and Image Options
-Author: KGM Servizi
-Author URI: https://kgmservizi.com
-License: GPLv2 or later
-License URI: https://www.gnu.org/licenses/gpl-2.0.html
-Text Domain: disable-thumbnails-and-threshold
-Requires at least: 5.4
-Requires PHP: 7.4
-*/
+/**
+ * Plugin Name: Disable Thumbnails, Threshold and Image Options
+ * Version: 0.8.0
+ * Description: Disable Thumbnails, Threshold and Image Options
+ * Author: KGM Servizi
+ * Author URI: https://kgmservizi.com
+ * License: GPLv2 or later
+ * License URI: https://www.gnu.org/licenses/gpl-2.0.html
+ * Text Domain: disable-thumbnails-and-threshold
+ * Requires at least: 5.6
+ * Requires PHP: 8.0
+ *
+ * @package Disable_Thumbnails_Threshold
+ */
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
-}
-
-// Define plugin constants for better maintainability
+        exit; // Exit if accessed directly.
+}
+
+// Define plugin constants for better maintainability.
 define( 'DTAT_QUALITY_OPTION', 'dtat_imgquality_option_name' );
 define( 'DTAT_THRESHOLD_OPTION', 'dtat_disablethreshold_option_name' );
 define( 'DTAT_THUMBNAILS_OPTION', 'dtat_disablethumbnails_option_name' );
 define( 'DTAT_MIGRATION_OPTION', 'dtat_migration_done' );
-define( 'DTAT_VERSION', '0.7.0' );
-
-/**
- * PHPCS Suppressions
- * 
- * This file contains phpcs:ignore comments for the following cases:
- * - Line 151, 131 (option-quality.php): WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
- *   Reason: Using WordPress core hook (jpeg_quality) which doesn't require plugin prefix
- * - Line 174, 172 (option-threshold-exif.php), 206 (option-threshold-exif.php): WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
- *   Reason: Using WordPress core hook (big_image_size_threshold) which doesn't require plugin prefix
- * - Line 241 (option-threshold-exif.php): WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
- *   Reason: Using WordPress core hook (wp_image_maybe_exif_rotate) which doesn't require plugin prefix
- */
-
-// Check WordPress version compatibility - requires WordPress 5.4+ for PHP 7.4+ support
-// Use admin_init hook to ensure WordPress is fully loaded
+define( 'DTAT_VERSION', '0.8.0' );
+define( 'DTAT_MIN_WP_VERSION', '5.6' );
+define( 'DTAT_MIN_PHP_VERSION', '8.0' );
+
+// Check WordPress version compatibility - WordPress 5.6 is the first release that supports PHP 8.0.
+// Use admin_init hook to ensure WordPress is fully loaded.
 add_action( 'admin_init', 'dtat_check_wordpress_version' );
 
@@ -50 +42 @@
 
 /**
- *  
+ *
  * Retrieve options for quality and threshold
  * Cache options globally to avoid multiple database calls
- * 
  */
 $GLOBALS['dtat_imgquality_options']        = get_option( DTAT_QUALITY_OPTION );
@@ -77 +68 @@
         $processed = true;
 
+        // admin_init also fires for logged-out admin-ajax.php/admin-post.php requests.
+        if ( ! current_user_can( 'manage_options' ) ) {
+                return;
+        }
+
         // Skip migration if already completed for this plugin version.
         if ( get_option( DTAT_MIGRATION_OPTION ) === DTAT_VERSION ) {
@@ -82 +78 @@
         }
 
-        $option_map = [
-                DTAT_QUALITY_OPTION     => 'kgmimgquality_option_name',
-                DTAT_THRESHOLD_OPTION   => 'kgmdisablethreshold_option_name',
-                DTAT_THUMBNAILS_OPTION  => 'kgmdisablethumbnails_option_name',
-        ];
+        $option_map = array(
+                DTAT_QUALITY_OPTION    => 'kgmimgquality_option_name',
+                DTAT_THRESHOLD_OPTION  => 'kgmdisablethreshold_option_name',
+                DTAT_THUMBNAILS_OPTION => 'kgmdisablethumbnails_option_name',
+        );
 
         foreach ( $option_map as $new_option => $legacy_option ) {
@@ -105 +101 @@
         }
 
+        /*
+         * The globals were cached at load time, before the migration. Without a refresh,
+         * dtat_initialize_options() (same hook, later) sees them empty and overwrites the
+         * migrated values with defaults, after the legacy rows are already deleted.
+         */
+        $GLOBALS['dtat_imgquality_options']        = get_option( DTAT_QUALITY_OPTION );
+        $GLOBALS['dtat_disablethreshold_options']  = get_option( DTAT_THRESHOLD_OPTION );
+        $GLOBALS['dtat_disablethumbnails_options'] = get_option( DTAT_THUMBNAILS_OPTION );
+
         update_option( DTAT_MIGRATION_OPTION, DTAT_VERSION );
 }
 
 
-// Initialize with current WordPress values if options don't exist
-// This will be handled in the admin_init hook to ensure WordPress is fully loaded
+// Initialize with current WordPress values if options don't exist.
+// This will be handled in the admin_init hook to ensure WordPress is fully loaded.
 add_action( 'admin_init', 'dtat_initialize_options' );
 
-// Hook to apply filters after themes are loaded to ensure priority
+// Hook to apply filters after themes are loaded to ensure priority.
 add_action( 'after_setup_theme', 'dtat_apply_filters', 20 );
 
@@ -126 +131 @@
  */
 function dtat_check_wordpress_version(): void {
-        // Only run in admin
+        // Only run in admin.
         if ( ! is_admin() ) {
                 return;
         }
-        
-        // Check if WordPress version is compatible
-        if ( version_compare( get_bloginfo( 'version' ), '5.4', '<' ) ) {
+
+        // Check if WordPress version is compatible.
+        if ( version_compare( get_bloginfo( 'version' ), DTAT_MIN_WP_VERSION, '<' ) ) {
                 add_action( 'admin_notices', 'dtat_wordpress_version_notice' );
         }
@@ -146 +151 @@
 function dtat_wordpress_version_notice(): void {
         printf(
-                '<div class="notice notice-error"><p><strong>%s</strong> %s</p></div>',
-                esc_html__( 'Disable Thumbnails, Threshold and Image Options', 'disable-thumbnails-and-threshold' ),
-                esc_html__( 'requires WordPress 5.4 or higher (PHP 7.4+). Please update WordPress.', 'disable-thumbnails-and-threshold' )
+                '<div class="notice notice-error"><p>%s</p></div>',
+                esc_html(
+                        sprintf(
+                                /* translators: 1: Plugin name, 2: Minimum WordPress version, 3: Minimum PHP version. */
+                                __( '%1$s requires WordPress %2$s or higher and PHP %3$s or higher. Please update.', 'disable-thumbnails-and-threshold' ),
+                                'Disable Thumbnails, Threshold and Image Options',
+                                DTAT_MIN_WP_VERSION,
+                                DTAT_MIN_PHP_VERSION
+                        )
+                )
         );
 }
@@ -162 +174 @@
  */
 function dtat_initialize_options(): void {
-        // Only run in admin and if user has proper capabilities
+        // Only run in admin and if user has proper capabilities.
         if ( ! is_admin() || ! current_user_can( 'manage_options' ) ) {
                 return;
         }
-        
-        // Initialize JPEG quality option if it doesn't exist or is invalid
-        if ( ! $GLOBALS['dtat_imgquality_options'] || 
-                 ! is_array( $GLOBALS['dtat_imgquality_options'] ) || 
-                 ! isset( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
-                 ! is_numeric( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
-                 intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) < 1 ||
-                 intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) > 100 ) {
-                
-                // Get current WordPress JPEG quality (respects existing filters/plugins)
-                // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
-                $current_quality = apply_filters( 'jpeg_quality', 82 );
-                
-                // Validate the quality value from filters
+
+        // Initialize JPEG quality option if it doesn't exist or is invalid.
+        if ( ! $GLOBALS['dtat_imgquality_options'] ||
+                ! is_array( $GLOBALS['dtat_imgquality_options'] ) ||
+                ! isset( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
+                ! is_numeric( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) ||
+                intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) < 1 ||
+                intval( $GLOBALS['dtat_imgquality_options']['jpeg_quality'] ) > 100 ) {
+                /*
+                 * Get current WordPress JPEG quality (respects existing filters/plugins).
+                 * Pass every argument core passes: on PHP 8 a third-party callback with a
+                 * required $context would otherwise throw ArgumentCountError here.
+                 */
+                try {
+                        // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
+                        $current_quality = apply_filters( 'jpeg_quality', 82, 'image_resize' );
+                } catch ( Throwable $e ) {
+                        $current_quality = 82;
+                }
+
+                // Validate the quality value from filters.
                 if ( ! is_numeric( $current_quality ) || $current_quality < 1 || $current_quality > 100 ) {
-                        $current_quality = 82; // Fallback to WordPress default
-                }
-                
-                // Preserve existing options and only update jpeg_quality
+                        $current_quality = 82; // Fallback to WordPress default.
+                }
+
+                // Preserve existing options and only update jpeg_quality.
                 if ( ! is_array( $GLOBALS['dtat_imgquality_options'] ) ) {
-                        $GLOBALS['dtat_imgquality_options'] = [];
+                        $GLOBALS['dtat_imgquality_options'] = array();
                 }
                 $GLOBALS['dtat_imgquality_options']['jpeg_quality'] = intval( $current_quality );
                 update_option( DTAT_QUALITY_OPTION, $GLOBALS['dtat_imgquality_options'] );
         }
-        
-        // Initialize threshold option if it doesn't exist or is invalid
-        if ( ! $GLOBALS['dtat_disablethreshold_options'] || 
-                 ! is_array( $GLOBALS['dtat_disablethreshold_options'] ) || 
-                 ! isset( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
-                 ! is_numeric( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
-                 intval( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) <= 0 ) {
-                
-                // Get current WordPress big image threshold (respects existing filters/plugins)
-                // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
-                $current_threshold = apply_filters( 'big_image_size_threshold', 2560 );
-                
-                // Validate the threshold value from filters
+
+        // Initialize threshold option if it doesn't exist or is invalid.
+        if ( ! $GLOBALS['dtat_disablethreshold_options'] ||
+                ! is_array( $GLOBALS['dtat_disablethreshold_options'] ) ||
+                ! isset( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
+                ! is_numeric( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) ||
+                intval( $GLOBALS['dtat_disablethreshold_options']['new_threshold'] ) <= 0 ) {
+                /*
+                 * Get current WordPress big image threshold (respects existing filters/plugins).
+                 * Core passes $imagesize, $file and $attachment_id; there is no real image here,
+                 * so neutral values are passed and any callback failure falls back to the default.
+                 */
+                try {
+                        // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- WordPress core hook
+                        $current_threshold = apply_filters( 'big_image_size_threshold', 2560, array( 0, 0 ), '', 0 );
+                } catch ( Throwable $e ) {
+                        $current_threshold = 2560;
+                }
+
+                // Validate the threshold value from filters.
                 if ( ! is_numeric( $current_threshold ) || $current_threshold <= 0 ) {
-                        $current_threshold = 2560; // Fallback to WordPress default
-                }
-                
-                // Preserve existing options and only update new_threshold
+                        $current_threshold = 2560; // Fallback to WordPress default.
+                }
+
+                // Preserve existing options and only update new_threshold.
                 if ( ! is_array( $GLOBALS['dtat_disablethreshold_options'] ) ) {
-                        $GLOBALS['dtat_disablethreshold_options'] = [];
+                        $GLOBALS['dtat_disablethreshold_options'] = array();
                 }
                 $GLOBALS['dtat_disablethreshold_options']['new_threshold'] = intval( $current_threshold );
@@ -225 +251 @@
  */
 function dtat_jpeg_quality_filter(): int {
-        $dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
-        
+        $dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, array() );
+
         if ( ! is_array( $dtat_imgquality_options ) || ! isset( $dtat_imgquality_options['jpeg_quality'] ) ) {
-                return 82; // WordPress default
-        }
-        
+                return 82; // WordPress default.
+        }
+
         $quality = intval( $dtat_imgquality_options['jpeg_quality'] );
-        
-        // Validate quality range (0-100)
-        if ( $quality < 0 || $quality > 100 ) {
-                return 82; // WordPress default
-        }
-        
+
+        // Same 1-100 range accepted by the settings page.
+        if ( $quality < 1 || $quality > 100 ) {
+                return 82; // WordPress default.
+        }
+
         return $quality;
 }
@@ -249 +275 @@
  */
 function dtat_big_image_threshold_filter(): int {
-        $dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, [] );
-        
+        $dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, array() );
+
         if ( ! is_array( $dtat_disablethreshold_options ) || ! isset( $dtat_disablethreshold_options['new_threshold'] ) ) {
-                return 2560; // WordPress default
-        }
-        
+                return 2560; // WordPress default.
+        }
+
         $threshold = intval( $dtat_disablethreshold_options['new_threshold'] );
-        
-        // Validate threshold is positive
+
+        // Validate threshold is positive.
         if ( $threshold <= 0 ) {
-                return 2560; // WordPress default
-        }
-        
+                return 2560; // WordPress default.
+        }
+
         return $threshold;
 }
@@ -270 +296 @@
  * @since   0.1
  * @package Disable_Thumbnails_Threshold
- * @param   array $sizes Registered intermediate image sizes.
- * @return  array Filtered image sizes with disabled ones removed.
- */
-function dtat_thumbnail_sizes_filter( array $sizes ): array {
-        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, [] );
-        
+ * @param   mixed $sizes Registered intermediate image sizes (an array, unless another filter broke it).
+ * @return  mixed Filtered image sizes with disabled ones removed.
+ */
+function dtat_thumbnail_sizes_filter( $sizes ) {
+        // Untyped on purpose: a TypeError here would break every media upload.
+        if ( ! is_array( $sizes ) ) {
+                return $sizes;
+        }
+
+        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, array() );
+
         if ( ! is_array( $dtat_disablethumbnails_options ) || empty( $dtat_disablethumbnails_options ) ) {
                 return $sizes;
         }
-        
-        // Validate that all values in the array are strings (security check)
+
+        // Validate that all values in the array are strings (security check).
         $valid_options = array_filter( $dtat_disablethumbnails_options, 'is_string' );
-        
+
         return array_diff( $sizes, $valid_options );
 }
@@ -294 +325 @@
  */
 function dtat_apply_filters(): void {
-        // Prevent multiple applications
+        // Prevent multiple applications.
         static $applied = false;
         if ( $applied ) {
@@ -300 +331 @@
         }
         $applied = true;
-        
-        // Remove any existing filters to prevent accumulation
+
+        // Remove any existing filters to prevent accumulation.
         remove_filter( 'jpeg_quality', 'dtat_jpeg_quality_filter' );
         remove_filter( 'big_image_size_threshold', 'dtat_big_image_threshold_filter' );
         remove_filter( 'intermediate_image_sizes', 'dtat_thumbnail_sizes_filter' );
-        
-        // Safely get options with fallback
-        $dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
-        $dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, [] );
-        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, [] );
-        
-        // Apply JPEG quality filter
+
+        // Safely get options with fallback.
+        $dtat_imgquality_options        = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, array() );
+        $dtat_disablethreshold_options  = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, array() );
+        $dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, array() );
+
+        // Apply JPEG quality filter.
         $jpeg_quality = null;
         if ( is_array( $dtat_imgquality_options ) ) {
                 $jpeg_quality = $dtat_imgquality_options['jpeg_quality'] ?? null;
         }
-        
+
         $quality = $jpeg_quality ? intval( $jpeg_quality ) : 0;
         if ( $jpeg_quality && is_numeric( $jpeg_quality ) && $quality > 0 && $quality <= 100 ) {
@@ -322 +353 @@
         }
 
-        // Apply threshold filters
+        // Apply threshold filters.
         if ( is_array( $dtat_disablethreshold_options ) ) {
-                // Set new threshold
+                // Set new threshold.
                 if ( ! empty( $dtat_disablethreshold_options['new_threshold'] )
                         && is_numeric( $dtat_disablethreshold_options['new_threshold'] ) ) {
@@ -333 +364 @@
                 }
 
-                // Disable threshold
+                // Disable threshold.
                 if ( 'disable_threshold' === ( $dtat_disablethreshold_options['disable_threshold'] ?? null ) ) {
                         add_filter( 'big_image_size_threshold', '__return_false', 100 );
                 }
 
-                // Disable EXIF rotation
+                // Disable EXIF rotation.
                 if ( 'disable_image_rotation_exif' === ( $dtat_disablethreshold_options['disable_image_rotation_exif'] ?? null ) ) {
                         add_filter( 'wp_image_maybe_exif_rotate', '__return_zero', 100, 2 );
@@ -344 +375 @@
         }
 
-        // Apply thumbnail size filters
+        // Apply thumbnail size filters.
         if ( ! empty( $dtat_disablethumbnails_options ) ) {
                 add_filter( 'intermediate_image_sizes', 'dtat_thumbnail_sizes_filter', 100 );
@@ -350 +381 @@
 }
 
-// All filters are now applied in dtat_apply_filters() function after themes are loaded
+// All filters are now applied in dtat_apply_filters() function after themes are loaded.
 
 /**
@@ -361 +392 @@
  */
 function dtat_action_links( array $actions ): array {
-        // Check if user has proper capabilities before showing action links
+        // Check if user has proper capabilities before showing action links.
         if ( ! current_user_can( 'manage_options' ) ) {
                 return $actions;
         }
-        
-        $mylinks = [
+
+        $mylinks = array(
                 '<a href="' . esc_url( get_admin_url( null, 'tools.php?page=kgmdisablethumbnails' ) ) . '">' . esc_html__( 'Image sizes', 'disable-thumbnails-and-threshold' ) . '</a>',
                 '<a href="' . esc_url( get_admin_url( null, 'tools.php?page=kgmimgquality' ) ) . '">' . esc_html__( 'Image Quality', 'disable-thumbnails-and-threshold' ) . '</a>',
                 '<a href="' . esc_url( get_admin_url( null, 'tools.php?page=kgmdisablethreshold' ) ) . '">' . esc_html__( 'Threshold & EXIF', 'disable-thumbnails-and-threshold' ) . '</a>',
-        ];
+        );
         return array_merge( $mylinks, $actions );
 }
@@ -383 +414 @@
  */
 function dtat_admin_styles( string $hook ): void {
-        /**
-         * Check if in plugin options page and user has proper capabilities
-         */
         if ( ! current_user_can( 'manage_options' ) ) {
                 return;
         }
-        
-        $screen = get_current_screen();
-        if ( ! $screen ) {
-                return;
-        }
-        
-        if ( 'tools_page_kgmdisablethumbnails' === $screen->base || 'tools_page_kgmdisablethreshold' === $screen->base ) {
-                wp_enqueue_style( 'dtat-admin-css', plugins_url( 'includes/admin.css', __FILE__ ), [], DTAT_VERSION );
-        }
-}
+
+        $plugin_pages = array( 'tools_page_kgmdisablethumbnails', 'tools_page_kgmdisablethreshold', 'tools_page_kgmimgquality' );
+        if ( in_array( $hook, $plugin_pages, true ) ) {
+                wp_enqueue_style( 'dtat-admin-css', plugins_url( 'includes/admin.css', __FILE__ ), array(), DTAT_VERSION );
+        }
+}
+
+register_uninstall_hook( __FILE__, 'dtat_plugin_uninstall' );
 
 /**
  * Clean up plugin options on uninstall.
  *
- * @since   0.1
- * @package Disable_Thumbnails_Threshold
- * @return  void
- */
-register_uninstall_hook( __FILE__, 'dtat_plugin_uninstall' );
+ * Also removes the pre-0.6.5 `kgm*` options, which survive when the migration never ran.
+ *
+ * @since   0.1
+ * @package Disable_Thumbnails_Threshold
+ * @return  void
+ */
 function dtat_plugin_uninstall(): void {
         delete_option( DTAT_THUMBNAILS_OPTION );
@@ -413 +440 @@
         delete_option( DTAT_QUALITY_OPTION );
         delete_option( DTAT_MIGRATION_OPTION );
-}
+        delete_option( 'kgmimgquality_option_name' );
+        delete_option( 'kgmdisablethreshold_option_name' );
+        delete_option( 'kgmdisablethumbnails_option_name' );
+}

disable-thumbnails-and-threshold/trunk/includes/admin.css

@@ -1 +1 @@
 .switch { position: relative; display: inline-block; width: 33px; height: 17px; margin-right: 0.4em; }
 .switch input { position: absolute; opacity: 0; width: 1px; height: 1px; clip: rect(0 0 0 0); overflow: hidden; }
-.slider { position: absolute; cursor: pointer; top: 0; left: 0; right: 0; bottom: 0; background-color: #ccc; -webkit-transition: 0.5s; transition: 0.5s; border-radius: 18px; display:inline; }
+/* Inset border #757575: 4.05:1 on the form-table background #f0f0f1 (SC 1.4.11 needs 3:1). */
+.slider { position: absolute; cursor: pointer; top: 0; left: 0; right: 0; bottom: 0; background-color: #ccc; box-shadow: inset 0 0 0 1px #757575; -webkit-transition: 0.5s; transition: 0.5s; border-radius: 18px; display:inline; }
 .slider::before { position: absolute; content: ""; height: 10px; width: 10px; left: 4px; bottom: 4px; background-color: #fff; -webkit-transition: 0.5s; transition: 0.5s; border-radius: 50%; }
 input:checked + .screen-reader-text + .slider,
 input:checked + .slider { background-color: #b12222; }
+/* Transparent outline: box-shadow is dropped in forced-colors mode, the outline is not. */
 input:focus + .screen-reader-text + .slider,
-input:focus + .slider { box-shadow: 0 0 0 3px #005fcc; }
+input:focus + .slider { outline: 2px solid transparent; outline-offset: 2px; box-shadow: inset 0 0 0 1px #757575, 0 0 0 3px #005fcc; }
 input:checked + .screen-reader-text + .slider::before,
 input:checked + .slider::before { -webkit-transform: translateX(16px); -ms-transform: translateX(16px); transform: translateX(16px); }
-.dtat-notice-warning { color: #d63638; }
-.dtat-notice-caution { color: #dba617; }
+@media (forced-colors: active) {
+        .slider { border: 1px solid ButtonText; }
+        .slider::before { background-color: ButtonText; }
+        input:checked + .screen-reader-text + .slider,
+        input:checked + .slider { background-color: Highlight; }
+}
+/* Ratios on #f0f0f1: warning 5.53:1, caution 4.86:1, info 5.04:1 (SC 1.4.3 needs 4.5:1). */
+.dtat-notice-warning { color: #b32d2e; }
+.dtat-notice-caution { color: #8a6100; }
 .dtat-notice-info { color: #666; }

disable-thumbnails-and-threshold/trunk/includes/option-quality.php

@@ -12 +12 @@
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
+        exit; // Exit if accessed directly.
 }
 
+/**
+ * Image Quality settings page.
+ *
+ * @since 0.2
+ */
 class DTAT_Img_Quality {
-        private array|false $dtat_imgquality_options;
+        /**
+         * Stored option value. Untyped on purpose: whatever the database holds must not raise a TypeError.
+         *
+         * @var array|false
+         */
+        private $dtat_imgquality_options = false;
 
         /**
@@ -24 +34 @@
          */
         public function __construct() {
-                add_action( 'admin_menu', [ $this, 'add_plugin_page' ] );
-                add_action( 'admin_init', [ $this, 'page_init' ] );
+                add_action( 'admin_menu', array( $this, 'add_plugin_page' ) );
+                add_action( 'admin_init', array( $this, 'page_init' ) );
         }
 
@@ -40 +50 @@
                         'manage_options',
                         'kgmimgquality',
-                        [ $this, 'create_admin_page' ]
+                        array( $this, 'create_admin_page' )
                 );
         }
@@ -51 +61 @@
          */
         public function create_admin_page() {
-                // Check user capabilities for security
+                // Check user capabilities for security.
                 if ( ! current_user_can( 'manage_options' ) ) {
                         wp_die( esc_html__( 'You do not have sufficient permissions to access this page.', 'disable-thumbnails-and-threshold' ) );
                 }
-                
-                // Use cached options to avoid database calls
+
+                // Use cached options to avoid database calls.
                 $this->dtat_imgquality_options = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION ); ?>
 
                 <div class="wrap">
-                        <h2><?php echo esc_html__( 'Image Quality', 'disable-thumbnails-and-threshold' ); ?></h2>
+                        <h1><?php echo esc_html__( 'Image Quality', 'disable-thumbnails-and-threshold' ); ?></h1>
                         <p><strong><?php echo esc_html__( 'Remember you need to regenerate thumbnails for delete old thumbnails image already generated.', 'disable-thumbnails-and-threshold' ); ?></strong></p>
-                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/reg-thumb' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
-                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/WP-CLI-thumb-rgnrt' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://wordpress.org/plugins/regenerate-thumbnails/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://developer.wordpress.org/cli/commands/media/regenerate/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
                         <?php settings_errors(); ?>
 
@@ -74 +84 @@
                         </form>
                 </div>
-        <?php }
+                <?php
+        }
 
         /**
@@ -86 +97 @@
                         'kgmimgquality_option_group',
                         DTAT_QUALITY_OPTION,
-                        [ $this, 'sanitize' ]
+                        array( $this, 'sanitize' )
                 );
 
                 add_settings_section(
                         'kgmimgquality_setting_section',
-                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'section_info' ],
-                        'kgmimgquality-admin' 
+                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'section_info' ),
+                        'kgmimgquality-admin'
                 );
 
@@ -99 +110 @@
                         'jpeg_quality',
                         esc_html__( 'JPEG Quality', 'disable-thumbnails-and-threshold' ) . ' <br> <small>' . esc_html__( 'Default WordPress: 82%', 'disable-thumbnails-and-threshold' ) . '</small>',
-                        [ $this, 'jpeg_quality_callback' ],
+                        array( $this, 'jpeg_quality_callback' ),
                         'kgmimgquality-admin',
-                        'kgmimgquality_setting_section'
+                        'kgmimgquality_setting_section',
+                        array( 'label_for' => 'jpeg_quality' )
                 );
         }
@@ -108 +120 @@
          * Sanitize and validate form input before saving.
          *
-         * @since  0.2
-         * @param  array $input Raw form input values.
+         * Runs on every update_option() of this option, not only on form submit, so it
+         * must not depend on the current user: options.php already enforces the nonce
+         * and the manage_options capability before saving.
+         *
+         * @since  0.2
+         * @param  mixed $input Raw value; null when the field is missing from the request.
          * @return array Sanitized values.
          */
-        public function sanitize( array $input ): array {
-                // Check user capabilities for security
-                if ( ! current_user_can( 'manage_options' ) ) {
-                        return $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
-                }
-                
-                // Nonce is already verified by WordPress options.php handler via settings_fields().
-                $sanitary_values = [];
+        public function sanitize( $input ): array {
+                if ( ! is_array( $input ) ) {
+                        $input = array();
+                }
+
+                $sanitary_values = array();
 
                 if ( isset( $input['jpeg_quality'] ) ) {
-                        $quality = sanitize_text_field( $input['jpeg_quality'] );
+                        $quality     = sanitize_text_field( $input['jpeg_quality'] );
                         $quality_int = intval( $quality );
                         if ( is_numeric( $quality ) && $quality_int >= 1 && $quality_int <= 100 ) {
@@ -128 +142 @@
                         } else {
                                 add_settings_error( 'kgmimgquality_option_notice', 'invalid_quality', esc_html__( 'JPEG quality must be a number between 1 and 100.', 'disable-thumbnails-and-threshold' ) );
-                                $existing = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, [] );
+                                $existing = $GLOBALS['dtat_imgquality_options'] ?? get_option( DTAT_QUALITY_OPTION, array() );
                                 if ( is_array( $existing ) && isset( $existing['jpeg_quality'] ) ) {
-                                        return [ 'jpeg_quality' => absint( $existing['jpeg_quality'] ) ];
+                                        return array( 'jpeg_quality' => absint( $existing['jpeg_quality'] ) );
                                 }
-                                return [];
+                                return array();
                         }
                 }
@@ -162 +176 @@
                         esc_html__( '%', 'disable-thumbnails-and-threshold' )
                 );
-                
+
                 // Compare plugin value against WordPress default.
                 // We avoid calling apply_filters() here because the jpeg_quality filter expects
@@ -173 +187 @@
 
                 if ( $plugin_quality && $plugin_quality !== $wp_default_quality ) {
-                        printf( '<br><small class="description dtat-notice-warning">%s %s</small>',
+                        printf(
+                                '<br><small class="description dtat-notice-warning">%s %s</small>',
                                 esc_html( '⚠️' ),
-                                // translators: %1$d: Plugin quality percentage, %2$d: WordPress default quality percentage
+                                /* translators: %1$d: Plugin quality percentage, %2$d: WordPress default quality percentage */
                                 esc_html( sprintf( __( 'Plugin quality (%1$d%%) differs from WordPress default (%2$d%%)', 'disable-thumbnails-and-threshold' ), $plugin_quality, $wp_default_quality ) )
                         );
                 } else {
-                        printf( '<br><small class="description dtat-notice-info">%s</small>',
-                                // translators: %d: WordPress default JPEG quality percentage
+                        printf(
+                                '<br><small class="description dtat-notice-info">%s</small>',
+                                /* translators: %d: WordPress default JPEG quality percentage */
                                 esc_html( sprintf( __( 'WordPress default JPEG quality: %d%%', 'disable-thumbnails-and-threshold' ), $wp_default_quality ) )
                         );
                 }
         }
-
 }
 if ( is_admin() ) {
-        $DTAT_Img_Quality = new DTAT_Img_Quality();
+        $dtat_img_quality = new DTAT_Img_Quality();
 }

disable-thumbnails-and-threshold/trunk/includes/option-threshold-exif.php

@@ -12 +12 @@
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
+        exit; // Exit if accessed directly.
 }
 
+/**
+ * Threshold & EXIF settings page.
+ *
+ * @since 0.1
+ */
 class DTAT_Disable_Threshold {
-        private array|false $dtat_disablethreshold_options;
+        /**
+         * Stored option value. Untyped on purpose: whatever the database holds must not raise a TypeError.
+         *
+         * @var array|false
+         */
+        private $dtat_disablethreshold_options = false;
 
         /**
@@ -24 +34 @@
          */
         public function __construct() {
-                add_action( 'admin_menu', [ $this, 'add_plugin_page' ] );
-                add_action( 'admin_init', [ $this, 'page_init' ] );
+                add_action( 'admin_menu', array( $this, 'add_plugin_page' ) );
+                add_action( 'admin_init', array( $this, 'page_init' ) );
         }
 
@@ -40 +50 @@
                         'manage_options',
                         'kgmdisablethreshold',
-                        [ $this, 'create_admin_page' ]
+                        array( $this, 'create_admin_page' )
                 );
         }
@@ -51 +61 @@
          */
         public function create_admin_page() {
-                // Check user capabilities for security
+                // Check user capabilities for security.
                 if ( ! current_user_can( 'manage_options' ) ) {
                         wp_die( esc_html__( 'You do not have sufficient permissions to access this page.', 'disable-thumbnails-and-threshold' ) );
                 }
-                
-                // Use cached options to avoid database calls
+
+                // Use cached options to avoid database calls.
                 $this->dtat_disablethreshold_options = $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION ); ?>
 
                 <div class="wrap">
-                        <h2><?php echo esc_html__( 'Disable Threshold&EXIF', 'disable-thumbnails-and-threshold' ); ?></h2>
+                        <h1><?php echo esc_html__( 'Disable Threshold&EXIF', 'disable-thumbnails-and-threshold' ); ?></h1>
                         <p><strong><?php echo esc_html__( 'Remember you need to regenerate thumbnails for delete old thumbnails image already generated.', 'disable-thumbnails-and-threshold' ); ?></strong></p>
-                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/reg-thumb' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
-                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/WP-CLI-thumb-rgnrt' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://wordpress.org/plugins/regenerate-thumbnails/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://developer.wordpress.org/cli/commands/media/regenerate/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
                         <?php settings_errors(); ?>
 
@@ -74 +84 @@
                         </form>
                 </div>
-        <?php }
+                <?php
+        }
 
         /**
@@ -86 +97 @@
                         'kgmdisablethreshold_option_group',
                         DTAT_THRESHOLD_OPTION,
-                        [ $this, 'sanitize' ]
+                        array( $this, 'sanitize' )
                 );
 
                 add_settings_section(
                         'kgmdisablethreshold_setting_section',
-                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'section_info' ],
-                        'kgmdisablethreshold-admin' 
+                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'section_info' ),
+                        'kgmdisablethreshold-admin'
                 );
 
@@ -99 +110 @@
                         'new_threshold',
                         esc_html__( 'New Size Threshold', 'disable-thumbnails-and-threshold' ) . ' <br> <small>' . esc_html__( 'Default WordPress: 2560px', 'disable-thumbnails-and-threshold' ) . '</small>',
-                        [ $this, 'new_threshold_callback' ],
+                        array( $this, 'new_threshold_callback' ),
                         'kgmdisablethreshold-admin',
-                        'kgmdisablethreshold_setting_section'
+                        'kgmdisablethreshold_setting_section',
+                        array( 'label_for' => 'new_threshold' )
                 );
                 add_settings_field(
                         'disable_threshold',
                         esc_html__( 'Disable Threshold', 'disable-thumbnails-and-threshold' ),
-                        [ $this, 'disable_threshold_callback' ],
+                        array( $this, 'disable_threshold_callback' ),
                         'kgmdisablethreshold-admin',
                         'kgmdisablethreshold_setting_section'
@@ -113 +125 @@
                         'disable_image_rotation_exif',
                         esc_html__( 'Disable Image Rotation by EXIF', 'disable-thumbnails-and-threshold' ),
-                        [ $this, 'disable_image_rotation_exif_callback' ],
+                        array( $this, 'disable_image_rotation_exif_callback' ),
                         'kgmdisablethreshold-admin',
                         'kgmdisablethreshold_setting_section'
@@ -122 +134 @@
          * Sanitize and validate form input before saving.
          *
-         * @since  0.1
-         * @param  array $input Raw form input values.
+         * Runs on every update_option() of this option, not only on form submit, so it
+         * must not depend on the current user: options.php already enforces the nonce
+         * and the manage_options capability before saving.
+         *
+         * @since  0.1
+         * @param  mixed $input Raw value; null when no field is present in the request.
          * @return array Sanitized values.
          */
-        public function sanitize( array $input ): array {
-                // Check user capabilities for security
-                if ( ! current_user_can( 'manage_options' ) ) {
-                        return $GLOBALS['dtat_disablethreshold_options'] ?? get_option( DTAT_THRESHOLD_OPTION, [] );
-                }
-                
-                // Nonce is already verified by WordPress options.php handler via settings_fields().
-                $sanitary_values = [];
+        public function sanitize( $input ): array {
+                if ( ! is_array( $input ) ) {
+                        $input = array();
+                }
+
+                $sanitary_values = array();
 
                 if ( isset( $input['new_threshold'] ) ) {
@@ -183 +197 @@
                         esc_html__( 'px', 'disable-thumbnails-and-threshold' )
                 );
-                
-                // Check if plugin disables threshold
+
+                // Check if plugin disables threshold.
                 $plugin_disables_threshold = false;
                 if ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) ) {
-                        $plugin_disables_threshold = ( $this->dtat_disablethreshold_options['disable_threshold'] === 'disable_threshold' );
-                }
-                
-                // Show yellow warning message if plugin disables threshold
+                        $plugin_disables_threshold = ( 'disable_threshold' === $this->dtat_disablethreshold_options['disable_threshold'] );
+                }
+
+                // Show yellow warning message if plugin disables threshold.
                 if ( $plugin_disables_threshold ) {
-                        printf( '<br><small class="description dtat-notice-caution">%s %s</small>', 
+                        printf(
+                                '<br><small class="description dtat-notice-caution">%s %s</small>',
                                 esc_html( '⚠️' ),
                                 esc_html__( 'Disabled by plugin', 'disable-thumbnails-and-threshold' )
@@ -207 +222 @@
 
                         if ( $plugin_threshold && $plugin_threshold !== $wp_default_threshold ) {
-                                printf( '<br><small class="description dtat-notice-warning">%s %s</small>',
+                                printf(
+                                        '<br><small class="description dtat-notice-warning">%s %s</small>',
                                         esc_html( '⚠️' ),
-                                        // translators: %1$d: Plugin threshold value in pixels, %2$d: WordPress default threshold value in pixels
+                                        /* translators: %1$d: Plugin threshold value in pixels, %2$d: WordPress default threshold value in pixels */
                                         esc_html( sprintf( __( 'Plugin threshold (%1$dpx) differs from WordPress default (%2$dpx)', 'disable-thumbnails-and-threshold' ), $plugin_threshold, $wp_default_threshold ) )
                                 );
                         } else {
-                                // translators: %d: WordPress default big image threshold value in pixels
+                                /* translators: %d: WordPress default big image threshold value in pixels */
                                 printf( '<br><small class="description dtat-notice-info">%s</small>', esc_html( sprintf( __( 'WordPress default big image threshold: %dpx', 'disable-thumbnails-and-threshold' ), $wp_default_threshold ) ) );
                         }
@@ -229 +245 @@
                         '<label class="switch"><input type="checkbox" name="%s[disable_threshold]" id="disable_threshold" value="disable_threshold" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THRESHOLD_OPTION ),
-                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) && $this->dtat_disablethreshold_options['disable_threshold'] === 'disable_threshold' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) && 'disable_threshold' === $this->dtat_disablethreshold_options['disable_threshold'] ) ? 'checked' : '',
                         esc_html__( 'Disable Threshold', 'disable-thumbnails-and-threshold' )
                 );
-                
+
                 // Show informational status based on plugin's stored setting.
                 // We avoid calling apply_filters('big_image_size_threshold') here because it expects
@@ -238 +254 @@
                 $plugin_intends_to_disable = false;
                 if ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_threshold'] ) ) {
-                        $plugin_intends_to_disable = ( $this->dtat_disablethreshold_options['disable_threshold'] === 'disable_threshold' );
+                        $plugin_intends_to_disable = ( 'disable_threshold' === $this->dtat_disablethreshold_options['disable_threshold'] );
                 }
 
                 if ( $plugin_intends_to_disable ) {
-                        printf( '<br><small class="description dtat-notice-info">%s</small>',
+                        printf(
+                                '<br><small class="description dtat-notice-info">%s</small>',
                                 esc_html__( 'Threshold is disabled by this plugin.', 'disable-thumbnails-and-threshold' )
                         );
@@ -258 +275 @@
                         '<label class="switch"><input type="checkbox" name="%s[disable_image_rotation_exif]" id="disable_image_rotation_exif" value="disable_image_rotation_exif" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THRESHOLD_OPTION ),
-                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) && $this->dtat_disablethreshold_options['disable_image_rotation_exif'] === 'disable_image_rotation_exif' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) && 'disable_image_rotation_exif' === $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) ? 'checked' : '',
                         esc_html__( 'Disable Image Rotation by EXIF', 'disable-thumbnails-and-threshold' )
                 );
-                
+
                 // Show informational status based on plugin's stored setting.
                 // We avoid calling apply_filters('wp_image_maybe_exif_rotate') here because it expects
@@ -267 +284 @@
                 $plugin_exif_disabled = false;
                 if ( is_array( $this->dtat_disablethreshold_options ) && isset( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] ) ) {
-                        $plugin_exif_disabled = ( $this->dtat_disablethreshold_options['disable_image_rotation_exif'] === 'disable_image_rotation_exif' );
+                        $plugin_exif_disabled = ( 'disable_image_rotation_exif' === $this->dtat_disablethreshold_options['disable_image_rotation_exif'] );
                 }
 
                 if ( $plugin_exif_disabled ) {
-                        printf( '<br><small class="description dtat-notice-info">%s</small>',
+                        printf(
+                                '<br><small class="description dtat-notice-info">%s</small>',
                                 esc_html__( 'EXIF rotation is disabled by this plugin.', 'disable-thumbnails-and-threshold' )
                         );
                 }
         }
-
 }
 if ( is_admin() ) {
-        $DTAT_Disable_Threshold = new DTAT_Disable_Threshold();
+        $dtat_disable_threshold = new DTAT_Disable_Threshold();
 }

disable-thumbnails-and-threshold/trunk/includes/option-thumbnails.php

@@ -12 +12 @@
 
 if ( ! defined( 'ABSPATH' ) ) {
-        exit; // Exit if accessed directly
+        exit; // Exit if accessed directly.
 }
 
+/**
+ * Image Sizes settings page.
+ *
+ * @since 0.1
+ */
 class DTAT_Disable_Thumbnails {
-        private array|false $dtat_disablethumbnails_options;
+        /**
+         * Stored option value. Untyped on purpose: whatever the database holds must not raise a TypeError.
+         *
+         * @var array|false
+         */
+        private $dtat_disablethumbnails_options = false;
 
         /**
@@ -24 +34 @@
          */
         public function __construct() {
-                add_action( 'admin_menu', [ $this, 'add_plugin_page' ] );
-                add_action( 'admin_init', [ $this, 'page_init' ] );
+                add_action( 'admin_menu', array( $this, 'add_plugin_page' ) );
+                add_action( 'admin_init', array( $this, 'page_init' ) );
         }
 
@@ -36 +46 @@
         public function add_plugin_page() {
                 add_management_page(
-                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ), 
-                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ), 
-                        'manage_options', 
-                        'kgmdisablethumbnails', 
-                        [ $this, 'create_admin_page' ]
+                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ),
+                        esc_html__( 'Image Sizes', 'disable-thumbnails-and-threshold' ),
+                        'manage_options',
+                        'kgmdisablethumbnails',
+                        array( $this, 'create_admin_page' )
                 );
         }
@@ -51 +61 @@
          */
         public function create_admin_page() {
-                // Check user capabilities for security
+                // Check user capabilities for security.
                 if ( ! current_user_can( 'manage_options' ) ) {
                         wp_die( esc_html__( 'You do not have sufficient permissions to access this page.', 'disable-thumbnails-and-threshold' ) );
                 }
-                
-                // Use cached options to avoid database calls
+
+                // Use cached options to avoid database calls.
                 $this->dtat_disablethumbnails_options = $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION ); ?>
 
                 <div class="wrap">
-                        <h2><?php echo esc_html__( 'Image Thumbnails', 'disable-thumbnails-and-threshold' ); ?></h2>
+                        <h1><?php echo esc_html__( 'Image Thumbnails', 'disable-thumbnails-and-threshold' ); ?></h1>
                         <p><strong><?php echo esc_html__( 'Remember you need to regenerate thumbnails for delete old thumbnails image already generated.', 'disable-thumbnails-and-threshold' ); ?></strong></p>
-                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/reg-thumb' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
-                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://uskgm.it/WP-CLI-thumb-rgnrt' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'Plugin recommended for regenerate thumbnails', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://wordpress.org/plugins/regenerate-thumbnails/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Regenerate Thumbnails', 'disable-thumbnails-and-threshold' ); ?></a></p>
+                        <p><?php echo esc_html__( 'WP-CLI media regeneration', 'disable-thumbnails-and-threshold' ); ?> -> <a href="<?php echo esc_url( 'https://developer.wordpress.org/cli/commands/media/regenerate/' ); ?>" target="_blank" rel="noopener"><?php echo esc_html__( 'Documentation', 'disable-thumbnails-and-threshold' ); ?></a></p>
                         <p><?php echo esc_html__( 'Flagged image sizes will be disabled.', 'disable-thumbnails-and-threshold' ); ?></p>
                         <?php settings_errors(); ?>
@@ -75 +85 @@
                         </form>
                 </div>
-        <?php }
+                <?php
+        }
 
         /**
@@ -86 +97 @@
                 register_setting(
                         'kgmdisablethumbnails_option_group',
-                        DTAT_THUMBNAILS_OPTION, 
-                        [ $this, 'sanitize' ] 
+                        DTAT_THUMBNAILS_OPTION,
+                        array( $this, 'sanitize' )
                 );
 
                 add_settings_section(
-                        'kgmdisablethumbnails_setting_section', 
-                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'section_info' ],
-                        'kgmdisablethumbnails-admin' 
+                        'kgmdisablethumbnails_setting_section',
+                        esc_html__( 'Settings', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'section_info' ),
+                        'kgmdisablethumbnails-admin'
                 );
 
                 add_settings_field(
                         'thumbnail',
-                        esc_html__( 'Thumbnail', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'thumbnail_callback' ],
-                        'kgmdisablethumbnails-admin', 
-                        'kgmdisablethumbnails_setting_section' 
+                        esc_html__( 'Thumbnail', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'thumbnail_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
                 );
                 add_settings_field(
                         'medium',
-                        esc_html__( 'Medium', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'medium_callback' ],
-                        'kgmdisablethumbnails-admin', 
-                        'kgmdisablethumbnails_setting_section' 
+                        esc_html__( 'Medium', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'medium_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
                 );
                 add_settings_field(
                         'medium_large',
                         esc_html__( 'Medium Large', 'disable-thumbnails-and-threshold' ),
-                        [ $this, 'medium_large_callback' ],
-                        'kgmdisablethumbnails-admin',
-                        'kgmdisablethumbnails_setting_section' 
-                );
-                add_settings_field(
-                        'large', 
-                        esc_html__( 'Large', 'disable-thumbnails-and-threshold' ), 
-                        [ $this, 'large_callback' ],
-                        'kgmdisablethumbnails-admin', 
-                        'kgmdisablethumbnails_setting_section' 
+                        array( $this, 'medium_large_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
+                );
+                add_settings_field(
+                        'large',
+                        esc_html__( 'Large', 'disable-thumbnails-and-threshold' ),
+                        array( $this, 'large_callback' ),
+                        'kgmdisablethumbnails-admin',
+                        'kgmdisablethumbnails_setting_section'
                 );
 
                 $image_sizes = wp_get_additional_image_sizes();
                 foreach ( $image_sizes as $key => $image_size ) {
-                        if ( 1 === $image_size['crop'] ) {
+                        if ( ! empty( $image_size['crop'] ) ) {
                                 $crop = esc_html__( 'cropped', 'disable-thumbnails-and-threshold' );
                         } else {
@@ -135 +146 @@
                         add_settings_field(
                                 $key,
-                                esc_html( $key ) . '<br><small>(' . esc_attr( $image_size['width'] ) . 'x' . esc_attr( $image_size['height'] ) . ')</small><br><small>' . esc_html( $crop ) . '</small>',
-                                [ $this, 'ext_callback' ],
+                                esc_html( $key ) . '<br><small>(' . absint( $image_size['width'] ) . 'x' . absint( $image_size['height'] ) . ')</small><br><small>' . esc_html( $crop ) . '</small>',
+                                array( $this, 'ext_callback' ),
                                 'kgmdisablethumbnails-admin',
                                 'kgmdisablethumbnails_setting_section',
-                                [ 'name' => $key ]
+                                array( 'name' => $key )
                         );
                 }
@@ -147 +158 @@
          * Sanitize and validate form input before saving.
          *
-         * @since  0.1
-         * @param  array $input Raw form input values.
+         * Runs on every update_option() of this option, not only on form submit, so it
+         * must not depend on the current user: options.php already enforces the nonce
+         * and the manage_options capability before saving.
+         *
+         * Each checkbox posts its own size name as value, so only "size => size" pairs
+         * for sizes registered on this site are kept.
+         *
+         * @since  0.1
+         * @param  mixed $input Raw value; null when every checkbox is unchecked.
          * @return array Sanitized values.
          */
-        public function sanitize( array $input ): array {
-                // Check user capabilities for security
-                if ( ! current_user_can( 'manage_options' ) ) {
-                        return $GLOBALS['dtat_disablethumbnails_options'] ?? get_option( DTAT_THUMBNAILS_OPTION, [] );
-                }
-                
-                // Nonce is already verified by WordPress options.php handler via settings_fields().
-                $sanitary_values = [];
-
-                if ( isset( $input['thumbnail'] ) ) {
-                        $sanitary_values['thumbnail'] = sanitize_text_field( $input['thumbnail'] );
-                }
-                if ( isset( $input['medium'] ) ) {
-                        $sanitary_values['medium'] = sanitize_text_field( $input['medium'] );
-                }
-                if ( isset( $input['medium_large'] ) ) {
-                        $sanitary_values['medium_large'] = sanitize_text_field( $input['medium_large'] );
-                }
-                if ( isset( $input['large'] ) ) {
-                        $sanitary_values['large'] = sanitize_text_field( $input['large'] );
-                }
-
-                $image_sizes = wp_get_additional_image_sizes();
-                foreach ( $image_sizes as $key => $image_size ) {
-                        if ( isset( $input[ $key ] ) ) {
-                                $sanitary_values[ $key ] = sanitize_text_field( $input[ $key ] );
+        public function sanitize( $input ): array {
+                if ( ! is_array( $input ) ) {
+                        return array();
+                }
+
+                $sanitary_values = array();
+                $known_sizes     = array_merge(
+                        array( 'thumbnail', 'medium', 'medium_large', 'large' ),
+                        array_keys( wp_get_additional_image_sizes() )
+                );
+
+                foreach ( $known_sizes as $size ) {
+                        if ( isset( $input[ $size ] ) && sanitize_text_field( $input[ $size ] ) === (string) $size ) {
+                                $sanitary_values[ $size ] = (string) $size;
                         }
                 }
@@ -190 +196 @@
          */
         public function section_info() {
-
         }
 
@@ -203 +208 @@
                         '<label class="switch"><input type="checkbox" name="%s[thumbnail]" id="thumbnail" value="thumbnail" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['thumbnail'] ) && $this->dtat_disablethumbnails_options['thumbnail'] === 'thumbnail' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['thumbnail'] ) && 'thumbnail' === $this->dtat_disablethumbnails_options['thumbnail'] ) ? 'checked' : '',
                         esc_html__( 'Disable Thumbnail size', 'disable-thumbnails-and-threshold' )
                 );
@@ -218 +223 @@
                         '<label class="switch"><input type="checkbox" name="%s[medium]" id="medium" value="medium" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium'] ) && $this->dtat_disablethumbnails_options['medium'] === 'medium' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium'] ) && 'medium' === $this->dtat_disablethumbnails_options['medium'] ) ? 'checked' : '',
                         esc_html__( 'Disable Medium size', 'disable-thumbnails-and-threshold' )
                 );
@@ -233 +238 @@
                         '<label class="switch"><input type="checkbox" name="%s[medium_large]" id="medium_large" value="medium_large" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium_large'] ) && $this->dtat_disablethumbnails_options['medium_large'] === 'medium_large' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['medium_large'] ) && 'medium_large' === $this->dtat_disablethumbnails_options['medium_large'] ) ? 'checked' : '',
                         esc_html__( 'Disable Medium Large size', 'disable-thumbnails-and-threshold' )
                 );
@@ -248 +253 @@
                         '<label class="switch"><input type="checkbox" name="%s[large]" id="large" value="large" %s><span class="screen-reader-text">%s</span><span class="slider" aria-hidden="true"></span></label>',
                         esc_attr( DTAT_THUMBNAILS_OPTION ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['large'] ) && $this->dtat_disablethumbnails_options['large'] === 'large' ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options['large'] ) && 'large' === $this->dtat_disablethumbnails_options['large'] ) ? 'checked' : '',
                         esc_html__( 'Disable Large size', 'disable-thumbnails-and-threshold' )
                 );
@@ -268 +273 @@
                         esc_attr( $name ),
                         esc_attr( $name ),
-                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options[$name] ) && $this->dtat_disablethumbnails_options[$name] === $name ) ? 'checked' : '',
+                        ( is_array( $this->dtat_disablethumbnails_options ) && isset( $this->dtat_disablethumbnails_options[ $name ] ) && $name === $this->dtat_disablethumbnails_options[ $name ] ) ? 'checked' : '',
                         /* translators: %s: Image size name */
                         esc_html( sprintf( __( 'Disable %s size', 'disable-thumbnails-and-threshold' ), $name ) )
                 );
         }
-
 }
 if ( is_admin() ) {
-        $DTAT_Disable_Thumbnails = new DTAT_Disable_Thumbnails();
+        $dtat_disable_thumbnails = new DTAT_Disable_Thumbnails();
 }

disable-thumbnails-and-threshold/trunk/readme.txt

@@ -3 +3 @@
 Donate link: https://kgmservizi.com
 Tags: thumbnails, disable thumbnails, disable threshold, disable images, image options
-Requires at least: 5.4
-Tested up to: 6.8
-Requires PHP: 7.4
-Stable tag: 0.7.0
+Requires at least: 5.6
+Tested up to: 7.1
+Requires PHP: 8.0
+Stable tag: 0.8.0
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -76 +76 @@
 == Changelog ==
 
+= 0.8.0 =
+* Requirements: minimum PHP raised to 8.0 and minimum WordPress to 5.6 (the first release with PHP 8.0 support).
+* Fix: saving the Image Sizes page with every size unchecked caused a fatal error.
+* Fix: settings saved through WP-CLI were silently discarded.
+* Fix: the "cropped" label now appears for custom image sizes registered with cropping.
+* Fix: no fatal error when another plugin hooks `jpeg_quality` or `big_image_size_threshold` with required extra arguments.
+* Coding standards cleanup.
+
 = 0.7.0 =
 * Improved accessibility: toggle switches are now fully keyboard-navigable with visible focus indicators and screen-reader labels.
@@ -98 +106 @@
 == Upgrade Notice ==
 
+= 0.8.0 =
+Requires PHP 8.0+ and WordPress 5.6+. Fixes a fatal error when unchecking every image size.
+
 = 0.7.0 =
 Accessibility, compatibility and performance improvements. No breaking changes — all settings and URLs are preserved. Recommended update for all users.