Changeset 3719914

Timestamp:

09/29/2026 10:04:34 PM (4 weeks ago)

Author:

iamfortunatus

Message:

V3.6.4 is ready.
Fixed strategy planner

Location:

synapost/trunk

Files:

• includes/class-synapost-approval-actions.php (modified) (2 diffs)
• includes/class-synapost-llm-router.php (modified) (2 diffs)
• includes/class-synapost-strategy-planner.php (modified) (11 diffs)
• includes/class-synapost-topics.php (modified) (1 diff)
• readme.txt (modified) (2 diffs)
• synapost.php (modified) (2 diffs)

synapost/trunk/includes/class-synapost-approval-actions.php

@@ -40 +40 @@
          * linked post is deleted outside SynaPost entirely - most commonly,
          * someone deleting it directly from Posts/Pages in wp-admin rather
-         * than using Cancel/Reject here. Without this, the topic's post_id
-         * keeps pointing at a post that no longer exists, and its status
-         * (queued/generating/pending_approval/approved/rejected/failed - all
-         * still "in progress" as far as the topic itself knows) never
-         * changes, so it sits in the Approval Center and Content Pipeline
-         * forever with nothing real behind it.
+         * than using Cancel/Reject here. Deletes the topic outright (not just
+         * marks it "failed") regardless of its status, including an already-
+         * published one: permanently deleting a post is a deliberate,
+         * unambiguous "this content is gone" decision, and the matching
+         * topic record shouldn't linger pointing at nothing - mirrors
+         * SYNAPOST_Topics::delete()'s own sync the other way (deleting a topic
+         * removes its linked post).
          *
          * Hooked to `before_delete_post` specifically, not `deleted_post` -
          * by the time `deleted_post` fires, WordPress has already cascaded
          * the post's own meta rows away, so `_synapost_topic_id` would no longer
-         * be there to read.
-         *
-         * Deliberately does nothing to an already-published topic - deleting
-         * a live post is the site owner's own deliberate call on real,
-         * published content, not a stale-reference cleanup problem, and
-         * silently flipping it to "failed" would just resurface it in the
-         * Pipeline as something needing action that it doesn't.
+         * be there to read. This also means a post merely moved to Trash
+         * (`wp_trash_post`, not `before_delete_post`) is left alone - only an
+         * actual, permanent deletion cascades to the topic.
          */
         public function handle_linked_post_deleted( $post_id, $post ) {
@@ -64 +61 @@
                 }
 
-                $topics = SYNAPOST_Topics::instance();
-                $topic  = $topics->get( $topic_id );
-
-                if ( ! $topic || (int) $topic['post_id'] !== (int) $post_id || 'published' === $topic['status'] ) {
+                $topic = SYNAPOST_Topics::instance()->get( $topic_id );
+                if ( ! $topic || (int) $topic['post_id'] !== (int) $post_id ) {
                         return;
                 }
 
-                $topics->set_status( $topic_id, 'failed' );
-                $topics->link_post( $topic_id, 0 );
+                // $cascade_post = false: this post is already mid-deletion (we're
+                // inside its own before_delete_post), so Topics::delete() must not
+                // try to wp_delete_post() it a second time.
+                SYNAPOST_Topics::instance()->delete( $topic_id, false );
         }
 

synapost/trunk/includes/class-synapost-llm-router.php

@@ -436 +436 @@
          * Providers with confirmed, currently-documented native web search
          * tool support as of this writing:
-         *  - OpenAI: web_search_options on the dedicated gpt-4o-search-preview
-         *    / gpt-4o-mini-search-preview models (Chat Completions API).
+         *  - OpenAI: web_search_options on the dedicated gpt-5-search-api
+         *    model (Chat Completions API). Replaces gpt-4o-search-preview /
+         *    gpt-4o-mini-search-preview, which OpenAI deprecated and shut
+         *    down on 2026-07-23 - see OpenAI's own migration guidance at
+         *    developers.openai.com/api/docs/guides/tools-web-search.
          *  - Anthropic: the web_search_20250305 tool, works with standard
          *    Claude models, no model switch needed.
@@ -467 +470 @@
 
                 // Web search in Chat Completions only works on OpenAI's dedicated
-                // search-preview models - passing web_search_options to any other
+                // gpt-5-search-api model - passing web_search_options to any other
                 // model either errors or is silently ignored, so the model is
                 // swapped for this call specifically rather than trusting whatever
                 // the site owner has set as their general-purpose default.
-                if ( $web_search && false === strpos( $model, 'search-preview' ) ) {
-                        $model = 'gpt-4o-mini-search-preview';
+                // (gpt-4o-mini-search-preview/gpt-4o-search-preview, the previous
+                // dedicated search models this used, were deprecated and shut
+                // down by OpenAI on 2026-07-23.)
+                if ( $web_search && false === strpos( $model, 'search-api' ) ) {
+                        $model = 'gpt-5-search-api';
                 }
 

synapost/trunk/includes/class-synapost-strategy-planner.php

@@ -30 +30 @@
         public function ranges() {
                 return array(
+                        '7'   => __( '7-day plan', 'synapost' ),
                         '30'  => __( '30-day plan', 'synapost' ),
                         '90'  => __( '90-day plan', 'synapost' ),
@@ -37 +38 @@
 
         /**
+         * A single generation call rarely delivers exactly the topic count it
+         * was asked for - a large ask (e.g. 90 topics for a 30-day/3-per-day
+         * plan) is exactly the kind of instruction models tend to under-fill
+         * even when told "exactly N", and the Topic Quality Engine pass
+         * rejects a real fraction on top of that. Rather than silently hand
+         * back whatever survived the first attempt, generate_plan() below
+         * loops - each round asks only for the remaining shortfall and is
+         * itself insert-and-QC'd, so the plan converges on the requested
+         * count (or gets as close as the niche can realistically support)
+         * instead of stopping after one attempt. This constant is the hard
+         * ceiling on how many rounds that loop will make, so a niche that
+         * genuinely can't sustain the requested volume fails soft (returns
+         * whatever it found) rather than looping indefinitely and burning
+         * API calls chasing a count that isn't achievable.
+         */
+        const MAX_TOPUP_ATTEMPTS = 5;
+
+        /**
          * @param int    $profile_id
-         * @param string $range     '30' | '90' | '365'
+         * @param string $range     '7' | '30' | '90' | '365'
          * @param int    $rate      Desired publishing cadence, used to size the topic count.
          * @param string $rate_unit 'day' or 'week' - which unit $rate is expressed in.
@@ -53 +72 @@
                 $context = SYNAPOST_Business_Profile::instance()->to_prompt_context( $profile_id );
 
+                $today_dt  = current_datetime();
+                $start_dt  = $today_dt->add( new DateInterval( 'P1D' ) );
+                $end_dt    = $today_dt->add( new DateInterval( 'P' . $days . 'D' ) );
+                $start_str = $start_dt->format( 'Y-m-d' );
+                $end_str   = $end_dt->format( 'Y-m-d' );
+
+                $category_names = $this->existing_category_names();
+
+                $pillars           = array();
+                $all_topics        = array();
+                $total_inserted    = 0;
+                $total_qc_rejected = 0;
+                $total_skipped     = 0;
+                $last_error        = '';
+
+                for ( $attempt = 1; $attempt <= self::MAX_TOPUP_ATTEMPTS; $attempt++ ) {
+                        $remaining = $topic_count - $total_inserted;
+                        if ( $remaining <= 0 ) {
+                                break;
+                        }
+
+                        $batch = $this->generate_topics_batch( $profile_id, $remaining, $days, $context, $category_names, $start_str, $end_str );
+
+                        if ( empty( $batch['success'] ) ) {
+                                $last_error = $batch['error'];
+                                // A first-attempt failure is a real, reportable error (no
+                                // plan at all was produced). A later attempt failing just
+                                // means the top-up loop stops early with whatever earlier
+                                // rounds already secured, rather than losing that progress
+                                // to one flaky top-up call.
+                                if ( 1 === $attempt ) {
+                                        return array( 'success' => false, 'inserted' => 0, 'error' => $last_error, 'topics' => array() );
+                                }
+                                break;
+                        }
+
+                        if ( ! empty( $batch['pillars'] ) ) {
+                                $pillars = array_values( array_unique( array_merge( $pillars, $batch['pillars'] ) ) );
+                        }
+                        $total_qc_rejected += $batch['qc_rejected'];
+
+                        $insert_result   = SYNAPOST_Topics::instance()->bulk_insert( $batch['topics'], $profile_id, 'strategy_planner' );
+                        $total_inserted += $insert_result['inserted'];
+                        $total_skipped  += $insert_result['skipped_duplicates'];
+                        $all_topics      = array_merge( $all_topics, $batch['topics'] );
+
+                        // This round produced nothing new at all (every proposed topic
+                        // was QC-rejected or a duplicate) - another identical request
+                        // is unlikely to fare better, so stop rather than keep paying
+                        // for rounds that can't make progress.
+                        if ( 0 === $insert_result['inserted'] ) {
+                                break;
+                        }
+                }
+
+                return array(
+                        'success'            => true,
+                        'inserted'           => $total_inserted,
+                        'skipped_duplicates' => $total_skipped,
+                        'qc_rejected'        => $total_qc_rejected,
+                        'error'              => '',
+                        'topics'             => $all_topics,
+                        'pillars'            => $pillars,
+                );
+        }
+
+        /**
+         * One generation round: asks the model for exactly $count topics,
+         * sanitizes them, and runs them through the Topic Quality Engine -
+         * everything generate_plan() used to do in a single pass, now
+         * reusable so its top-up loop can call it again for a shortfall
+         * without duplicating the prompt-building/sanitization logic.
+         *
+         * Deliberately does NOT insert the topics itself - the caller owns
+         * bulk_insert() so it can track the running total across rounds and
+         * decide whether another round is needed from the real, post-insert
+         * count (which also accounts for DB-level duplicate rejection, not
+         * just QC rejection).
+         *
+         * @return array{success:bool, error:string, topics:array, qc_rejected:int, pillars:array}
+         */
+        private function generate_topics_batch( $profile_id, $count, $days, $context, array $category_names, $start_str, $end_str ) {
                 // LLMs have no built-in sense of the current date - left
                 // ungrounded, a model tends to reason as if "today" is somewhere
@@ -58 +159 @@
                 // in the past. Asking for dates "starting tomorrow" without ever
                 // stating what today actually is was producing publish dates
-                // years in the past. Computing explicit, concrete bounds here
-                // (via the site's own clock/timezone, not the model's guess)
-                // removes that ambiguity entirely.
-                $today_dt  = current_datetime();
-                $start_dt  = $today_dt->add( new DateInterval( 'P1D' ) );
-                $end_dt    = $today_dt->add( new DateInterval( 'P' . $days . 'D' ) );
-                $today_str = $today_dt->format( 'Y-m-d' );
-                $start_str = $start_dt->format( 'Y-m-d' );
-                $end_str   = $end_dt->format( 'Y-m-d' );
+                // years in the past. $start_str/$end_str are computed once by
+                // generate_plan() and passed in (same window for every round of
+                // its top-up loop); only "today" itself needs recomputing here.
+                $today_str = current_datetime()->format( 'Y-m-d' );
 
                 $system = "You are a senior content strategist. You design data-informed content calendars built around topic clusters and pillar pages, always tied to real business goals (traffic, leads, authority, sales) rather than random posting."
@@ -87 +183 @@
                 // better to have the model choose real categories from the
                 // start than to catch the mismatch after the fact.
-                $category_names = $this->existing_category_names();
                 $category_instruction = $this->build_category_instruction( $category_names );
 
@@ -94 +189 @@
                 // to simply not propose a repeat in the first place than to have
                 // it silently dropped after generation - dropped duplicates count
-                // against the requested topic_count with nothing to show for it.
+                // against the requested count with nothing to show for it. Built
+                // fresh on every call (rather than once by the caller) so a
+                // top-up round automatically sees titles inserted by earlier
+                // rounds of the same plan too, not just pre-existing topics.
                 $duplicate_instruction = $this->build_duplicate_instruction();
 
@@ -110 +208 @@
                         . "{$research_instruction}\n"
                         . "\n"
-                        . "Build a {$days}-day content strategy containing exactly {$topic_count} topics, organized around 3-6 topic clusters / content pillars that support the business's goals and target audience.\n"
+                        . "Build a {$days}-day content strategy containing exactly {$count} topics, organized around 3-6 topic clusters / content pillars that support the business's goals and target audience.\n"
                         . "\n"
                         . "Return STRICT JSON only, no markdown fences, no commentary, matching this shape exactly:\n"
@@ -136 +234 @@
                                 'prompt'      => $prompt,
                                 'temperature' => 0.6,
-                                'max_tokens'  => max( 4000, min( 16000, $topic_count * 180 ) ),
+                                'max_tokens'  => max( 4000, min( 16000, $count * 180 ) ),
                                 'json'        => true,
                                 'web_search'  => $research_enabled,
@@ -143 +241 @@
 
                 if ( empty( $result['success'] ) ) {
-                        return array( 'success' => false, 'inserted' => 0, 'error' => $result['error'], 'topics' => array() );
+                        return array( 'success' => false, 'error' => $result['error'], 'topics' => array(), 'qc_rejected' => 0, 'pillars' => array() );
                 }
 
@@ -149 +247 @@
 
                 if ( empty( $parsed['topics'] ) || ! is_array( $parsed['topics'] ) ) {
-                        return array( 'success' => false, 'inserted' => 0, 'error' => __( 'The AI response could not be parsed into a topic plan. Try again, or try a different provider/model.', 'synapost' ), 'topics' => array() );
+                        return array( 'success' => false, 'error' => __( 'The AI response could not be parsed into a topic plan. Try again, or try a different provider/model.', 'synapost' ), 'topics' => array(), 'qc_rejected' => 0, 'pillars' => array() );
                 }
 
@@ -158 +256 @@
                 $parsed['topics'] = $this->sanitize_topic_content_style( $parsed['topics'] );
 
-                $before_qc         = count( $parsed['topics'] );
-                $parsed['topics']  = $this->topic_qc_review( $parsed['topics'], $context );
-                $qc_rejected       = $before_qc - count( $parsed['topics'] );
-                $parsed['topics']  = $this->strip_topic_em_dashes( $parsed['topics'] );
-
-                $insert_result = SYNAPOST_Topics::instance()->bulk_insert( $parsed['topics'], $profile_id, 'strategy_planner' );
+                $before_qc        = count( $parsed['topics'] );
+                $parsed['topics'] = $this->topic_qc_review( $parsed['topics'], $context );
+                $qc_rejected      = $before_qc - count( $parsed['topics'] );
+                $parsed['topics'] = $this->strip_topic_em_dashes( $parsed['topics'] );
 
                 return array(
-                        'success'            => true,
-                        'inserted'           => $insert_result['inserted'],
-                        'skipped_duplicates' => $insert_result['skipped_duplicates'],
-                        'qc_rejected'        => $qc_rejected,
-                        'error'              => '',
-                        'topics'             => $parsed['topics'],
-                        'pillars'            => $parsed['pillars'] ?? array(),
+                        'success'     => true,
+                        'error'       => '',
+                        'topics'      => $parsed['topics'],
+                        'qc_rejected' => $qc_rejected,
+                        'pillars'     => $parsed['pillars'] ?? array(),
                 );
         }

synapost/trunk/includes/class-synapost-topics.php

@@ -292 +292 @@
         }
 
-        public function delete( $id ) {
-                global $wpdb;
+        /**
+         * Deleting a topic also removes whatever WordPress post it produced
+         * (if one exists), trashed rather than force-deleted so it's still
+         * recoverable from Trash like any other post deletion in wp-admin -
+         * keeping the two systems in sync in this direction mirrors
+         * SYNAPOST_Approval_Actions::handle_linked_post_deleted()'s sync the
+         * other way (deleting the post removes the topic).
+         *
+         * @param int  $id
+         * @param bool $cascade_post Set false only when the caller already
+         *                           knows the linked post is being deleted by
+         *                           WordPress itself right now (i.e. called
+         *                           from a before_delete_post hook) - avoids
+         *                           the two sync directions calling back into
+         *                           each other over the same post.
+         */
+        public function delete( $id, $cascade_post = true ) {
+                global $wpdb;
+
+                if ( $cascade_post ) {
+                        $topic = $this->get( $id );
+                        if ( $topic && ! empty( $topic['post_id'] ) ) {
+                                wp_delete_post( (int) $topic['post_id'] );
+                        }
+                }
+
                 return $wpdb->delete( $this->table(), array( 'id' => (int) $id ) ); // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
         }

synapost/trunk/readme.txt

@@ -5 +5 @@
 Tested up to: 7.1
 Requires PHP: 7.4
-Stable tag: 3.6.3
+Stable tag: 3.6.4
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -146 +146 @@
 == Changelog ==
 
+= 3.6.4 =
+* Fixed: Deep Research's OpenAI web search call used `gpt-4o-mini-search-preview`, a model OpenAI deprecated and shut down on 2026-07-23. Switched to `gpt-5-search-api`, OpenAI's own documented Chat Completions replacement.
+* Added: a 7-day option to the Strategy Planner's Plan Length.
+* Fixed: the Strategy Planner could fall well short of the requested topic count (e.g. asking for a 30-day plan at 3 posts/day - 90 topics - could produce as few as 14) whenever the model under-generated on a large "exactly N topics" request or the Topic Quality Engine rejected some. It now automatically requests more topics to make up the shortfall (up to 5 rounds) until it reaches the requested count or genuinely can't find more good angles for the niche.
+* Changed: deleting a topic from the Content Library, Pipeline, or Published Content now also deletes its linked WordPress post (moved to Trash, not permanently deleted, so it's still recoverable) - previously only the plugin's own tracking row was removed, leaving the real post behind with nothing managing it. Likewise, permanently deleting a post directly from Posts/Pages in wp-admin now removes its linked SynaPost topic too (previously the topic was just marked "Failed" and left in the database). Merely moving a post to Trash still leaves its topic alone either way - only a real, permanent deletion cascades.
+
 = 3.6.3 =
 * Fixed: the email approval confirmation page's form was completely non-functional - its `<form>`, `<select>`, and hidden `<input>` elements (including the CTA Preset picker, a Pro feature) were being silently stripped by an overly-strict sanitization pass meant for post content, not a standalone HTML page. This affected every action (Publish, Regenerate, Cancel), not only the CTA picker.

synapost/trunk/synapost.php

@@ -4 +4 @@
  * Plugin URI:        https://synapost.ufirstdev.com
  * Description:       AI-Powered Content Operating System for WordPress. Plan, research, write, optimize, approve and publish content without leaving your dashboard.
- * Version:           3.6.3
+ * Version:           3.6.4
  * Requires at least: 6.0
  * Requires PHP:      7.4
@@ -25 +25 @@
  * Core constants.
  */
-define( 'SYNAPOST_VERSION', '3.6.3' );
+define( 'SYNAPOST_VERSION', '3.6.4' );
 define( 'SYNAPOST_PLUGIN_FILE', __FILE__ );
 define( 'SYNAPOST_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );