Changeset 3708610

Timestamp:

09/23/2026 06:22:01 AM (5 weeks ago)

Author:

vCita

Message:

Release 4.6.4 - fix connect flow on fresh installs

Location:

meeting-scheduler-by-vcita/trunk

Files:

• assets/js/utils_v.js (modified) (3 diffs)
• readme.txt (modified) (2 diffs)
• vcita-scheduler.php (modified) (2 diffs)
• vcita-settings-functions.php (modified) (1 diff)

meeting-scheduler-by-vcita/trunk/assets/js/utils_v.js

@@ -23 +23 @@
 
   this.openAuthWin = (reg = false, logout = false) => {
+    // The auth URL resolves asynchronously - on a fresh install getAuthURL()
+    // first registers the site with the scheduler proxy over the network. Opening
+    // the window after that await puts window.open() outside the user-gesture
+    // window, so browsers block it and the click silently does nothing. Open the
+    // window synchronously here, while the gesture is still live, and point it at
+    // the URL once we have it.
+    const win = window.open('', '_blank');
+
     VcitaApi.getAuthURL(reg, logout)
       .then((new_location) => {
@@ -31 +39 @@
             'success': (resp) => {
               try {
-                console.log('responce after login',resp);
-                const ud = JSON.parse(resp);
+                // wp_send_json() replies with Content-Type: application/json, so
+                // jQuery has already parsed this into an object. Calling
+                // JSON.parse() on it threw, the catch below swallowed it, and the
+                // reload never ran - so after connecting you had to refresh by
+                // hand to see that it had worked. Accept either shape.
+                const ud = (typeof resp === 'string') ? JSON.parse(resp) : resp;
                 if (typeof ud.uid == 'string' && ud.uid.length > 0) {
                   if (!reg) {
@@ -54 +66 @@
         };
         
-        const win = window.open(new_location, '_blank');
+        if (!win || win.closed) {
+          // The popup was blocked outright. Navigate this tab instead so the
+          // user can still connect, rather than the button doing nothing.
+          window.location.href = new_location;
+          return;
+        }
+
+        win.location = new_location;
+
         const isCloseInterval = setInterval(() => {
-          if(win.closed) {
+          // win was never null-checked here: when the popup was blocked this
+          // threw "Cannot read properties of null" every 500ms, forever.
+          if (!win || win.closed) {
             clearInterval(isCloseInterval);
             onClose();
           }
         },500)
+      })
+      .catch((err) => {
+        // There was no catch here: if registering the site failed, the promise
+        // rejected silently and the button looked dead.
+        if (win && !win.closed) { win.close(); }
+        console.error('vcita: could not start authentication', err);
+        window.alert('vcita could not be reached. Please check your connection and try again.');
       })
   };

meeting-scheduler-by-vcita/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 4.7
 Tested up to: 7.1
-Stable tag: 4.6.3
+Stable tag: 4.6.4
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
@@ -162 +162 @@
 == Changelog ==
 
+= 4.6.4 =
+ * Fixed: "Let's get started" and "Connect" did nothing on a newly installed site, leaving no way to connect a vcita account. The sign-in window is now opened as soon as you click, and if your browser blocks pop-ups the plugin sends you to vcita in the current tab instead of failing silently.
+ * Fixed: After connecting your vcita account the page now updates on its own. Previously it kept showing you as disconnected until you refreshed by hand, even though the connection had succeeded.
+
 = 4.6.3 =
  * Privacy: Removed all third-party analytics from the plugin. Mixpanel and Hotjar are no longer loaded, and no usage data or account details are sent to any third party.

meeting-scheduler-by-vcita/trunk/vcita-scheduler.php

@@ -4 +4 @@
 Plugin URI: https://www.vcita.com
 Description: This plugin shows your free time slot on your blog and allows you to book appointments with your clients 24x7x365. Very easy Ajax interface. Easy to setup and can be controlled completely from powerful admin area.
-Version: 4.6.3
+Version: 4.6.4
 Author: vCita.com
 Author URI: https://www.vcita.com
@@ -469 +469 @@
         : "vcita.com" ); /* Don't include the protocol, added dynamically */
 define( 'WPSHD_VCITA_SERVER_URL', WPSHD_VCITA_SERVER_PREFIX . WPSHD_VCITA_SERVER_BASE );
-define( 'WPSHD_VCITA_WIDGET_VERSION', '4.6.3' );
+define( 'WPSHD_VCITA_WIDGET_VERSION', '4.6.4' );
 define( 'WPSHD_VCITA_WIDGET_PLUGIN_NAME', 'Appointment Booking and Online Scheduling by vCita' );
 define( 'WPSHD_VCITA_WIDGET_KEY', 'vcita_scheduler' );

meeting-scheduler-by-vcita/trunk/vcita-settings-functions.php

@@ -20 +20 @@
 
   add_submenu_page(WPSHD_VCITA_WIDGET_UNIQUE_ID . '/vcita-settings-functions.php', __('Add to Site', 'meeting-scheduler-by-vcita'), __('Add to Site', 'meeting-scheduler-by-vcita'), 'edit_posts', get_admin_url('','','admin').'admin.php?page='.WPSHD_VCITA_WIDGET_UNIQUE_ID.'/vcita-settings-functions.php&tab=vcita-add-to-site');
-  add_submenu_page(WPSHD_VCITA_WIDGET_UNIQUE_ID . '/vcita-settings-functions.php', __('Custom Implemetation', 'meeting-scheduler-by-vcita'), __('Custom Implemetation', 'meeting-scheduler-by-vcita'), 'edit_posts', get_admin_url('','','admin').'admin.php?page='.WPSHD_VCITA_WIDGET_UNIQUE_ID.'/vcita-settings-functions.php&tab=vcita-custom-impl');
+  add_submenu_page(WPSHD_VCITA_WIDGET_UNIQUE_ID . '/vcita-settings-functions.php', __('Custom Implementation', 'meeting-scheduler-by-vcita'), __('Custom Implementation', 'meeting-scheduler-by-vcita'), 'edit_posts', get_admin_url('','','admin').'admin.php?page='.WPSHD_VCITA_WIDGET_UNIQUE_ID.'/vcita-settings-functions.php&tab=vcita-custom-impl');
   add_submenu_page(WPSHD_VCITA_WIDGET_UNIQUE_ID . '/vcita-settings-functions.php', __('Support', 'meeting-scheduler-by-vcita'), __('Support', 'meeting-scheduler-by-vcita'), 'edit_posts', get_admin_url('','','admin').'admin.php?page='.WPSHD_VCITA_WIDGET_UNIQUE_ID.'/vcita-settings-functions.php&tab=vcita-support');
   add_submenu_page(WPSHD_VCITA_WIDGET_UNIQUE_ID . '/vcita-settings-functions.php', __('Premium', 'meeting-scheduler-by-vcita'), __('Premium', 'meeting-scheduler-by-vcita'), 'edit_posts', get_admin_url('','','admin').'admin.php?page='.WPSHD_VCITA_WIDGET_UNIQUE_ID.'/vcita-settings-functions.php&tab=vcita-premium');