Changeset 3699468

Timestamp:

09/17/2026 03:10:28 AM (5 weeks ago)

Author:

swarnodigital

Message:

0.15.5: All Tables fix, HTML cell click behavior, Advanced Editor Link button, Plugins-page author link

Location:

orki-table-builder-pro/trunk

Files:

• assets/js/admin-editor.js (modified) (3 diffs)
• changelog.txt (modified) (1 diff)
• includes/class-orkitbp-metaboxes.php (modified) (1 diff)
• readme.txt (modified) (2 diffs)
• table-builder-pro.php (modified) (3 diffs)

orki-table-builder-pro/trunk/assets/js/admin-editor.js

@@ -1822 +1822 @@
         }
 
+        // Like the other quicktag buttons, but the Link button needs slightly
+        // different behavior than a plain wrap: an empty href, a placeholder
+        // link text when nothing is selected (matching the task's example
+        // output), and the cursor left inside the href value either way, ready
+        // to type the URL immediately.
+        function insertLinkTag( textarea ) {
+                var start = textarea.selectionStart, end = textarea.selectionEnd;
+                var val = textarea.value;
+                var selected = val.slice( start, end );
+                var linkText = selected || L10n.linkTextPlaceholder || 'Link Text';
+                var before = '<a href="';
+                var after = '">' + linkText + '</a>';
+                textarea.value = val.slice( 0, start ) + before + after + val.slice( end );
+                var hrefPos = start + before.length;
+                textarea.selectionStart = textarea.selectionEnd = hrefPos;
+                textarea.focus();
+        }
+
         // Best-effort: appends closing tags for anything still open, in reverse order.
         function closeOpenTags( textarea ) {
@@ -1983 +2001 @@
                         tagBar.appendChild( button( t[ 0 ], '', function () {
                                 if ( 'link' === t[ 0 ] ) {
-                                        openLinkModal( function ( html ) { insertAtCursor( textarea, html ); } );
+                                        insertLinkTag( textarea );
                                         return;
                                 }
@@ -2358 +2376 @@
                                                 isDragging = true;
                                                 markSelectionOnly();
-                                                // Advanced Cells open straight into the Advanced Editor on
-                                                // a plain click — there's no inline view of them to select
-                                                // into first. Shift/Ctrl-click above deliberately skip
-                                                // this, so multi-selecting a range or a set of cells that
-                                                // happens to include one still works normally.
-                                                if ( 'text' === cell.cellType && cell.isHtml ) {
-                                                        openAdvancedEditor();
-                                                }
+                                                // A plain single click now only selects an HTML/Advanced
+                                                // cell, same as any other cell — it no longer opens the
+                                                // Advanced Editor immediately. Double-click (below) is
+                                                // what opens it, matching how every other cell type
+                                                // already distinguishes "select" from "start editing".
                                         }
                                 } );

orki-table-builder-pro/trunk/changelog.txt

@@ -8 +8 @@
 
 == Changelog ==
+
+= 0.15.5 =
+* Changed HTML/Advanced Cell click behavior: a single click now only selects the cell, matching every other cell type, instead of immediately opening the Advanced Editor. Double-click opens the Advanced Editor, same as it already did. This was an intentional design choice made back in 0.10.0, but made it impossible to simply select an HTML cell (e.g. one made via Insert Link) without the editor popping up.
+* Scoped precisely to the plain-click case: Shift/Ctrl-click for range/multi-selection were unaffected either way, and Enter/F2 and "just start typing" (which also open the Advanced Editor for these cells) are keyboard interactions, not click interactions, and were deliberately left unchanged.
+* No changes to how HTML content is stored, sanitized, or rendered, on the frontend or in the editor — only which click opens the editor.
+* Advanced Editor's Link quicktag button now matches every other formatting button: clicking it immediately inserts an anchor tag (wrapping the current selection if there is one, or a "Link Text" placeholder if not), with the cursor left inside the empty href value ready to type the URL — instead of opening the separate Link modal, which was inconsistent with how b/i/del/ins/code already behave. The standalone "Insert Link" toolbar action (a different feature, for a whole cell) still uses that modal — unchanged.
+* On the Plugins list screen, "Orki" in "By Orki" now links to https://orki.in. Done via the all_plugins filter on the displayed plugin data specifically, not by adding an Author URI header back to the plugin file — that header was removed in 0.14.1 because WordPress.org requires Plugin URI and Author URI to differ, and both would point to the same domain here. This changes only what that one row shows; the actual plugin header stays exactly as WordPress.org validated it.
 
 = 0.15.4 =

orki-table-builder-pro/trunk/includes/class-orkitbp-metaboxes.php

@@ -881 +881 @@
                                 'themeDefault'  => __( '(Theme default)', 'orki-table-builder-pro' ),
                                 'insertMenu'    => __( 'Insert', 'orki-table-builder-pro' ),
+                                'linkTextPlaceholder' => __( 'Link Text', 'orki-table-builder-pro' ),
                                 'addRowAbove'   => __( 'Add above', 'orki-table-builder-pro' ),
                                 'addRowBelow'   => __( 'Add below', 'orki-table-builder-pro' ),

orki-table-builder-pro/trunk/readme.txt

@@ -5 +5 @@
 Tested up to: 7.1
 Requires PHP: 7.4
-Stable tag: 0.15.4
+Stable tag: 0.15.5
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -59 +59 @@
 == Changelog ==
 
+= 0.15.5 =
+* Changed HTML/Advanced Cell click behavior: a single click now only selects the cell, matching every other cell type, instead of immediately opening the Advanced Editor. Double-click opens it, as before. No change to how HTML content is stored or rendered — only which click opens the editor.
+* Advanced Editor's Link button now inserts an anchor tag immediately, like every other formatting button, instead of opening a separate modal.
+* "Orki" in "By Orki" on the Plugins list screen now links to https://orki.in (display-only change, the plugin header itself is untouched). See changelog.txt for the full account of all three changes.
+
 = 0.15.4 =
 * The actual fix for the All Tables blank-until-scroll bug — the two earlier attempts (0.15.2, 0.15.3) were both confirmed by live testing not to work. Real root cause: the tab navigation bar's floated child elements collapsed their container to zero height with nothing to clear them, which under certain other admin CSS on the page left the table below it failing to paint until scroll forced a layout recalculation. Fixed with display: flow-root, the standard modern fix for a collapsed-float container, rather than the generic repaint workarounds tried before. See changelog.txt for the full account.

orki-table-builder-pro/trunk/table-builder-pro.php

@@ -4 +4 @@
  * Plugin URI: https://orki.in
  * Description: Create, style, and manage tables visually, then drop them anywhere with a shortcode or block.
- * Version: 0.15.4
+ * Version: 0.15.5
  * Requires at least: 6.0
  * Requires PHP: 7.4
@@ -21 +21 @@
 // Constants
 // ---------------------------------------------------------------------
-define( 'ORKITBP_VERSION', '0.15.4' );
+define( 'ORKITBP_VERSION', '0.15.5' );
 define( 'ORKITBP_PATH', plugin_dir_path( __FILE__ ) );
 define( 'ORKITBP_URL', plugin_dir_url( __FILE__ ) );
@@ -84 +84 @@
 }
 add_filter( 'plugin_action_links_' . ORKITBP_BASENAME, 'orkitbp_plugin_action_links' );
+
+// ---------------------------------------------------------------------
+// Link "Orki" in the "By Orki" line on the Plugins list screen
+// ---------------------------------------------------------------------
+// Deliberately done here, on the *displayed* plugin data, rather than by
+// adding an "Author URI" header back to the plugin file. That header was
+// removed in 0.14.1 specifically because WordPress.org requires Plugin URI
+// and Author URI to be different values, and both would point to
+// https://orki.in — restoring it would reintroduce that exact rejection.
+// This only changes what this one row shows on this one admin screen; the
+// actual plugin header (what WordPress.org's own validation reads) is
+// untouched.
+function orkitbp_link_author_name_on_plugins_page( $plugins ) {
+        if ( isset( $plugins[ ORKITBP_BASENAME ] ) ) {
+                $plugins[ ORKITBP_BASENAME ]['Author'] = '<a href="https://orki.in/" target="_blank" rel="noopener noreferrer">Orki</a>';
+        }
+        return $plugins;
+}
+add_filter( 'all_plugins', 'orkitbp_link_author_name_on_plugins_page' );