Changeset 3686562

Timestamp:

09/08/2026 12:12:32 PM (7 weeks ago)

Author:

megamenu

Message:

Guard nav_menu_locations cache invalidation to genuine save contexts (admin, REST, AJAX), preventing Polylang/WPML front-end language switches from wiping and

regenerating the entire CSS cache on nearly every request.

File:

• megamenu/trunk/classes/style-manager.class.php (modified) (3 diffs)

megamenu/trunk/classes/style-manager.class.php

@@ -103 +103 @@
                  * Defer to `shutdown` so `nav_menu_locations` is saved before regeneration (see `set_theme_mod`).
                  *
+                 * Only acts on `set_theme_mod()` calls made from a genuine admin/API save context (Customizer,
+                 * nav-menus.php, REST). Multilingual plugins such as Polylang/WPML can end up calling
+                 * `set_theme_mod( 'nav_menu_locations', ... )` on plain front-end requests to swap in the
+                 * current language's menu; treating that as a real reassignment would wipe and regenerate the
+                 * entire CSS cache (all languages) on almost every request. See `Mega_Menu_Integration_Polylang`.
+                 *
                  * @param array|false $new_value New location => menu ID map.
                  * @param array|false $old_value Previous map or false.
@@ -108 +114 @@
                  */
                 public function schedule_delete_cache_on_nav_menu_locations_change( $new_value, $old_value ) {
+                        if ( ! $this->is_genuine_nav_menu_locations_save() ) {
+                                return is_array( $new_value ) ? $new_value : [];
+                        }
+
                         if ( ! is_array( $new_value ) ) {
                                 $new_value = [];
@@ -141 +151 @@
 
                 /**
+                 * Whether the current request is a context where a user (or the REST API on their behalf)
+                 * could genuinely be saving menu-location assignments, as opposed to a plain front-end
+                 * request where a multilingual plugin may be swapping the theme mod value transiently.
+                 *
+                 * @since 3.11.0
+                 * @return bool
+                 */
+                private function is_genuine_nav_menu_locations_save() {
+                        if ( is_admin() ) {
+                                return true;
+                        }
+
+                        if ( defined( 'REST_REQUEST' ) && REST_REQUEST ) {
+                                return true;
+                        }
+
+                        if ( wp_doing_ajax() ) {
+                                return true;
+                        }
+
+                        return apply_filters( 'megamenu_is_genuine_nav_menu_locations_save', false );
+                }
+
+
+                /**
                  * Run after theme mods are persisted so `get_nav_menu_locations()` matches the new assignments.
                  *