Changeset 3639213

Timestamp:

08/09/2026 09:45:25 AM (3 months ago)

Author:

fizteq

Message:

Release 1.0.14: report the real PHP error level so warnings and deprecations are ranked properly; enforce reported levels inside the handler; retina banner

Location:

fizteq-pulse

Files:

• assets/banner-1544x500.png (added)
• assets/banner-772x250.png (modified) ( previous)
• trunk/includes/monitors/class-monitor-errors.php (modified) (5 diffs)
• trunk/readme.txt (modified) (2 diffs)
• trunk/wppulse.php (modified) (2 diffs)

fizteq-pulse/trunk/includes/monitors/class-monitor-errors.php

@@ -25 +25 @@
     private $max_frames = 50;
 
+    /**
+     * Error levels we report, and the only ones handle_error() acts on.
+     *
+     * This is deliberately both the set_error_handler() mask and an explicit
+     * check inside the handler. The mask alone only governs what PHP itself
+     * dispatches: when another plugin or theme registers its own handler and
+     * chains to the previous one with call_user_func, our handler is invoked
+     * directly for every level and the mask is bypassed entirely. That is how
+     * deprecations reached the dashboard before this — arriving as E_UNKNOWN,
+     * from a site whose theme chains handlers, while the mask said E_USER_ERROR.
+     *
+     * We want them, but on purpose rather than by accident: a deprecation is how
+     * the site owner learns their theme breaks on the next PHP release. The
+     * dashboard classifies notices and deprecations as info, so they land in a
+     * daily summary rather than an immediate alert.
+     *
+     * E_STRICT is omitted: it has been deprecated as a constant since PHP 8.4
+     * and referencing it would have this plugin emit the very thing it reports.
+     *
+     * @return int
+     */
+    private function reported_levels()
+    {
+        return E_ERROR | E_WARNING | E_PARSE | E_NOTICE
+            | E_CORE_ERROR | E_CORE_WARNING
+            | E_COMPILE_ERROR | E_COMPILE_WARNING
+            | E_USER_ERROR | E_USER_WARNING | E_USER_NOTICE
+            | E_RECOVERABLE_ERROR | E_DEPRECATED | E_USER_DEPRECATED;
+    }
+
     public static function get_key()
     {
@@ -38 +68 @@
         $this->previous_exception_handler = set_exception_handler([$this, 'handle_exception']);
         // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_set_error_handler -- Error tracking is the plugin's core purpose.
-        $this->previous_error_handler = set_error_handler([$this, 'handle_error'], E_USER_ERROR);
+        $this->previous_error_handler = set_error_handler([$this, 'handle_error'], $this->reported_levels());
         register_shutdown_function([$this, 'handle_shutdown']);
     }
@@ -70 +100 @@
 
     /**
-     * Handle PHP errors (E_USER_ERROR).
+     * Handle a PHP error.
+     *
+     * The errno check is not redundant with the set_error_handler() mask — see
+     * reported_levels(). A chained handler calling us directly bypasses the mask,
+     * so without this the plugin reports whatever that handler happened to
+     * receive, including levels it was never configured for.
+     *
+     * Also honours the site's own error_reporting() level, so a host that has
+     * switched deprecations off is not overridden by us.
      *
      * @param int $errno
@@ -80 +118 @@
     public function handle_error($errno, $errstr, $errfile, $errline)
     {
+        $reportable = ($errno & $this->reported_levels()) && (error_reporting() & $errno);
+
+        if (! $reportable) {
+            if ($this->previous_error_handler !== null) {
+                return call_user_func($this->previous_error_handler, $errno, $errstr, $errfile, $errline);
+            }
+
+            return false;
+        }
+
         try {
             if (! $this->is_handling && $this->errors_reported < $this->max_errors_per_request) {
@@ -234 +282 @@
     private function error_type_string($type)
     {
+        /**
+         * The dashboard maps these names to a severity, so an unmapped level
+         * costs more than a cosmetic label: everything used to collapse to
+         * E_UNKNOWN, which is classified critical, and a theme's deprecations
+         * therefore alerted like fatals.
+         */
         $map = [
             E_ERROR => 'E_ERROR',
+            E_WARNING => 'E_WARNING',
             E_PARSE => 'E_PARSE',
+            E_NOTICE => 'E_NOTICE',
             E_CORE_ERROR => 'E_CORE_ERROR',
+            E_CORE_WARNING => 'E_CORE_WARNING',
             E_COMPILE_ERROR => 'E_COMPILE_ERROR',
+            E_COMPILE_WARNING => 'E_COMPILE_WARNING',
             E_USER_ERROR => 'E_USER_ERROR',
+            E_USER_WARNING => 'E_USER_WARNING',
+            E_USER_NOTICE => 'E_USER_NOTICE',
+            E_RECOVERABLE_ERROR => 'E_RECOVERABLE_ERROR',
+            E_DEPRECATED => 'E_DEPRECATED',
+            E_USER_DEPRECATED => 'E_USER_DEPRECATED',
         ];
 

fizteq-pulse/trunk/readme.txt

@@ -4 +4 @@
 Requires at least: 5.9
 Tested up to: 7.0
-Stable tag: 1.0.13
+Stable tag: 1.0.14
 Requires PHP: 7.4
 License: GPLv2 or later
@@ -157 +157 @@
 == Changelog ==
 
+= 1.0.14 =
+* New: PHP warnings, notices and deprecations are now reported with their actual error level, so the dashboard can rank them properly — deprecations and notices appear in your daily summary instead of alerting like a fatal error
+* Fix: the error levels the plugin reports are now enforced inside the handler as well as declared. A theme or plugin that installs its own error handler and chains to ours could previously feed us levels we were never configured to collect
+* The site's own error_reporting() level is now respected, so a host that has switched deprecation notices off is no longer overridden
+
 = 1.0.13 =
 * Fix: sites updating from an earlier version now report their plugin and theme inventory straight away, instead of waiting for the next daily check

fizteq-pulse/trunk/wppulse.php

@@ -4 +4 @@
  * Plugin URI: https://wp-pulse.app
  * Description: Error tracking and site health monitoring for WordPress agencies. Reports errors, plugin changes, and health data to your WPPulse dashboard.
- * Version: 1.0.13
+ * Version: 1.0.14
  * Author: FizteQ
  * Author URI: https://fizteq.com
@@ -25 +25 @@
 }
 
-define('WPPULSE_VERSION', '1.0.13');
+define('WPPULSE_VERSION', '1.0.14');
 define('WPPULSE_PLUGIN_FILE', __FILE__);
 define('WPPULSE_PLUGIN_DIR', plugin_dir_path(__FILE__));