Changeset 1179092

Timestamp:

06/11/2015 04:49:22 PM (10 years ago)

Author:

Henry Krupp

Message:

vulnerability removed

Location:

paypal-currency-converter-basic-for-woocommerce/trunk

Files:

• Readme.txt (modified) (2 diffs)
• assets/js/ppcc_script.js (modified) (2 diffs)
• paypalcc-basic.php (modified) (3 diffs)
• proxy.php (deleted)

paypal-currency-converter-basic-for-woocommerce/trunk/Readme.txt

@@ -90 +90 @@
 * Tested with WooCommerce 2.3.2 
 
+= 1.4 =
+* Vulnerability, due to google currency lookup removed
+
 == Upgrade Notice ==
 
@@ -108 +111 @@
 * trial version
 * Tested with WooCommerce 2.3.2 
+
+= 1.4 =
+* Vulnerability, due to google currency lookup removed

paypal-currency-converter-basic-for-woocommerce/trunk/assets/js/ppcc_script.js

@@ -1 +1 @@
 jQuery(document).ready(function() {
     jQuery( ".settings-error" ).hide();
-    get_ajax("#gc");
-    var googlerate=jQuery('#currency_converter_result span.bld').text().replace(/[^\d\.]/g, '');
-    googlerate = Math.round(googlerate * 1000) / 1000000;
-    //jQuery("#gc").html(currency()+' ***'+php_data.target_currency+'/'+php_data.source_currency);
-    //jQuery("#gc").html(googlerate + ' ***' + php_data.target_currency + '/' + php_data.source_currency);
 
     jQuery('#selected_currency').val(currency() + ' ' + php_data.target_currency + '/' + php_data.source_currency);
@@ -50 +45 @@
     return currate;
 }
-
-function get_ajax(my_target){
-        var answer = jQuery.get(php_data.proxy,{ requrl: php_data.requrl},
-            function(data) {
-                jQuery(my_target).html(data);
-                jQuery('#selected_currency').val(currency()+' '+php_data.target_currency+'/'+php_data.source_currency);
-                if (jQuery('#cr').val()==currency()){
-                    jQuery('#cr').css('color', 'green');
-                }else{
-                    jQuery('#cr').css('color', 'red');
-                    jQuery( ".settings-error" ).show();
-                }
-            }
-        );
-    }

paypal-currency-converter-basic-for-woocommerce/trunk/paypalcc-basic.php

@@ -3 +3 @@
  * Plugin URI: http://www.intelligent-it.asia
  * Description: Convert any currency to allowed PayPal currencies for PayPal's Payment Gateway within WooCommerce
- * Version: 1.3
+ * Version: 1.4
  * Author: Intelligent-IT.asia
  * Author URI: http://www.intelligent-it.asia
@@ -189 +189 @@
 
             $data = array(  
-                            'proxy' => plugins_url( 'proxy.php', __FILE__ ),
                             'source_currency' => get_woocommerce_currency(),
                             'target_currency' => $options['target_currency'],
                             'amount'=>$exrdata,
-                            'requrl'=>'https://www.google.com/finance/converter?a=1&from='.get_woocommerce_currency().'&to='.$options['target_currency'],
                             );
                             
@@ -248 +246 @@
                         <td class="forminp">'. $currency_selector .'</td>
                     </tr>
-                    <tr valign="top">
-                        <th class="titledesc" scope="row"><label >'. __('Google\'s conversion rate','PPAC').':</label >
-                            <img class="help_tip" data-tip="'.__('For informational purpose, only 4 digits accuracy (not used for calculations).','PPAC').'" src="'.plugins_url().'/woocommerce/assets/images/help.png" height="16" width="16" />
-                        </th>
-                        
-                        <td class="forminp">
-                            <a href="https://www.google.com/finance?q='. $fromto .'" title="Google Finance"><div id="gc"><img src="' . plugins_url() . '/woocommerce/assets/images/ajax-loader.gif" alt="loading..." /></div></a>
-                            <img src="https://www.google.com/finance/chart?q=CURRENCY:'. $fromto .'&tkr=1&p=5Y&chst=vkc&chs=400x140"></img><br/>
-                        </td>
-                    </tr>
-
                     <tr valign="top">
                         <th class="titledesc" scope="row">