Opened 13 months ago

#1515 new defect

Fatal error in PHP 5.4 - call-time pass-by-reference

Reported by: scholesmafia Owned by: mjgiarlo
Priority: highest Component: openid
Severity: blocker Keywords: openid fatal php5.4 reference
Cc:

Description

A number of function calls in the plugin use call-time pass-by-reference, which is deprecated as of PHP 5.3 and produces a fatal error as of PHP 5.4. All errors are in the JanRain library.

Running grep -nRFIB1 '&$' . on the plugin repository root yields 5 separate places where such a call is made (ignoring references in function declarations):

  • ./Auth/Yadis/Yadis.php:144
  • ./Auth/Yadis/XRDS.php:432
  • ./Auth/OpenID/Consumer.php:669
  • ./Auth/OpenID/Server.php:1707
  • ./Auth/OpenID/TrustRoot.php:416

Attachments (1)

reference.diff​ (2.5 KB) - added by scholesmafia 13 months ago.
Fix to call-time pass-by-reference

Download all attachments as: .zip

Change History (1)

Changed 13 months ago by scholesmafia

Fix to call-time pass-by-reference

Note: See TracTickets for help on using tickets.